percona/percona-toolkit
1
0
Fork 0
mirror of https://github.com/percona/percona-toolkit.git synced 2025-09-26 15:31:55 +00:00
Code Issues Packages Projects Releases Wiki Activity
5,821 Commits 141 Branches 71 Tags
9c98f75ce8c33da1424b749f21d394fdbadb38a0
Commit Graph

2640 Commits

Author SHA1 Message Date
Sveta Smirnova
2b5ceb9fee Merge pull request #1002 from Shopify/PT-2015_fix_comparing_unsorted_flags 
PT-2015 Fix pt-config-diff not sorting flags
 2025-09-02 14:56:24 +03:00
Sveta Smirnova
c5c6bf34c6 Merge pull request #1003 from percona/PT-2305_pt-online-schema-change_should_error_if_server_is_a_slave_in_row_based_replication 
PT-2305 - pt-online-schema-change should error if server is a slave in row based replication
 2025-09-02 14:55:48 +03:00
Sveta Smirnova
0d0e7210f7 PT-2322 - pt-mysql-summary does not detect jemalloc. 
- Added fix and test case. Fix checks for end of word (space or newline) instead of space.
 2025-08-29 15:09:12 +03:00
Sveta Smirnova
699b28d2a3 PT-2305 - pt-online-schema-change should error if server is a slave in row based replication 
- Removed use Data::Dumper
 2025-08-29 13:52:09 +03:00
Sveta Smirnova
ab620a6707 PT-2305 - pt-online-schema-change should error if server is a slave in row based replication 
- Implemented fix and test case
- Updated documentation
 2025-08-29 01:33:18 +03:00
Hartley McGuire
47f7638d60 PT-2015 Fix pt-config-diff not sorting flags 
Previously, flags would be compared in the exact order they are output
by MySQL, which can result in false negatives if the input ordering does
not match.

Example from the ticket:

```
[root@avvr-dbm51 ~]# pt-config-diff /etc/my.cnf h=localhost,P=3047
1 config difference
Variable                  /etc/my.cnf  avvr-dbm51
========================= ============ ============
myisam_recover_options    FORCE,BACKUP BACKUP,FORCE
```

This commit fixes the issue by sorting the flags before comparison to
ensure that any ordering differences will not report a diff.

Co-authored-by: Jonathan Gnagy <jonathan@therubyist.org>
 2025-08-27 16:12:27 +00:00
Sveta Smirnova
6854715795 Merge pull request #891 from ehooi/PT-2401 
PT-2401 - remove check to fix the 'table does not exist' problem when lower_case_table_names=2 is set
 2025-08-26 19:44:15 +03:00
Sveta Smirnova
c1d3ebc72a Merge pull request #995 from percona/PT-2435_t_pt-online-schema-change_pt-1717-resume.t_fails_after_PT-2355_fix 
PT-2435 - t/pt-online-schema-change/pt-1717-resume.t fails after PT-2…
 2025-08-26 19:43:32 +03:00
Sveta Smirnova
670f4d159b Merge pull request #992 from percona/PT-1423_LP_1682929_pt-table-checksum_First_chunk_takes_too_long 
PT-1423 - LP #1682929: pt-table-checksum: First chunk takes too long
 2025-08-26 19:43:16 +03:00
Sveta Smirnova
a0dffc51e4 Merge pull request #989 from agejevasv/fix-precedence-error 
Fix script crashing with precedence error
 2025-08-26 19:43:00 +03:00
Sveta Smirnova
9e799fd04b Merge pull request #981 from Nyele93/PT-2465_patch_fix_for_mariadb_10.5_above 
PT-2465 patch fix for erroneous flavour mismatch in mariadb-10.5.x and above
 2025-08-26 19:42:44 +03:00
Sveta Smirnova
30f2ae5fee Update bin/pt-duplicate-key-checker 2025-08-26 19:39:53 +03:00
Sveta Smirnova
495869da3e PT-2440 - Support for MariaDB 10.5 
- Updated non-libraries code in bin/pt-heartbeat, bin/pt-replica-restart, and bin/pt-slave-delay
- Adjusted lib/Sandbox.pm, so it does not require SSL for MariaDB
- Adjusted test case, so it is in line with other tests
 2025-08-23 03:32:33 +03:00
utdrmac
01db562b10 some spelling mistake 2025-08-20 16:34:30 -05:00
utdrmac
be598413ef add invisible option to pt-duplicate-key-checker 2025-08-20 16:06:16 -05:00
Sveta Smirnova
d60ffe0654 PT-2435 - t/pt-online-schema-change/pt-1717-resume.t fails after PT-2355 fix 
- Fixed code that incorrectly stored boundaries
 2025-08-18 21:22:41 +03:00
Nyele93
a97c422851 PT-2465 patch fix for erroneous flavour mismatch in mariadb-10.5.x and above. This patch includes the fixed regex for checking DB flavour to include the case-insensitive marker i on the searches for MariaDB 2025-08-18 17:42:10 +03:00
Sveta Smirnova
825dea7547 PT-1423 - LP #1682929: pt-table-checksum: First chunk takes too long 
- Modified the tool, so if both --chunk-size and --chunk-time are specified, it starts chunking with the indicated --chunk-size, and then adjusts chunk size to fit the time.
 2025-08-16 02:01:22 +03:00
Sveta Smirnova
3d0c0c623f Merge branch '3.x' into HEAD 2025-08-15 17:18:09 +03:00
Sveta Smirnova
75feef2f96 PT-2401 - pt-online-schema-change 'table does not exist' on macos 
- Modified code, so it still checks table name but based on the lower_case_table_names option
 2025-08-15 17:16:37 +03:00
Sveta Smirnova
82a2ac7a40 PR-989 - Fix script crashing with precedence error 
- Fixed typo in the tool code
- Added more diagnostic information into test for pt-1919
 2025-08-13 17:03:29 +03:00
Sveta Smirnova
702f837698 Merge pull request #988 from percona/PT-2052_Tools_should_default_to_unbuffered_stdout_stderr 
Pt 2052 tools should default to unbuffered stdout stderr
 2025-08-13 14:22:57 +03:00
Viktoras Agejevas
58cebefdcc Fix script crashing with precedence error 
On Perl v5.42.0 the process exits with status 255 and error: Possible precedence problem between ! and string eq at pt-online-schema-change line 10633.
 2025-08-06 16:47:21 +03:00
Sveta Smirnova
0b91854014 Merge pull request #982 from percona/PT-191_add_ssl_options_to_DSN 
PT-191 - add ssl options to DSN
 2025-08-06 16:30:28 +03:00
Sveta Smirnova
734d6231c2 PT-2052 - Tools should default to unbuffered stdout/stderr 
- Added option --[no]buffer-stdout, enabled by default
 2025-08-05 18:24:01 +03:00
nilnandan
6588510632 PT-1718 - Have pt-stalk collect performance_schema.threads along with information_schema.processlist 
- Update collect.sh file and add code for collecting threads details.
- Add PT-1718-threads.t test file for testing this fix.
 2025-07-30 14:11:43 +00:00
Sveta Smirnova
2bea8ac44b PT-191 - add ssl options to DSN 
- Added test t/pt-replica-find/ssl.t
- Added option --mysql_ssl to all tools that support own connection
  options
 2025-07-29 22:02:49 +03:00
Sveta Smirnova
2954d5a749 PT-191 - add ssl options to DSN 
- Typo in t/pt-index-usage/ssl.t
- Missed test t/pt-query-digest/ssl.t
- Missed option --mysql_ssl in pt-query-digest
 2025-07-28 19:05:00 +03:00
Sveta Smirnova
7a8fee3d86 Merge pull request #974 from marek-knappe/PT-2457-pt-online-schema-change-add-drop-tablespace-Option 
fix(pt-online-schema-change): correct --remove-data-dir default behav…
 2025-07-23 13:11:59 +03:00
Sveta Smirnova
8f068a9d59 PT-2418 - pt-online-schema-change 3.7.0 lost data when exe alter xxx rename column xxx 
- Added clean up to the test
- Added test for enabled option --check-alter
- Removed extra spaces
 2025-07-21 16:45:10 +03:00
Marek Knappe
4a9a4bb903 PT-2418: Fix column data loss during RENAME COLUMN operations 
The pt-online-schema-change tool was not properly handling RENAME COLUMN
syntax (MySQL 8.0+), causing renamed columns to be excluded from the
data copy operation. This resulted in NULL values for renamed columns
after the schema change.

The issue was in the find_renamed_cols() function which only supported
CHANGE COLUMN syntax but not RENAME COLUMN syntax. Added support for
RENAME COLUMN parsing to properly detect column renames and include
them in the common_cols list for data copying.

Fixes: PT-2418
 2025-07-02 12:45:00 +10:00
Marek Knappe
6c9ed6ed5b Changed optionparser to allow for default: no to be false and run update-modules #PT-2457 2025-06-25 10:58:43 +10:00
Marek Knappe
d0d046122b fix(pt-online-schema-change): correct --remove-data-dir default behavior (#PT-2458) 
- Fixed issue where --remove-data-dir incorrectly defaulted to true

feat(pt-online-schema-change): add support for TABLESPACE removal (#PT-2457)
- Implemented detection and removal of TABLESPACE clause during schema changes
 2025-06-24 17:09:55 +10:00
Sveta Smirnova
d5d39a83fa Merge pull request #890 from dbnski/long-variable-values 
pt-config-diff: MySQL truncates run-time variable values longer than 1024 characters
 2025-06-22 15:53:09 +03:00
Sveta Smirnova
b3bf684f39 Merge pull request #947 from percona/PT-2129_pt-online-schem-change_fails_on_non-readable_version_check_file 
PT-2129 - pt-online-schem-change and other tools fail on non-readable…
 2025-06-13 02:09:35 +03:00
Sveta Smirnova
528007e2b0 Merge pull request #953 from pakud/patch-2 
Update documentation of pt-query-digest - better description for --output secure-slowlog
 2025-06-12 17:37:25 +03:00
Sveta Smirnova
46f5a2d220 Merge pull request #945 from percona/PT-2424_Typo_in_pt-table-checksum_error_message_--resume_and_--no-empty-replicate-table_are_mutually_exclusive 
PT-2424 - Typo in pt-table-checksum error message "--resume and --no-…
 2025-06-12 17:29:25 +03:00
Maciej Dobrzanski
55f2167ed0 - Updated MySQLConfig.pm to correctly support very long variable values 
- Added test cases for pt-config-diff
 2025-06-06 20:39:24 +02:00
Taehyung Lim
5989d2883c remove check to fix the 'table does not exist' problem when lower_case_table_names=2 is set 2025-05-19 20:09:04 +09:00
Paweł Kudzia
d2db8f5789 Update pt-query-digest 
pt-query-digest - fixing documentation for --output secure-slowlog option
 2025-04-17 14:11:01 +02:00
Sveta Smirnova
ef2dbd887f PT-2129 - pt-online-schem-change and other tools fail on non-readable version check file 
- Implemented fix in lib/VersionCheck.pm
- Updated modules in all tools
- Added test case to t/pt-query-digest/version_check.t
 2025-03-29 23:22:44 +03:00
Sveta Smirnova
ebacadf098 Revert "PT-2424 - Typo in pt-table-checksum error message "--resume and --no-empty-replicate-table are mutually exclusive"" 
This reverts commit e964e17f21.
 2025-03-27 21:40:32 +03:00
Sveta Smirnova
c49c58db2b Merge pull request #941 from percona/PT-2355_pt-online-schema-change_should_not_resume_a_job_with_empty_boundaries 
PT-2355 - pt-online-schema-change should not resume a job with empty …
 2025-03-27 21:13:43 +03:00
Sveta Smirnova
9711db87a7 Merge pull request #944 from percona/PT-2407_pt-online-schema-change_exit_stauts_return_code_is_0_even_if_it_does_NOT_succeed 
PT-2407 - pt-online-schema-change exit status(return code) is 0 even …
 2025-03-27 21:13:27 +03:00
Sveta Smirnova
905490bac5 PT-2424 - Typo in pt-table-checksum error message "--resume and --no-empty-replicate-table are mutually exclusive" 
- Fixed typo
- Added test case
 2025-03-27 21:11:31 +03:00
Sveta Smirnova
e964e17f21 PT-2424 - Typo in pt-table-checksum error message "--resume and --no-empty-replicate-table are mutually exclusive" 
- Fixed typo
- Added test case
 2025-03-27 21:09:10 +03:00
Sveta Smirnova
c3a201d5f8 Update bin/pt-online-schema-change 2025-03-26 18:37:42 +03:00
Sveta Smirnova
2474b1f45b Update bin/pt-online-schema-change 2025-03-26 18:35:41 +03:00
Sveta Smirnova
88367c1dea PT-2407 - pt-online-schema-change exit status(return code) is 0 even if it does NOT succeed 
- Changed die call for the case when ALTER TABLE fails for the new table
- Removed stalled comment from Frank
- Added test case
 2025-03-26 17:51:35 +03:00
Sveta Smirnova
840ba6926b PT-2355 - pt-online-schema-change should not resume a job with empty boundaries 
- The tool should still fail, so I improved error message and added test case
 2025-03-22 00:01:56 +03:00