percona/percona-toolkit
1
0
Fork 0
mirror of https://github.com/percona/percona-toolkit.git synced 2025-09-01 18:25:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #944 from percona/PT-2407_pt-online-schema-change_exit_stauts_return_code_is_0_even_if_it_does_NOT_succeed

Browse Source 
PT-2407 - pt-online-schema-change exit status(return code) is 0 even …
This commit is contained in:
Sveta Smirnova
2025-03-27 21:13:27 +03:00
committed by GitHub
parent e964e17f21 c3a201d5f8
commit 9711db87a7
3 changed files with 97 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
bin/pt-online-schema-change
View File

@@ -9607,11 +9607,16 @@ sub main {
# ''
# doesn't match '(?-xism:Failed to find a unique new table name)'
# (*) Frank: commented them out because it caused infinite loop
# and the mentioned test error doesn't arise
my $original_error = $EVAL_ERROR;
my $original_error_code = $?;
my $original_error_code;
if ( $? ) {
$original_error_code = $?;
}
else {
$original_error_code = $!;
}
$SIG{__DIE__} = 'DEFAULT';
foreach my $task ( reverse @cleanup_tasks ) {
eval {
@@ -9921,10 +9926,12 @@ sub main {
$cxn->dbh()->do($sql);
};
if ( $EVAL_ERROR ) {
if ( $plugin && $plugin->can('before_die') ) {
$plugin->before_die(exit_status => $EVAL_ERROR);
}
if ( $plugin && $plugin->can('before_die') ) {
$plugin->before_die(exit_status => $EVAL_ERROR);
}
# this is trapped by a signal handler. Don't replace it with _die
# we need to override $SIG{__DIE__} to return correct error code
$SIG{__DIE__} = sub { print(STDERR "$_[0]"); exit ERROR_ALTERING_TABLE; };
die "Error altering new table $new_tbl->{name}: $EVAL_ERROR\n";
}
print "Altered $new_tbl->{name} OK.\n";