percona/percona-toolkit
1
0
Fork 0
mirror of https://github.com/percona/percona-toolkit.git synced 2025-09-26 15:31:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1003 from percona/PT-2305_pt-online-schema-change_should_error_if_server_is_a_slave_in_row_based_replication

Browse Source 
PT-2305 - pt-online-schema-change should error if server is a slave in row based replication
This commit is contained in:
Sveta Smirnova
2025-09-02 14:55:48 +03:00
committed by GitHub
parent 0e3a18c378 699b28d2a3
commit c5c6bf34c6
2 changed files with 193 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

37
bin/pt-online-schema-change
View File

@@ -9181,6 +9181,41 @@ sub main {
channel => $o->get('channel'),
);
# Check if we are not a replica of the source server with ROW or MIXED base replication
if ( !$o->get('force') ) {
my $source = $ms->get_source_dsn($cxn->dbh(), $dsn, $dp);
if ( $source ) {
my $source_cxn = $make_cxn->(dsn => $source);
# Check source
my $is_source_of = eval {
$ms->is_source_of($source_cxn->{dbh}, $cxn->{dbh});
};
# We should not die if replica connected via tunnel or port redirection
if ( $EVAL_ERROR ) {
$EVAL_ERROR =~ m/The replica is connected to (\d+) but the source's port is \d+/;
if ( !$1 || $1 != $source->{P} ) {
$is_source_of = 0;
}
}
if ( $is_source_of) {
my $source_binlog_format = $source_cxn->dbh()->selectrow_arrayref("SHOW GLOBAL VARIABLES LIKE 'binlog_format'");
if ( uc @$source_binlog_format[1] ne 'STATEMENT' ) {
_die("Server " . $dp->as_string($cxn->dsn())
. " is a replica of " . $dp->as_string($source_cxn->dsn())
. " running with binary log format "
. "@${source_binlog_format[1]}, therefore we cannot guarantee "
. "that all replication updates will be applied to the new table.\n"
. "Exiting.\n"
. "If you want to bypass this check, specify option --force.",
NO_MINIMUM_REQUIREMENTS);
}
}
}
}
my $slaves_to_skip = $o->get('skip-check-replica-lag');
my $get_replicas_cb = sub {
@@ -13305,6 +13340,8 @@ This option bypasses confirmation in case of using alter-foreign-keys-method = n
This option also allows to use option --where without options --no-drop-new-table and --no-swap-tables.
This option also allows to bypass the safety check that prevents the tool from running on replica that is replicating from a source with binary log format ROW or MIXED.
=item --help
Show help and exit.