percona/percona-toolkit
1
0
Fork 0
mirror of https://github.com/percona/percona-toolkit.git synced 2025-09-11 13:40:07 +00:00
Code Issues Packages Projects Releases Wiki Activity
197 Commits 143 Branches 71 Tags
73c1e466d77e5ab4d8c95f5f5a97c007121b8e32
Commit Graph

94 Commits

Author SHA1 Message Date
Brian Fraser
73c1e466d7 Several fixes & changes: 
* qtime and stime computed correctly
* Interactive mode and changing groups doesn't fail
* Interactive mode no longer uses a file to gather samples.
 2012-01-30 17:44:18 -03:00
Brian Fraser
ad552756b2 Automatic headers & improvements. 2012-01-18 19:01:19 -03:00
Brian Fraser
5b43ed0d5e More changes as per Baron's review. 
Tries to implement a facsimile to http://www.xaprb.com/blog/2011/03/18/how-to-gather-statistics-at-regular-intervals/
For both sampling and rendering.
 2012-01-18 05:19:48 -03:00
Brian Fraser
05fec15473 Fixes as per Baron's review. 2012-01-17 11:40:01 -03:00
Brian Fraser
076c0d70b1 (Whoops. Forgot to commit the changed tests) 2012-01-16 09:48:59 -03:00
Brian Fraser
d01d838b64 Several changes as per Baron & Daniel's mails. 
Most importantly, it replaces --zero-rows with --show-inactive, and
changes the default logic used to decide when to print a device.
 2012-01-16 09:37:53 -03:00
Daniel Nichter
87d12c9802 Don't warn about invalid lines, just debug them. Anchor TS pattern. Unset --sample-time unless --group-by sample. 2012-01-12 14:26:31 -07:00
Daniel Nichter
60e16254d3 Correction to r140: only the test marked in this diff needs to be fixed. 2012-01-12 12:09:01 -07:00
Daniel Nichter
9404ff84ef Rewrite pt-diskstats.t but all tests need to be fixed. Update modules in pt-diskstats, use PTDEBUG, check regex opts. Remove output_fh from Diskstats. Fix DiskstatsMenu header so update-modules can see it. 2012-01-12 12:06:50 -07:00
Daniel Nichter
8d70a272fe Simplify parse_diskstats_line() and _calc_delta_for(). Use UPPERCASE for constants. Don't save unused values in dev stats array. Use actual values from an OptionParser/pt-diskstats. 2012-01-12 10:09:40 -07:00
Brian Fraser
3165b3c0f8 Slew of changes from Daniel's review. 2012-01-12 10:37:49 -03:00
Brian Fraser
6d47e958c7 Change ->filter_zeroed_rows into ->zero_rows. 2012-01-10 16:28:32 -03:00
Brian Fraser
13210d1978 Explicit setter for filename. 2012-01-10 14:16:44 -03:00
Brian Fraser
5ad1bc4fbb Explicit setter for device_regex and column_regex. 2012-01-10 14:14:32 -03:00
Brian Fraser
93279a03da Explicit setter for out_fh. 2012-01-10 14:05:02 -03:00
Brian Fraser
187d921069 Explicit setter for filter_zeroed_rows 2012-01-10 13:46:05 -03:00
Brian Fraser
25909caa4e Explicit setters for (curr|prev|first)_ts. 2012-01-10 13:40:51 -03:00
Brian Fraser
9fd8e8d61d Make a test clean up after itself. 2012-01-10 11:26:11 -03:00
Brian Fraser
b4289010b1 Several fixes. --save-samples and --help should work now. 2012-01-10 10:47:50 -03:00
Brian Fraser
d3ef9edaaa Several corrections as per Daniel and Baron's feedback. 
Still TODO: Attributes still have a single method that doubles
as a getter and setter. The constructor for Diskstats is still
weird -- A tad more stricter than it should be, if anything.
->print_rest is still rest, even though that's hardly
memorable, mostly because of a lack of ideas on what to
rename it. The main loop in the Menu is still a while (1).

As a nice perk, it's nearly twice as fast now! It also adds a
_very_ experimental --memory-for-speed argument, which
turns on memoization for the current biggest bottleneck.
 2011-12-22 19:24:56 -03:00
Brian Fraser
467254aca3 Fixes to the Menu; additionally, changed the accepted format for samples. 
Also made it hide rows that are all zeroes by default, as per the
blueprint.
 2011-12-20 12:53:35 -03:00
Brian Fraser
8da8d1ff61 Diskstats.pm: Wrong math for millisecond to second. 
Sorry about that. Mind bug on my side.
 2011-12-16 13:55:31 -03:00
Brian Fraser
13c9c5b0bb Added the actual pt-diskstats tool. 
Missing a doc overhaul and tests, but this deals with most of the
feature upgrades in the blueprint.

The shell version of pt-diskstats is now in bin has pt-diskstats-shell,
in case that's needed.
 2011-12-16 13:40:22 -03:00
Brian Fraser
7b12dbec64 Work in progress v3: Working interactive mode, initial documentation. 
With this most of the interactive mode should be working.

pt_diskstats.pm has the documentation and can be used for testing,
which should be in the next commit.

This commit also includes the revamped command line options.
 2011-12-15 20:26:55 -03:00
Brian Fraser
0fd09e8f6e Work in progress v2: Redesign pt-diskstats in Perl. 2011-12-13 14:53:05 -03:00
Brian Fraser
43b29d6374 Work in progress: Redesign pt-diskstats in Perl. 
Mostly bits and pieces at the moments. ReadKeyMini is a portable-ish
Term::ReadKey. Used here by DiskstatsMenu, which is currently only
for show.

Diskstats has most of the logic of the old pt-diskstats, with parts
now implemented by the DiskstatsGroupBy* classes; The latter subclass
the former.

As mentioned at the start, this is a work in progress. In addition to to
not having all the parts attached, also missing are the data-gathering mode,
the command-line argument parsing, and a large amount of tests.
 2011-12-08 19:26:04 -03:00
Daniel Nichter
26a42a24d5 Add back --quiet and test pt-trend. 2011-11-14 09:23:47 -07:00
Daniel Nichter
2f9ab4081a Fix prepared report for statements without corresponding prep or exec. 2011-11-08 12:53:50 -07:00
Daniel Nichter
7da33234f5 Fix bug 821717: pt-tcp-model --type=requests crashes. 2011-10-11 08:31:42 -06:00
Daniel Nichter
0f05ca9b94 Fix multi-column index nibbling. Remove extra spaces in generated statements. 2011-09-12 08:14:57 -06:00
Daniel Nichter
3ed822e8e6 Implement dynamic chunk size, set_chunk_size(). 2011-09-12 07:32:19 -06:00
Daniel Nichter
985ee65928 Pass EXPLAIN sths to callbacks. 2011-09-11 11:10:11 -06:00
Daniel Nichter
8ce093655f Add dms arg, remove before_row callback, pass some args to callbacks, get next boundary if no rows (so exec_nibble callback can skip nibbles). 2011-09-11 10:22:40 -06:00
Daniel Nichter
84f7c47ff4 Rename new TableChecksum to RowChecksum and revert TableChecksum to r108. This will avoid completely break TableSync*.pm and pt-table-sync. 2011-09-10 13:46:55 -06:00
Daniel Nichter
968d10ac37 Refactor TableChecksum for NibbleIterator (use only BIT_XOR, return just column list, etc.). 2011-09-10 12:21:00 -06:00
Daniel Nichter
c989bd29dd First working NibbleIterator. 2011-09-09 17:29:28 -06:00
Daniel Nichter
7fde36a65b Create NibbleIterator. Cleanup TableNibbler. Fix bug in SchemaIterator. 2011-09-09 11:50:19 -06:00
Daniel Nichter
1373f69361 Fix OptionParser to parse new version format. 2011-09-01 09:01:34 -06:00
Daniel Nichter
dcceaae66b Fix typo: "TESTS" not "TEST" makes prove happy. 2011-09-01 08:46:50 -06:00
Daniel Nichter
e91aad978f Fix pt-index-usage save_results.t. 2011-08-27 12:47:55 -06:00
Daniel Nichter
d567e3d282 Restart slave1 so subsequent tests don't try to connect to phantom 12347. 2011-08-27 12:27:11 -06:00
Daniel Nichter
b2a982f9ea Update a test result that is now correct. 2011-08-27 12:22:49 -06:00
Daniel Nichter
3c6edf6d71 Update TableChunker in pt-table-checksum. Include COUNT in test samples. 2011-08-27 11:26:00 -06:00
Daniel Nichter
a7ab27bb54 Don't get min/max a 2nd time in _chunk_char(). Use where in _chunk_char(). Test char chunking world_city.name with real range stats. Add failing pt-table-checksum char chunk --where test. 2011-08-27 11:17:28 -06:00
Daniel Nichter
2e0f607589 Pass --where to get_range_statistics(). 2011-08-27 09:23:36 -06:00
Daniel Nichter
64c6ad418e Fix MockSyncStream.t for pre-DBD::mysql 4.001. 2011-08-24 11:37:45 -06:00
Daniel Nichter
fb8f3148f5 The last Daemon.t stabilizer? 2011-08-24 11:26:18 -06:00
Daniel Nichter
a1bee06edf One more stabilizer for Daemon.t. 2011-08-24 11:24:07 -06:00
Daniel Nichter
2c7257caff More stabilizing Daemon.t. 2011-08-24 11:20:27 -06:00
Daniel Nichter
e134aa665b Try to make Daemon.t more reliable. 2011-08-24 11:04:47 -06:00