Commit Graph

235 Commits

Author SHA1 Message Date
Daniel Nichter
02b3574582 Add critical load to MySQLStatusWaiter.pm and pt-osc. Clean up the tool's docu. 2012-03-27 19:17:17 -06:00
Daniel Nichter
45c1f3bfb6 Make NibbleIter query comments customizable. Update the module in pt-table-checksum and pt-osc. 2012-03-25 10:37:19 -06:00
Daniel Nichter
20d2aa7a08 Make NibbleIterator check for options before using them. 2012-03-22 11:28:58 -06:00
Daniel Nichter
a17bdd65d3 Rewriting pt-online-schema-change 2.1.1. Work in progress (this code doesn't work yet). 2012-03-20 13:34:16 -06:00
Daniel Nichter
e122b884e2 Merge lp:~percona-toolkit-dev/percona-toolkit/fix-928226. 2012-03-06 14:18:51 -07:00
Brian Fraser fraserb@gmail.com
a252f5b7f8 Change a _d() introduced in previous commits to possily avoid crashes 2012-03-06 14:04:47 -03:00
Brian Fraser fraserb@gmail.com
06f1b7319e Fix for 928226: https://bugs.launchpad.net/percona-toolkit/+bug/928226 2012-03-02 11:05:33 -08:00
Daniel Nichter
36c666ca11 Merge lp:~percona-toolkit-dev/percona-toolkit/fix-md-bug-926598. 2012-03-02 10:19:57 -08:00
Daniel Nichter
afd0b2a713 Merge lp:~percona-toolkit-dev/percona-toolkit/collect-without-stalking. 2012-03-02 08:16:55 -08:00
Daniel Nichter
6e94c39072 Use Perl instead of awk to avoid 32-bit limitation. 2012-02-24 11:11:07 -07:00
Daniel Nichter
a33031e6e4 Merge 2.0 r187. 2012-02-21 14:26:44 -07:00
Daniel Nichter
8e9e8eb7a6 Test and fix space-flattening bug. 2012-02-21 13:22:56 -07:00
Daniel Nichter
17fe96f361 Test and quote all idents, including reserved words and those with spaces, in CopyRowsInsertSelect.pm. 2012-02-20 11:37:34 -07:00
Daniel Nichter
39fe787fdd Test and quote all idents, including reserved words and those with spaces, in OSCCaptureSync.pm. 2012-02-20 11:09:36 -07:00
Daniel Nichter
cd17a20119 Add and test --[no]stalk to pt-stalk. Fix ps in pt-stalk tests. Add PerconaTest::wait_for_sh(). 2012-02-16 13:32:46 -07:00
Daniel Nichter
815b406a40 Add PTDEVDEBUG statements to PerconaTest::wait_for_table(). 2012-02-14 12:48:24 -07:00
Daniel Nichter
da051b3371 Conditionalize IO::Uncompress::Inflate test. Make test names shorter, uniform. 2012-02-14 11:19:23 -07:00
Daniel Nichter
0539775d24 Always close STDIN if --daemonize. 2012-02-14 10:54:02 -07:00
Daniel Nichter
c67adc1a8f More Daemon debugging. 2012-02-14 10:20:40 -07:00
Daniel Nichter
e9f6325592 Add hires timestamp to PTDEVDEBUG. Debug daemonize.pl. Make wait_until() defaults shorter. 2012-02-14 09:31:47 -07:00
Daniel Nichter
c943f7a0da Debug Daemon.t failures. 2012-02-14 08:58:10 -07:00
Daniel Nichter
298385167e Do not use precision and scale. Use sandbox 12348 instead of 12347. Call pt_upgrade_main() instead of tool via cmd line in basics.t. 2012-02-07 12:39:25 -07:00
Daniel Nichter
df4662ce51 Compare index names lc but save them in their original case. 2012-02-06 13:29:08 -07:00
Daniel Nichter
b3f0f414e4 Merge lp:~percona-toolkit-dev/percona-toolkit/pt-diskstats-2.0. 2012-02-03 15:25:25 -07:00
Daniel Nichter
f517675eb4 Compare lc(index) everywhere. 2012-02-03 11:38:20 -07:00
Daniel Nichter
0ac6c35211 Fix _pidof() calls in collect.sh. Update Bash libs in pt-ioprofile. 2012-02-03 10:49:27 -07:00
Brian Fraser
27323776a8 Applied Baron's patch, which changes how qtime and stime are calculated.
Also includes a second attempt at fixing the $Diskstats::printed_lines bug,
and fixed how the timestamp is chosen if --show-timestamps is in effect.
2012-02-03 14:00:40 -03:00
Brian Fraser
0a25bd038b Merge with Baron's branch, and changes as per the new spec/docs. 2012-02-03 12:11:14 -03:00
Brian Fraser
d11856d48f Moved the calculation of {read,write}_ios_sec around a bit and marked it as TODO 2012-02-02 19:38:03 -03:00
Daniel Nichter
9c6b9ab33d Use printf(%d) to avoid CentOS using floats. 2012-02-02 12:13:00 -07:00
Daniel Nichter
7be99c5140 Add _which() to alt_cmds.sh and update pt-stalk. 2012-02-02 12:04:28 -07:00
Daniel Nichter
c40e5db1bf Fix lib tests for MySQL 5.0. 2012-02-02 10:56:55 -07:00
Daniel Nichter
85fdb732c8 Merge lp:~percona-toolkit-dev/percona-toolkit/pt-stalk-2.0 and, previously merged into that, lp:~percona-toolkit-dev/percona-toolkit/use-mktemp-871438. 2012-02-02 09:38:11 -07:00
Brian Fraser
2f3f75965a Fixed a 'Use of uninitialized value' error in Diskstats->print_deltas()
It's not clear to me how this can even happen, as the variable is
package-scoped and set during compilation, but this should fix it.
2012-02-02 11:14:20 -03:00
Brian Fraser
b0f7bc4fc6 Tweaks requested by Baron, plus fixes.
Tweaks:
* --headers command line option, which can be used to
        enable/disable the automatic headers, and the
        automatic empty lines between samples.
* --show-timestamps, which changes the #ts line with
        a timestamp in the HH:MM:SS format.
* Always use ReadKeyMini, even when we have Term::ReadKey.
        In the latter case, use the Term::ReadKey functions,
        but if they fail, try again with our own versions.

Fix:
Looks like I forgot to actually enable the "save the current, first
and last" samples. This is now on. It should mean faster and better
output when changing --group-by modes.
2012-02-01 19:12:03 -03:00
Daniel Nichter
cd91b583c1 Removed unused global vars. 2012-02-01 10:03:37 -07:00
Brian Fraser
7c4c186978 Change how Diskstats waits for its first handful of samples.
This fixes two bugs -- One a rounding error, one a desyncronization
between the main program and the data gathering daemon.

Additionally, it changes how the daemon prints the very first
sample. Before it would unconditionally wait until the time was
%$sample-time, which meant that in a worst case scenario,
a user could be left waiting for a while before seeing a line
of output.
This commit changes that first wait to only sleep if less
than 20% away from %$sample-time.
2012-02-01 12:14:09 -03:00
Brian Fraser
3de8aa530b More fixes as per Baron's review. 2012-01-31 22:44:00 -03:00
Brian Fraser
1fb316b63e Merge lp:~percona-toolkit-dev/percona-toolkit/fix-897758 2012-01-31 16:16:27 -03:00
Daniel Nichter
df73364e97 Use VALUES instead of VALUE. Update TableChunker in all tools. 2012-01-31 11:07:08 -07:00
Daniel Nichter
6205505263 Don't use basename and quote $dir in tmpdir.sh. 2012-01-31 10:20:37 -07:00
Daniel Nichter
1a619cc47c Test and fix typo in MasterSlave.pm and update that module in all tools. 2012-01-31 09:53:06 -07:00
Brian Fraser
807dbcfe21 Fix for #897758 2012-01-31 13:15:15 -03:00
Brian Fraser
73c1e466d7 Several fixes & changes:
* qtime and stime computed correctly
* Interactive mode and changing groups doesn't fail
* Interactive mode no longer uses a file to gather samples.
2012-01-30 17:44:18 -03:00
Daniel Nichter
be8c0e6e18 Fix parsing opts from config file with leading and trailing space. 2012-01-30 11:15:28 -07:00
Daniel Nichter
89242d9fde Don't init a global with a global. 2012-01-30 10:20:31 -07:00
Daniel Nichter
8389da4c07 Use . instead of source. Quote func file. Verify --function. Add option_error() to parse_options.sh. Update libs in pt-stalk. 2012-01-30 09:22:25 -07:00
Daniel Nichter
d1a684b55b Use _pidof() and _lsof() from Percona Monitoring Plugins. Use "" and "yes" exclusively in collect(). Don't exec cmds that need mysqld_pid unless mysqld_pid is defined. Use log() instead of echo. 2012-01-30 08:59:19 -07:00
Daniel Nichter
e954505dd2 Don't print errors in data files; let the general -output file catch them. Print TS lines before data. Try to find sysctl manually. Add _pidof() to alt_cmds.sh. 2012-01-27 17:37:59 -07:00
Daniel Nichter
81ae556f8b Use local IFS. 2012-01-26 13:04:23 -07:00