Daniel Nichter
6b017da6fe
Use new pretty --help.
2012-01-26 12:59:48 -07:00
Daniel Nichter
05ac0be136
Change --disk-byte-limit to --disk-bytes-free and --disk-pct-limit to --disk-pct-free.
2012-01-26 12:45:44 -07:00
Daniel Nichter
d7d5381863
Make check_disk_space() use bytes (given new size type options with are converted to bytes, 1k=>1024).
2012-01-26 12:19:47 -07:00
Daniel Nichter
81caf6addc
Convert size \d+[KMGT] opts in parse_options.sh.
2012-01-26 10:44:55 -07:00
Daniel Nichter
c2fd3f54c2
Use "yes" for true, "" for false. Use $PO_DIR instead of $TMP_DIR/po. Add and test Baron's code for 'Options and values after processing arguments'. Make --help exit 0 unless there were errors.
2012-01-24 12:49:18 -07:00
Daniel Nichter
42a8e39635
Use better Bash.
2012-01-24 12:28:41 -07:00
Daniel Nichter
36c14f492a
Don't use grep -q.
2012-01-24 12:15:29 -07:00
Daniel Nichter
4905e3503c
Handle --config FILE[,FILE,...] in parse_options.sh.
2012-01-24 11:18:41 -07:00
Daniel Nichter
034f76d77e
Fix handling EXT_ARGV.
2012-01-23 10:53:41 -07:00
Daniel Nichter
0d348ce289
Make parse_options work with everything: cmd line, config files, values with spaces, op val, op=val, etc.
2012-01-23 10:30:42 -07:00
Daniel Nichter
65a3ab5157
Handle values with spaces. Still needs work; one test is failing.
2012-01-21 13:59:02 -07:00
Daniel Nichter
acbc6b4622
Parse config files. Refactor parse_option.sh. Print --help and --version to STDOUT.
2012-01-20 11:34:51 -07:00
Daniel Nichter
88304e69fb
Replace MKDEBUG with PTDEBUG in modules.
2012-01-19 12:46:56 -07:00
Daniel Nichter
51b93a6235
Fix --help description interpolation.
2012-01-19 12:20:33 -07:00
Daniel Nichter
2412e01aa0
Use which to get programs. Don't create file unless the program or file exists.
2012-01-19 10:46:48 -07:00
Brian Fraser
ad552756b2
Automatic headers & improvements.
2012-01-18 19:01:19 -03:00
Brian Fraser
5b43ed0d5e
More changes as per Baron's review.
...
Tries to implement a facsimile to http://www.xaprb.com/blog/2011/03/18/how-to-gather-statistics-at-regular-intervals/
For both sampling and rendering.
2012-01-18 05:19:48 -03:00
Daniel Nichter
6e2b670af6
Die if --log, --pid, or --dest aren't accessible. Also die if po dir isn't accessible.
2012-01-17 13:12:08 -07:00
Daniel Nichter
b2bac5c765
Quote in tmpdir.sh and fix typo in doc.
2012-01-17 12:15:49 -07:00
Brian Fraser
3a66cf5187
Removed lib/pt_diskstats.pm, since it's no longer needed.
2012-01-17 11:41:15 -03:00
Brian Fraser
05fec15473
Fixes as per Baron's review.
2012-01-17 11:40:01 -03:00
Brian Fraser
d01d838b64
Several changes as per Baron & Daniel's mails.
...
Most importantly, it replaces --zero-rows with --show-inactive, and
changes the default logic used to decide when to print a device.
2012-01-16 09:37:53 -03:00
Daniel Nichter
cfce6e6eb2
More quoting and tweaking re Baron's review.
2012-01-13 10:02:17 -07:00
Daniel Nichter
87d12c9802
Don't warn about invalid lines, just debug them. Anchor TS pattern. Unset --sample-time unless --group-by sample.
2012-01-12 14:26:31 -07:00
Daniel Nichter
9404ff84ef
Rewrite pt-diskstats.t but all tests need to be fixed. Update modules in pt-diskstats, use PTDEBUG, check regex opts. Remove output_fh from Diskstats. Fix DiskstatsMenu header so update-modules can see it.
2012-01-12 12:06:50 -07:00
Daniel Nichter
8d70a272fe
Simplify parse_diskstats_line() and _calc_delta_for(). Use UPPERCASE for constants. Don't save unused values in dev stats array. Use actual values from an OptionParser/pt-diskstats.
2012-01-12 10:09:40 -07:00
Brian Fraser
3165b3c0f8
Slew of changes from Daniel's review.
2012-01-12 10:37:49 -03:00
Daniel Nichter
a9afea4506
Quote vals in Bash libs. Add tests for log_warn_die.sh and alt_cmds.sh. Make --help test path independent.
2012-01-11 11:31:41 -07:00
Brian Fraser
6d47e958c7
Change ->filter_zeroed_rows into ->zero_rows.
2012-01-10 16:28:32 -03:00
Brian Fraser
f173069109
Stop using /(?=)/ since /.+/ is good enough.
...
Originally, DiskstatsMenu differentiated between an empty pattern
entered by the user (which in the shell version meant "match all")
and any other valid pattern by replacing it with /(?=)/.
However, Diskstats now carries the original string, inside the
OptionParser object, so the above was redundant.
2012-01-10 16:10:50 -03:00
Brian Fraser
eaae370f81
Removed the handling of the partition format.
...
/proc/diskstats actually has two formats, one for devices, one for
partitions. The latter wasn't handled by the original pt-diskstats,
but one of the previous commits introducing some minimal handling
for that. This commit removes that, since the partition format
doesn't have enough information to be useful.
2012-01-10 14:28:24 -03:00
Brian Fraser
13210d1978
Explicit setter for filename.
2012-01-10 14:16:44 -03:00
Brian Fraser
5ad1bc4fbb
Explicit setter for device_regex and column_regex.
2012-01-10 14:14:32 -03:00
Brian Fraser
93279a03da
Explicit setter for out_fh.
2012-01-10 14:05:02 -03:00
Brian Fraser
ae76c73395
Explicit setter for interactive.
2012-01-10 14:01:11 -03:00
Brian Fraser
79bdf3f1d3
Explicit setter for sample_time
2012-01-10 13:52:43 -03:00
Brian Fraser
187d921069
Explicit setter for filter_zeroed_rows
2012-01-10 13:46:05 -03:00
Brian Fraser
25909caa4e
Explicit setters for (curr|prev|first)_ts.
2012-01-10 13:40:51 -03:00
Brian Fraser
01042d0fda
Use waitpid($pid, WNOHANG) instead of kill(0, $pid).
2012-01-10 11:25:18 -03:00
Brian Fraser
038dfeba59
Useless local pointed out by Daniel.
2012-01-10 10:53:28 -03:00
Brian Fraser
b4289010b1
Several fixes. --save-samples and --help should work now.
2012-01-10 10:47:50 -03:00
Daniel Nichter
cf10e3e521
Merge lp:~percona-toolkit-dev/percona-toolkit/pt-table-checksum-2.0.
2011-12-29 17:39:26 -07:00
Daniel Nichter
c58dfca1b5
Use latest Quoter::(de)serialize_list() in pt-table-checksum and pt-table-sync. Add more char_chunking.t tests for pt-table-checksum.
2011-12-29 17:25:38 -07:00
Brian Fraser
1f06ea093a
Modified (de)serialize_list to handle undefs and empty string elements better.
2011-12-29 17:22:17 -03:00
Brian Fraser
85817a795c
Slight improvement to the deserialize regex and its test output.
2011-12-28 20:08:30 -03:00
Daniel Nichter
4197b09f53
Adjust code spacing, tweak comments, do only (de)serialize tests with database, give tests names.
2011-12-28 15:47:50 -07:00
Brian Fraser
88e82d665d
Include serialize_list() and deserialize_list() to roundtrip through a DB.
2011-12-28 16:44:49 -03:00
Daniel Nichter
09cd535d3a
Merge lp:~daniel-nichter/percona-toolkit/bash-tool-libs.
2011-12-27 15:37:09 -07:00
Daniel Nichter
f122861808
Fix --where with one nibble. Update chunk_index.t.
2011-12-27 11:12:40 -07:00
Daniel Nichter
b63bc4c26b
Convert pt-table-checksum boundaries to SQL WHERE clauses.
2011-12-22 15:43:15 -07:00
