percona/percona-toolkit
1
0
Fork 0
mirror of https://github.com/percona/percona-toolkit.git synced 2025-09-26 23:45:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

Do not use precision and scale. Use sandbox 12348 instead of 12347. Call pt_upgrade_main() instead of tool via cmd line in basics.t.

Browse Source
This commit is contained in:
Daniel Nichter
2012-02-07 12:39:25 -07:00
parent a08afff18b
commit 298385167e
21 changed files with 355 additions and 191 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
lib/MockSyncStream.pm
View File

@@ -97,8 +97,6 @@ sub get_result_set_struct {
my @cols = @{$sth->{NAME}};
my @types = map { $dbh->type_info($_)->{TYPE_NAME} } @{$sth->{TYPE}};
my @nullable = map { $dbh->type_info($_)->{NULLABLE} == 1 ? 1 : 0 } @{$sth->{TYPE}};
my @p = @{$sth->{PRECISION}};
my @s = @{$sth->{SCALE}};
my $struct = {
cols => \@cols,
@@ -114,11 +112,16 @@ sub get_result_set_struct {
$struct->{is_nullable}->{$col} = $nullable[$i];
$struct->{is_numeric}->{$col}
= ($type =~ m/(?:(?:tiny|big|medium|small)?int|float|double|decimal|year)/ ? 1 : 0);
# We no longer specify the (precision, scale) for double, float, and
# decimal because DBD::mysql isn't reliable and defaults should work.
# But char col sizes are important, e.g. varchar(16) and varchar(255)
# won't hold the same values.
# https://bugs.launchpad.net/percona-toolkit/+bug/926598
$struct->{size}->{$col}
= ($type =~ m/(?:float|double)/) ? "($s[$i],$p[$i])"
: ($type =~ m/(?:decimal)/) ? "($p[$i],$s[$i])"
: ($type =~ m/(?:char|varchar)/ && $p[$i]) ? "($p[$i])"
: undef;
= $type =~ m/(?:char|varchar)/ && $sth->{PRECISION}->[$i]
? "($sth->{PRECISION}->[$i])"
: undef;
}
return $struct;