alibaba/p3c
1
0
Fork 0
mirror of https://github.com/alibaba/p3c.git synced 2025-10-14 15:10:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

由于魔法值image可能存在括号斜杠等字符，不输出在提示中

Browse Source
This commit is contained in:
胜燕
2017-11-28 17:51:25 +08:00
parent 41c6c96090
commit fe0a754187
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
p3c-pmd/src/main/java/com/alibaba/p3c/pmd/lang/java/rule/constant/UndefineMagicConstantRule.java
View File

@@ -27,6 +27,8 @@ import net.sourceforge.pmd.lang.java.ast.ASTForStatement;
import net.sourceforge.pmd.lang.java.ast.ASTIfStatement;
import net.sourceforge.pmd.lang.java.ast.ASTLiteral;
import net.sourceforge.pmd.lang.java.ast.ASTWhileStatement;
import net.sourceforge.pmd.util.StringUtil;
import org.jaxen.JaxenException;
/**
@@ -64,9 +66,9 @@ public class UndefineMagicConstantRule extends AbstractAliRule {
for (ASTLiteral literal : literals) {
if (inBlackList(literal) && !currentLiterals.contains(literal)) {
currentLiterals.add(literal);
String imageReplace = StringUtil.replaceString(literal.getImage(), "{", "'{");
addViolationWithMessage(data, literal,
"java.constant.UndefineMagicConstantRule.violation.msg",
new Object[] {literal.getImage()});
"java.constant.UndefineMagicConstantRule.violation.msg", new Object[] {imageReplace});
}
}
}