From fe0a754187616e73bd90f7f045220f7c2ace066d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E8=83=9C=E7=87=95?= Date: Tue, 28 Nov 2017 17:51:25 +0800 Subject: [PATCH] =?UTF-8?q?=E7=94=B1=E4=BA=8E=E9=AD=94=E6=B3=95=E5=80=BCim?= =?UTF-8?q?age=E5=8F=AF=E8=83=BD=E5=AD=98=E5=9C=A8=E6=8B=AC=E5=8F=B7?= =?UTF-8?q?=E6=96=9C=E6=9D=A0=E7=AD=89=E5=AD=97=E7=AC=A6=EF=BC=8C=E4=B8=8D?= =?UTF-8?q?=E8=BE=93=E5=87=BA=E5=9C=A8=E6=8F=90=E7=A4=BA=E4=B8=AD?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../lang/java/rule/constant/UndefineMagicConstantRule.java | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/p3c-pmd/src/main/java/com/alibaba/p3c/pmd/lang/java/rule/constant/UndefineMagicConstantRule.java b/p3c-pmd/src/main/java/com/alibaba/p3c/pmd/lang/java/rule/constant/UndefineMagicConstantRule.java index e253188..781a23e 100644 --- a/p3c-pmd/src/main/java/com/alibaba/p3c/pmd/lang/java/rule/constant/UndefineMagicConstantRule.java +++ b/p3c-pmd/src/main/java/com/alibaba/p3c/pmd/lang/java/rule/constant/UndefineMagicConstantRule.java @@ -27,6 +27,8 @@ import net.sourceforge.pmd.lang.java.ast.ASTForStatement; import net.sourceforge.pmd.lang.java.ast.ASTIfStatement; import net.sourceforge.pmd.lang.java.ast.ASTLiteral; import net.sourceforge.pmd.lang.java.ast.ASTWhileStatement; +import net.sourceforge.pmd.util.StringUtil; + import org.jaxen.JaxenException; /** @@ -64,9 +66,9 @@ public class UndefineMagicConstantRule extends AbstractAliRule { for (ASTLiteral literal : literals) { if (inBlackList(literal) && !currentLiterals.contains(literal)) { currentLiterals.add(literal); + String imageReplace = StringUtil.replaceString(literal.getImage(), "{", "'{"); addViolationWithMessage(data, literal, - "java.constant.UndefineMagicConstantRule.violation.msg", - new Object[] {literal.getImage()}); + "java.constant.UndefineMagicConstantRule.violation.msg", new Object[] {imageReplace}); } } }