Address code review feedback: improve logic and remove redundant code

Co-authored-by: emako <24737061+emako@users.noreply.github.com>
This commit is contained in:
copilot-swe-agent[bot]
2025-12-08 02:21:31 +00:00
parent 9a768b2401
commit d91ef677f2
2 changed files with 13 additions and 16 deletions

View File

@@ -108,30 +108,28 @@ public class Plugin : IViewer
{
context.Title = $"[PROTECTED VIEW] {Path.GetFileName(path)}";
// Check if user has previously chosen to always unblock
var alwaysUnblock = SettingHelper.Get("AlwaysUnblockProtectedView", false, "QuickLook.Plugin.OfficeViewer");
// Check if user has a saved preference
var savedPreference = SettingHelper.Get<bool?>("AlwaysUnblockProtectedView", null, "QuickLook.Plugin.OfficeViewer");
bool shouldUnblock = alwaysUnblock;
bool shouldUnblock;
if (!alwaysUnblock)
if (savedPreference.HasValue)
{
// Use saved preference
shouldUnblock = savedPreference.Value;
}
else
{
// Show dialog to ask user
var dialog = new ProtectedViewDialog();
var dialogResult = dialog.ShowDialog();
if (dialogResult == true)
{
shouldUnblock = true;
shouldUnblock = dialogResult == true;
// Save preference if user checked "Remember my choice"
if (dialog.RememberChoice)
{
SettingHelper.Set("AlwaysUnblockProtectedView", true, "QuickLook.Plugin.OfficeViewer");
}
}
else
// Save preference if user checked "Remember my choice"
if (dialog.RememberChoice)
{
shouldUnblock = false;
SettingHelper.Set("AlwaysUnblockProtectedView", shouldUnblock, "QuickLook.Plugin.OfficeViewer");
}
}

View File

@@ -38,7 +38,6 @@ public partial class ProtectedViewDialog : Window
private void NoButton_Click(object sender, RoutedEventArgs e)
{
UserSelectedYes = false;
DialogResult = false;
Close();
}