windows/QuickLook
1
0
Fork 0
mirror of https://github.com/QL-Win/QuickLook.git synced 2026-01-29 02:06:48 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Refactor GetNearestLrc for clarity and efficiency #1858

Browse Source 
Simplified the logic in GetNearestLrc by using clearer LINQ queries and reducing redundant operations. The method now directly finds the latest timestamp not greater than the specified time, merges duplicate timestamps if necessary, and returns the appropriate LrcLine.
This commit is contained in:
ema
2026-01-14 13:58:56 +08:00
parent 860da5a014
commit 5ed701343f
1 changed files with 14 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
QuickLook.Plugin/QuickLook.Plugin.VideoViewer/LyricTrack/LrcHelper.cs
View File

@@ -123,28 +123,24 @@ public static class LrcHelper
/// <returns>The nearest <see cref="LrcLine"/> at or before the specified time, or <c>null</c> if none found.</returns>
public static LrcLine GetNearestLrc(IEnumerable<LrcLine> lrcList, TimeSpan time, string separator = "\n")
{
IEnumerable<LrcLine> lines = lrcList
.Where(x => x.LrcTime != null && x.LrcTime <= time)
.OrderByDescending(x => x.LrcTime);
// Use LINQ to filter valid candidates
List<LrcLine> candidates = [.. lrcList.Where(x => x.LrcTime != null && x.LrcTime <= time)];
LrcLine first = lines.FirstOrDefault();
if (!candidates.Any())
return null;
if (first is not null)
{
LrcLine[] mergingLines = [.. lines.Where(x => x.LrcTime == first.LrcTime)];
// Find the latest timestamp not greater than the specified time
TimeSpan? nearestTime = candidates.Max(x => x.LrcTime);
// If any duplicate timestamps exist, merge them
if (mergingLines.Length > 1)
{
// Create a new LrcLine can keep original ones unchanged
return new LrcLine(
first.LrcTime,
string.Join(separator, lines.Where(x => x.LrcTime == first.LrcTime).Select(x => x.LrcText))
);
}
}
// Get all lines with the latest timestamp (could be multiple if there are duplicate timestamps)
LrcLine[] nearestLines = [.. candidates.Where(x => x.LrcTime == nearestTime)];
return first;
// If only one line matches, return the original object
if (nearestLines.Length == 1)
return nearestLines.First();
// Otherwise, merge texts and create a new LrcLine to keep original ones unchanged
return new LrcLine(nearestTime, string.Join(separator, nearestLines.Select(x => x.LrcText)));
}
/// <summary>