Updated Changelog

PT-7 fix 3.4.0 build

Changelog

@@ -1,28 +1,28 @@
 Changelog for Percona Toolkit
 
-v3.4.0
+v3.4.0 release 2022-07-11
 
+ * New Tool    PT-1978: Add reporting on unused/redundant indexes for MongoDB by pt-mongodb-summary
+ * Improvement PT-1417: Inconsistent creation of toolkit tables
+ * Improvement PT-1800: The environment variable PTDEBUG=1 exposes the passwords
+ * Improvement PT-1940:	ptsoc dropswap method that was rejected for Mysql 8 has been fixed with Mysql 8.0.14
+ * Improvement PT-1979: Add gathering of admin parameters for MongoDB by pt-mongodb-summary
+ * Improvement PT-2037: Add option --skip-mysql or --system-only for pt-stalk
  * Fixed bug   PT-1218: pt-stalk ominous open_tables function
  * Fixed bug   PT-1336: pt-stalk removes user's files from the destination directory
  * Fixed bug   PT-1398: pt-stalk gets the incorrect mysqld pid when the host installed a multi MySQL instance
- * Improvement PT-1417: Inconsistent creation of toolkit tables
  * Fixed bug   PT-1627:	pt-mysql-summary doesn't verify which version of jemalloc is in use
  * Fixed bug   PT-1747: pt-online-schema-change: metadata lock can break database for rebuild_constraints
- * Improvement PT-1800: The environment variable PTDEBUG=1 exposes the passwords
- * Improvement PT-1887: pt-diskstat is not working for new kernels
+ * Fixed bug   PT-1887: pt-diskstat is not working for new kernels
  * Fixed bug   PT-1900: At times, pt-query-digest does not hide the parameters properly when parameter=binary
- * Improvement PT-1940:	ptsoc dropswap method that was rejected for Mysql 8 has been fixed with Mysql 8.0.14
  * Fixed bug   PT-1953: pt-summary typo: Memory mamagement.
  * Fixed bug   PT-1959: go part of the toolkit still has the version 3.3.0
  * Fixed bug   PT-1965: pt-stalk --mysql-only doesn't collect mysqladmin output (Thanks Sergey Kuzmichev)
  * Fixed bug   PT-1966: Test no_drop_no_swap for the pt-online-schema-change is broken (Thanks Tsubasa Tanaka)
  * Fixed bug   PT-1974: Support fingerprinting for --print in pt-kill
- * New Tool    PT-1978: Add reporting on unused/redundant indexes for MongoDB by pt-mongodb-summary
- * Improvement PT-1979: Add gathering of admin parameters for MongoDB by pt-mongodb-summary
  * Fixed bug   PT-1983:	pt-summary missing one DIMM	
  * Fixed bug   PT-2016: pt-table-checksum fails to build replace query when table lacks primary key
  * Fixed bug   PT-2023: pt-upgrade Error: Wide character in print
- * Improvement PT-2037: Add option --skip-mysql or --system-only for pt-stalk
 
 v3.3.1 release 2021-04-28 
 

Makefile.PL

@@ -9,9 +9,9 @@ WriteMakefile(
       map {
          (my $name = $_) =~ s/^bin.//;
          my $file_name = $_;
-         if ( $file_name !~ m/mongo/ ) {
+         if ( ( $file_name !~ m/mongo/ ) || ( $file_name !~ m/pg/ ) ) {
              $_ => "blib/man1/$name.1p";
-        }
+         }
       } <bin/*>
     },
     MAN3PODS     => {}, # man(3) pages are for C libs

src/go/Makefile

@@ -1,7 +1,13 @@
+.PHONY: all style format build test vet tarball linux-amd64 clean help
+
 help:                 ## Display this help message.
 	@echo "Please use \`make <target>\` where <target> is one of:"
 	@grep '^[a-zA-Z]' $(MAKEFILE_LIST) | \
 		awk -F ':.*?## ' 'NF==2 {printf "  %-26s%s\n", $$1, $$2}'
+	@echo
+	@echo 'To build binaries use: VERSION=m.n.p make <target>'
+	@echo 'Example: VERSION=3.4.0 make linux-amd64'
+	@echo 'The binaries generation uses pwd command to set the base directory. Please run make from the same directory where the Makefile is located.'
 
 DATE_FMT = +%FT%T%z
 ifdef SOURCE_DATE_EPOCH
@@ -12,17 +18,19 @@ endif
 
 GO := go
 pkgs = $(shell find . -type d -name "pt-*" -exec basename {} \;)
-VERSION=$(shell git describe --abbrev=0 --tags)
 BUILD=$(BUILD_DATE)
 GOVERSION=$(shell go version | cut --delimiter=" " -f3)
-COMMIT=$(shell git rev-list -1 HEAD)
 GOUTILSDIR ?= $(GOPATH)/bin
 FILES = $(shell find . -type f -name '*.go' -not -path "./vendor/*")
-
 PREFIX=$(shell pwd)
-TOP_DIR=$(shell git rev-parse --show-toplevel)
-BIN_DIR=$(shell git rev-parse --show-toplevel)/bin
-SRC_DIR=$(shell git rev-parse --show-toplevel)/src/go
+
+CUR_DIR=$(shell pwd)
+COMMIT=$(shell git rev-list -1 HEAD)
+
+TOP_DIR=${CUR_DIR}
+BIN_DIR=${CUR_DIR}/../../bin
+SRC_DIR=${CUR_DIR}/../../src/go
+
 LDFLAGS="-X main.Version=${VERSION} -X main.Build=${BUILD} -X main.GoVersion=${GOVERSION} -X main.Commit=${COMMIT} -s -w"
 
 TEST_PSMDB_VERSION?=4.0
@@ -65,7 +73,6 @@ MINIO_SECRET_ACCESS_KEY=secret00000
 export MINIO_ACCESS_KEY_ID
 export MINIO_SECRET_ACCESS_KEY
 
-.PHONY: all style format build test vet tarball linux-amd64
 
 $(GOUTILSDIR)/dep:
 	go get -u github.com/golang/dep/cmd/dep
@@ -116,20 +123,20 @@ env-down: env				## Clean-up MongoDB docker containers cluster
 	docker-compose down -v
 	rm .env
 
-linux-amd64: 				## Build Mongo tools for linux-amd64
-	@echo "Building linux/amd64 binaries in ${BIN_DIR}"
+linux-amd64: 				## Build Mongo tools for linux-amd64.
+	@echo "Building linux/amd64 binaries in ${BIN_DIR} as version ${VERSION}"
 	@cd ${TOP_DIR} && go get ./...
 	@$(foreach pkg,$(pkgs),rm -f ${BIN_DIR}/$(pkg) 2> /dev/null;)
 	@$(foreach pkg,$(pkgs),GOOS=linux GOARCH=amd64 go build -ldflags ${LDFLAGS} -o ${BIN_DIR}/$(pkg) ./$(pkg);)
 
 linux-386: 					## Build Mongo tools for linux-386
-	@echo "Building linux/386 binaries in ${BIN_DIR}"
+	@echo "Building linux/386 binaries in ${BIN_DIR} as version ${VERSION}"
 	@cd ${TOP_DIR} && go get ./...
 	@$(foreach pkg,$(pkgs),rm -f ${BIN_DIR}/$(pkg) 2> /dev/null;)
 	@$(foreach pkg,$(pkgs),GOOS=linux GOARCH=386 go build -ldflags ${LDFLAGS} -o ${BIN_DIR}/$(pkg) ./$(pkg);)
 
 darwin-amd64:				## Build Mongo tools for darwin-amd64 (MacOS) 
-	@echo "Building darwin/amd64 binaries in ${BIN_DIR}"
+	@echo "Building darwin/amd64 binaries in ${BIN_DIR} as version ${VERSION}"
 	@cd ${TOP_DIR} && go get ./...
 	@$(foreach pkg,$(pkgs),rm -f ${BIN_DIR}/$(pkg) 2> /dev/null;)
 	@$(foreach pkg,$(pkgs),GOOS=darwin GOARCH=amd64 go build -ldflags ${LDFLAGS} -o ${BIN_DIR}/$(pkg) ./$(pkg);)