Daniel Nichter
959c2ecf48
Simplify handling old/new cols by making @common_cols have {old=>col,new=>col} mappings. Manually merge bug 1062324 fix. Fix err/warn messages.
2012-11-07 10:26:57 -07:00
Daniel Nichter
530b8bbceb
Rename _find_renamed_cols() to find_renamed_cols() and add unit tests in find_renamed_cols.t. Tweak dry-run and error message re --check-alter.
2012-11-07 09:30:23 -07:00
Brian Fraser
c711c57859
Test for 933465: pt-query-advisor false positive on RES.001
2012-11-07 09:51:35 -03:00
Brian Fraser
bb47e4cdcc
Removed the L option from the dsn_opts exported by PerconaTest, as it was useless and breaking tests, and added an L=1 to a leftover pt-archiver --bulk-insert call
2012-11-07 08:54:39 -03:00
Brian Fraser
470c4b9d41
Add some extra safety to t/lib/Percona/Toolkit.t in case we are not ebing run under a bzr directory
2012-11-07 04:42:04 -03:00
Brian Fraser
02a21749b0
Added t/lib/Percona/Toolkit.t
2012-11-07 04:35:43 -03:00
Brian Fraser
58b32bb5ef
Merged fix-1073532-Mo-Scalar-Util-PP
2012-11-07 04:12:37 -03:00
Brian Fraser
aa79c9df57
Moved the PXC-dealing parts of Cxn.pm into Percona::XtraDB::Cluster
2012-11-07 04:06:50 -03:00
Daniel Nichter
e8cfb37341
Move ptc PXC tests from bugs.t to pxc.t. Remove 2>&1 from Sandbox.pm shell-outs: we should let errors go to stderr so we can trap them. Fix skip count in Cxn.t for PXC tests.
2012-11-06 16:10:01 -07:00
Brian Fraser
74cd9233c3
Tweaked the report format, which now includes the number of INSERTs
2012-11-06 14:22:56 -03:00
Brian Fraser
d3c7a059e7
Fixes per Daniel's review
2012-11-06 11:35:49 -03:00
Daniel Nichter
ddda26fb7f
Merged fix-i26211-1058285-821722-implicit-ansi_quotes
2012-11-05 10:57:11 -07:00
Daniel Nichter
a0cd575c95
Merge fix-1009510-1039569-ptc-check-table-on-replicas
2012-11-05 10:54:21 -07:00
Daniel Nichter
0cffac95de
Simplify how ptc checks slave tables. Move that code from TableParser to pt_table_checksum::check_slave_tables. Change --[no]check-replicate-table-columns to --[no]check-slave-tables. Move tests to error_handling.t.
2012-11-02 15:22:47 -06:00
Brian Fraser
5fd150de31
Extra tweaks due to feedback from kaiwangchen: ; starts comments if at the start of a line
2012-11-02 01:58:12 -03:00
Brian Fraser
6720831fd1
Merged fix-1059732-ptc-hash-functions
2012-11-02 01:23:59 -03:00
Brian Fraser
1aa154d6c6
Fix for 996069: Incorrect RES.001 when using aggregate functions
2012-11-02 01:18:10 -03:00
Brian Fraser
227dfa6ea7
Fix for 1015590: pt-mysql-summary not Percona Server 5.5-ready
2012-11-02 00:21:48 -03:00
Brian Fraser
062f76ae33
Added a test for the second bug in customer issue 26211
2012-11-01 17:28:06 -03:00
Brian Fraser
78da81fea5
Fixed a typo and added some regression tests
2012-11-01 17:04:00 -03:00
Daniel Nichter
7d64ca2113
Test that SQL_MODE isn't changed.
2012-11-01 11:46:54 -06:00
Daniel Nichter
949cf31037
Set sql_mode='' before SHOW CREATE TABLE--don't bother with replacing certain values. Move and rewrite tests to ansi_quotes.t.
2012-11-01 11:31:31 -06:00
Brian Fraser
a5a23665fe
Simplified split_grants() and added a test for mixed table & column grants on the same table
2012-11-01 06:15:54 -03:00
Brian Fraser
4b5c8969f0
Fix for 937234: pt-query-advisor issues wrong RES.001
2012-11-01 05:33:35 -03:00
Daniel Nichter
0fd9239500
Implement split_grants() instead of split(',', $grants) to handle spliting grants with column-level privs.
2012-10-31 14:20:43 -06:00
Daniel Nichter
0453d7dd82
Failing test case.
2012-10-31 13:16:25 -06:00
Daniel Nichter
9b6f10480c
Merge fix-938660-ptc-chunk-size-limit-0
2012-10-31 12:20:54 -06:00
Daniel Nichter
b5c48f07d1
Remove unused $limit. Make $chunk_size_limit || 1 because it's the one used for #-of-rows check on slaves. Reverse the new test because we don't want to disable the #-of-rows check.
2012-10-31 12:12:51 -06:00
Brian Fraser fraserb@gmail.com
e6158cd2f8
Fix for 1073532: Mo doesn't work with Scalar::Util::PP
...
Unlike Scalar::Util, Scalar::Util::PP::looks_like_number shifts @_,
so calling it as &looks_like_number works differently in both
versions; see https://rt.cpan.org/Public/Bug/Display.html?id=80525
2012-10-31 12:04:30 -03:00
Brian Fraser
517ec595e9
Add missing log file
2012-10-31 06:51:49 -03:00
Brian Fraser
dce8db5be1
Fix for 823431: pt-query-advisor hangs on big queries
...
This was caused by a regex backtracking itself to a halt. The solution
was to add a positive lookahead that searches for the floating but mandatory
substrings that the regex needs; if those exist, then eventually it will
match, but if they don't, it'll fail quickly.
2012-10-31 06:48:54 -03:00
Brian Fraser
8f3f022ab4
Regression test for 957442.
2012-10-31 06:21:18 -03:00
Brian Fraser
572ee45185
Merged fix-1052722-pt-fifo-split-n-minus-1-rows-initially
2012-10-30 22:14:11 -03:00
Brian Fraser
b9bfe6114c
Merged fix-821715-enable-local-infile-in-dsn
2012-10-30 22:12:57 -03:00
Brian Fraser
cb3fb74082
Fix for 1045317: Added a --statistics option to pt-osc
2012-10-30 21:45:52 -03:00
Daniel Nichter
376572e637
Merge fix-995896-cat-in-daemon
2012-10-30 17:04:22 -06:00
Daniel Nichter
c8b31431b0
Handle slurp_file error specifically. Fix Daemon.t test plans.
2012-10-30 16:57:06 -06:00
Brian Fraser
ad4d69b3e2
Removed local $EVAL_ERROR, added a test using t/lib/samples/broken_tbl.frm, and updated all modules
2012-10-30 19:02:03 -03:00
Brian Fraser
35f5f8d1e4
Fix for 1047335: SchemaIterator fails when it encounters a crashed table
2012-10-30 18:35:49 -03:00
Brian Fraser
d5a3a6e59c
Update per Daniel's comments & some minor fixes
2012-10-30 15:15:38 -03:00
Brian Fraser fraserb@gmail.com
6e3d3e6c96
Removed optional_value, made --version-check have default: off, updated the tools and documentation with the changes, and added the auto value to Pingback.pm
2012-10-30 12:42:42 -03:00
Brian Fraser fraserb@gmail.com
19f55542a2
Fix for 1059732: pt-table-checksum doesn't test all hash functions
2012-10-30 12:38:31 -03:00
Brian Fraser fraserb@gmail.com
1e3cc6131c
Fix for 938660: pt-table-checksum chunk-size-limit of 0 does not disable chunk size limit checking
2012-10-30 11:55:49 -03:00
Brian Fraser fraserb@gmail.com
fcf5fbcc6f
Fix for 1068562: pt-online-schema-change loses data when renaming columns
2012-10-30 11:50:13 -03:00
Daniel Nichter
3d03a3a0dc
Don't run binlog_tests unless MySQL 5.1+. Use output() instead of full_output().
2012-10-26 16:52:24 -06:00
Daniel Nichter
7cc7d7e729
Make pt-archiver --sleep tests more precise and reliable.
2012-10-25 16:21:43 -06:00
Daniel Nichter
7b5e2fc7a2
Don't use literal values for t/pt-heartbeat/basics.t 'It is being updated' test. Use direct call rather than backticks.
2012-10-25 15:57:22 -06:00
Daniel Nichter
5b4b3886b2
Fix t/pt-slave-delay/auto_restart.t and use direct call, no backticks.
2012-10-25 15:36:24 -06:00
Daniel Nichter
e69f1f24d0
Remove $Sandbox::Percona::Toolkit::VERSION and use $Percona::Toolkit::VERSION instead since it's the authoritative version.
2012-10-24 13:52:10 -06:00
Daniel Nichter
33f75e069d
Fix some test plans.
2012-10-24 13:36:32 -06:00
