percona/percona-toolkit
1
0
Fork 0
mirror of https://github.com/percona/percona-toolkit.git synced 2025-09-22 11:54:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix for 1068562: pt-online-schema-change loses data when renaming columns

Browse Source
This commit is contained in:
Brian Fraser fraserb@gmail.com
2012-10-30 11:50:13 -03:00
parent b8f6db2045
commit fcf5fbcc6f
2 changed files with 163 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

84
t/pt-online-schema-change/bugs.t
View File

@@ -206,6 +206,19 @@ $sb->load_file('master', "$sample/data-loss-bug-1068562.sql");
qw(--execute)) },
);
like(
$output,
qr/--no-check-alter to disable this error/,
"--check-alter works"
);
($output, $exit_status) = full_output(
sub { pt_online_schema_change::main(@args,
"$master_dsn,D=bug1068562,t=simon",
"--alter", "change old_column_name new_column_name varchar(255) NULL",
qw(--execute --no-check-alter)) },
);
my $rows = $master_dbh->selectall_arrayref("SELECT * FROM bug1068562.simon ORDER BY id");
is_deeply(
$rows,
@@ -213,6 +226,77 @@ is_deeply(
"Bug 1068562: no data lost"
) or diag(Dumper($rows));
# Now try with sakila.city.
my $orig = $master_dbh->selectall_arrayref(q{SELECT city FROM sakila.city});
($output, $exit_status) = full_output(
sub { pt_online_schema_change::main(@args,
"$master_dsn,D=sakila,t=city",
"--alter", "change column `city` `some_cities` varchar(50) NOT NULL",
qw(--execute --alter-foreign-keys-method auto --no-check-alter)) },
);
ok(
!$exit_status,
"Bug 1068562: Renamed column correctly"
);
my $mod = $master_dbh->selectall_arrayref(q{SELECT some_cities FROM sakila.city});
is_deeply(
$orig,
$mod,
"Bug 1068562: No columns went missing"
);
($output, $exit_status) = full_output(
sub { pt_online_schema_change::main(@args,
"$master_dsn,D=sakila,t=city",
"--alter", "change column `some_cities` city varchar(50) NOT NULL",
qw(--execute --alter-foreign-keys-method auto --no-check-alter)) },
);
my $mod2 = $master_dbh->selectall_arrayref(q{SELECT city FROM sakila.city});
is_deeply(
$orig,
$mod2,
"Bug 1068562: No columns went missing after a second rename"
);
$orig = $master_dbh->selectall_arrayref(q{SELECT first_name, last_name FROM sakila.staff});
($output, $exit_status) = full_output(
sub { pt_online_schema_change::main(@args,
"$master_dsn,D=sakila,t=staff",
"--alter", "change column first_name first_name_mod varchar(45) NOT NULL, change column last_name last_name_mod varchar(45) NOT NULL",
qw(--execute --alter-foreign-keys-method auto --no-check-alter)) },
);
$mod = $master_dbh->selectall_arrayref(q{SELECT first_name_mod, last_name_mod FROM sakila.staff});
is_deeply(
$orig,
$mod,
"Bug 1068562: No columns went missing with a double rename"
);
($output, $exit_status) = full_output(
sub { pt_online_schema_change::main(@args,
"$master_dsn,D=sakila,t=staff",
"--alter", "change column first_name_mod first_name varchar(45) NOT NULL, change column last_name_mod last_name varchar(45) NOT NULL",
qw(--execute --alter-foreign-keys-method auto --no-check-alter)) },
);
$mod2 = $master_dbh->selectall_arrayref(q{SELECT first_name, last_name FROM sakila.staff});
is_deeply(
$orig,
$mod2,
"Bug 1068562: No columns went missing when renaming the columns back"
);
# #############################################################################
# Done.
# #############################################################################