Brian Fraser fraserb@gmail.com
a25b9eab40
MasterSlave: Rework how the recursion methods are checked & resolved
...
In part by removing the OptionParser usage out from get_slaves
and recurse_to_slaves and making them expect arrayrefs, thus
forcing our callers to deal with that, and in part by
splitting out the method-checking to MasterSlave::check_recursion_method
and the resolving (originally in find_slave_hosts) into
_resolve_recursion_methods.
2012-08-01 17:39:12 -03:00
Brian Fraser
192f38498c
Removed the charset munging and made a note in the pt-archiver docs that the only legal charsets are those known by MySQL
2012-07-27 16:09:32 -03:00
Brian Fraser
61a65fcdbd
DSNParser.pm: Work around MySQL not resolving encodings sanely.
...
For some reason, MySQL won't resolve iso-8859-1 or latin-1 as latin1,
and will die if you try to use through in, e.g., SET NAMES.
This commit makes DSNParser resolve those cases on its own
before calling SET NAMES.
2012-07-23 01:11:49 -03:00
Brian Fraser
02c6421a25
Cxn.pm: Set NAME_lc by default
2012-07-22 23:37:39 -03:00
Brian Fraser
5d8be022e9
Merge ubuntu-12-64-issues
2012-07-20 17:33:13 -03:00
Brian Fraser
bfa5f488fa
Merged new-versionparser
2012-07-20 17:25:10 -03:00
Daniel Nichter
785de0cf57
Merge pt-kill-log-dsn.
2012-07-19 11:20:29 -06:00
Brian Fraser
dfc271929c
Style consistency: Use numeric operators (<, ==, etc) for version checks
2012-07-19 13:20:45 -03:00
Brian Fraser
64c14e18f4
Remove MySQL 4.0 checks from several libraries, losing the VP dependency
2012-07-19 13:19:26 -03:00
Brian Fraser
de625a873c
VersionParser.pm: Code comments
2012-07-19 12:12:28 -03:00
Brian Fraser
02665e802e
VersionParser.pm: Quote SQL with q//
2012-07-19 12:08:28 -03:00
Daniel Nichter
e797e463c1
Use hostN intead of full hostname in Compare* summaries.
2012-07-17 16:47:33 -06:00
Daniel Nichter
28f50bbac5
Use host instead of Host.
2012-07-17 09:53:07 -06:00
Daniel Nichter
b2fb12853f
Add # HostN: <full hostname> to UpgradeReportFormatter header and use HostN in column instead.
2012-07-17 09:49:13 -06:00
Brian Fraser fraserb@gmail.com
d826c7168b
Merged fix-984915-unchecked-do-calls-dsnparser
2012-07-14 23:58:17 -03:00
Brian Fraser fraserb@gmail.com
27db3bc8cf
Update the code to work on current trunk.
...
Changes for 941469 conflicted with this fix, so this had to be updated.
2012-07-14 23:31:05 -03:00
Brian Fraser
b696a2e44b
bzr update'd the code for assorted VersionParser fixes
2012-07-13 01:55:56 -03:00
Brian Fraser
01f64ad724
Make VersionParser temporarily set NAME_lc if using a dbh
2012-07-13 01:52:59 -03:00
Brian Fraser
30cc4892cf
bzr update'd the code for assorted VersionParser fixes
2012-07-13 01:39:40 -03:00
Brian Fraser
1d00866669
MasterSlave: Drop dependency on VersionParser
2012-07-13 01:16:04 -03:00
Brian Fraser
36d825edb1
Some changes as per Daniel's review
2012-07-13 00:42:49 -03:00
Brian Fraser
ccccafd4df
Test VP->flavor and fix some udnerlaying buys
2012-07-12 23:37:53 -03:00
Brian Fraser
c5555234c1
VersionParser::normalized_version: Don't use _version_split, use the values from methods instead
2012-07-12 23:15:01 -03:00
Brian Fraser
f558b4b9da
Fix 984915: DSNParser does not check return value of do() calls
2012-07-12 22:42:54 -03:00
Daniel Nichter
dab2e5c692
Add NAME_lc arg to Cxn to prevent it from being set. Use Cxn in pt-kill to retry lost connections. Add support for pt-kill DSN.
2012-07-12 13:52:52 -06:00
Brian Fraser
4266e92692
Silence tput and stty warnings in ReadKeyMini
2012-07-12 16:25:39 -03:00
Daniel Nichter
d8b0192495
Don't crash if group by attrib is empty string.
2012-07-11 15:46:58 -06:00
Brian Fraser
9ae940cd76
PerconaTest: Add load_data_is_disabled and correct full_output
...
load_data_is_disabled checks if LOAD DATA LOCAL INFILE is disabled;
it'll be used in the future by a couple of tests.
full_output was changed to use two different filehandles for STDOUT
and STDERR; THis is because otherwise, code closing STDOUT (like
the --quiet option in pt-osc) would also accidentally close STDERR.
2012-07-11 17:29:04 -03:00
Brian Fraser
f30c50be44
Updated the fles in /lib to use the new VersionParser
2012-07-11 15:10:33 -03:00
Brian Fraser
acd5281e3c
Redesigned VersionParser.
...
Now using Mo and overloading, so that $version_object < 5.1
is the new way to test things.
2012-07-11 15:05:00 -03:00
Brian Fraser
bcc618ba5b
Fixup: A mistakenly moved BEGIN { was breaking things
2012-07-11 15:04:50 -03:00
Brian Fraser
c012159989
Make Mo add itself to %INC
2012-07-11 12:25:54 -03:00
Brian Fraser
1a217a1eec
Add Mo to lib/
2012-07-11 12:24:29 -03:00
Daniel Nichter
7813aeef55
eval tput which fails if TERM isn't set, like when ran via Jenkins.
2012-07-09 15:59:00 -06:00
Brian Fraser fraserb@gmail.com
c87235b0ff
Fix 984915: DSNParser does not check return value of do() calls
2012-06-11 22:02:49 -03:00
Daniel Nichter
18073bd7a2
Remove --[no]zero-bool from pt-query-digest.
2012-06-11 20:43:05 -04:00
Brian Fraser fraserb@gmail.com
bc8f5a610c
Change TMPDIR to PT_TMPDIR
2012-06-11 17:51:43 -03:00
Daniel Nichter
bf2a769536
Export TMPDIR to make tmpdir.t pass.
2012-06-11 13:28:14 -07:00
Brian Fraser fraserb@gmail.com
07081d5761
tmpdir.sh: Use the -t flag for mktemp
2012-06-11 17:07:38 -03:00
Daniel Nichter
12f98d771e
Merge detect-key-len-with-range-scan.
2012-06-11 13:04:54 -04:00
Daniel Nichter
3f2295ec46
Implement IndexLength in pt-table-checksum and pt-online-schema-change. Tag the IndexLength queries with "key_len" and make n_index_cols optional--get full key_len if not given.
2012-06-11 12:54:26 -04:00
Daniel Nichter
fa9cf03505
Add IndexLength.pm.
2012-06-11 11:47:03 -04:00
Brian Fraser fraserb@gmail.com
87f32cc857
Sandbox.pm: Catch errors from shelled-out commands
2012-06-11 11:50:52 -03:00
Daniel Nichter
583bc2957e
Don't crash if N is > number of index columns.
2012-06-11 07:55:23 -04:00
Daniel Nichter
970f7d7e64
Merge ~percona-toolkit-dev/percona-toolkit/explain-checksum-chunks.
2012-06-10 13:25:44 -04:00
Daniel Nichter
272f963733
Remove --chunk-index-columns and extend --chunk-index instead to take INDEX:N value. Add n_index_values to TableNibbler.
2012-06-10 10:01:25 -04:00
Daniel Nichter
2a92a0a0ff
Check key_len for each chunk to ensure it doesn't decrease. Add --[no]check-plan.
2012-06-09 22:23:00 -04:00
Baron Schwartz
47fb3d65e8
Fix a bazillion tests with ANSI sql_mode, and get rid of a bunch of MySQLDump usage.
2012-06-09 14:43:33 -04:00
Baron Schwartz
8e9dfeec68
Some fixes for ANSI SQL quotes
2012-06-07 14:53:47 -04:00
Baron Schwartz
f7c97e749e
Make TableParser.pm handle ANSI quotes
2012-06-07 00:59:59 -04:00
