percona/percona-toolkit
1
0
Fork 0
mirror of https://github.com/percona/percona-toolkit.git synced 2025-09-28 08:51:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

Style consistency: Use numeric operators (<, ==, etc) for version checks

Browse Source
This commit is contained in:
Brian Fraser
2012-07-19 13:20:45 -03:00
parent 64c14e18f4
commit dfc271929c
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
lib/VariableAdvisorRules.pm
View File

@@ -539,10 +539,10 @@ sub get_rules {
my ( %args ) = @_;
my $mysql_version = $args{mysql_version};
return 0 unless $mysql_version;
return 1 if ($mysql_version eq '3' && $mysql_version lt '3.23')
|| ($mysql_version eq '4' && $mysql_version lt '4.1.20')
|| ($mysql_version eq '5.0' && $mysql_version lt '5.0.37')
|| ($mysql_version eq '5.1' && $mysql_version lt '5.1.30');
return 1 if ($mysql_version == '3' && $mysql_version < '3.23' )
|| ($mysql_version == '4' && $mysql_version < '4.1.20')
|| ($mysql_version == '5.0' && $mysql_version < '5.0.37')
|| ($mysql_version == '5.1' && $mysql_version < '5.1.30');
return 0;
},
},
@@ -552,7 +552,7 @@ sub get_rules {
my ( %args ) = @_;
my $mysql_version = $args{mysql_version};
return 0 unless $mysql_version;
return $mysql_version lt '5.1' ? 1 : 0; # 5.1.x
return $mysql_version < '5.1' ? 1 : 0; # 5.1.x
},
},
};