Commit Graph

55 Commits

Author SHA1 Message Date
Sveta Smirnova
841ddb2edc PT-2327 - pt-mysql-summary fails to connect if password has a single quote character
- Implemented the fix
- Added test case
- Run update-modules
2024-04-11 14:38:28 +03:00
Sveta Smirnova
e9fab37367 PT-2275 - "System Summary" graph breaks when perl is not available (OS summary dashboard)
- Added check for Perl binary in lib/bash/parse_options.sh
- Updated tools
- Updated t/lib/bash/parse_options.sh, so it includes required package alt_cmds.sh
2024-03-18 14:27:11 +03:00
Viktor Szépe
f2f7a7993d Add final newlines and remove trailing spaces (#672)
* Add final newlines and remove trailing spaces

* Replace TAB characters with spaces

* Fix indent
2023-09-15 17:31:40 +03:00
Viktor Szépe
2bd40d8c39 Remove trailing spaces (#665)
* Remove trailing spaces

* PR-665 -  Remove trailing spaces

- Updated not stable test t/pt-online-schema-change/preserve_triggers.t
- Updated utilities in bin directory

* PR-665 -  Remove trailing spaces

- Fixed typos

* PR-665 -  Remove trailing spaces

- Fixed typos

---------

Co-authored-by: Sveta Smirnova <sveta.smirnova@percona.com>
2023-09-06 01:15:12 +03:00
Viktor Szépe
c57441be8c War on typos Act 1 (#655)
* Fix typos in lib/ directory

* Update generated bin/ files

* PR 655 -  War on typos Act 1 #655

- Updated modules in tools that were not updated
- Fixed tests to reflect proposed changes

---------

Co-authored-by: Sveta Smirnova <sveta.smirnova@percona.com>
2023-08-22 16:18:38 +03:00
Sveta Smirnova
9755074cd8 PT-2156 Fix tests for lib, part2 (#650)
* PT-2156 - Fix tests for lib

Fixed tests, broken by putting fix for PT-1554 into the library code, mostly by updating checksums.
Added AutoCommit option for test lib/QueryReview.t
Reset SQL mode to empty to allow TableChunker to work with invalid and zero dates

* PT-2156 - Fix tests for lib

Adjusted t/lib/SchemaIterator.t to work with version 8.0

* PT-2156 - Fix tests for lib

Adjusted b/t/lib/Processlist.t, so it reflects fix for PT-981

* PT-2156 - Fix tests for lib

Adjusted t/lib/HTTP/Micro.t, so it works with different order of parameters, returned at v.percona.com/
Adjusted test for empty files in t/lib/bash/collect.t
Disabled mysqladmin debug test in t/lib/bash/collect.t, because of PT-2242

* PT-2156 - Fix tests for lib

Added LC_NUMERRIC=POSIX into t/lib/bash/report_system_info.sh, so reports in tests are not environment-dependent
Updated expected results in t/lib/bash/report_system_info.sh, so they reflect new information, collected by pt-summary

* PT-2156 - Fix tests for lib

- Improved fix for PT-76, so it handles inline comments
- Added test case for PT-76
- Improved fix for PT-1720, so it ignores unrecognizable option only if it comes from the toolkit-wide files and still errors out if wrong option was passed via command line or the tool-specific option file.

* PT-2156 - Fix tests for lib

- Improved fix for PT-2102, so it finds running instance configuration file using PID and also does not break t/lib/bash/report_mysql_info.t test
- Removed unnecessary copy-paste from t/pt-mysql-summary/pt-2102.t test
- Adjusted number of collected files in t/lib/bash/collect_mysql_info.sh

* PT-2156 - Fix tests for lib

- Fix for PT-1543 and MyRocks collection were originally put only into lib/bash/report_mysql_info.shthat broke the logic of collecting data first, then formatting report from this data. This, in its turn, broke test t/lib/bash/report_mysql_info.sh/t/lib/bash/report_mysql_info.t, because CMD_MYSQL is not defined in this library. I rewrote these fixes, so they follow original logic of the tool (pt-mysql-summary)
- Added tests for keyring plugin, encrypted tables, and MyRocks for t/lib/bash/report_mysql_info.sh and t/pt-mysql-summary/pt-mysql-summary_encryption.t

* PT-2156 - Fix tests for lib

- Added FLUSH TABLES to t/lib/bash/collect.sh, so it does not fail opentables tests if run when more than 1000 tables open in the sandbox environment
- Changed number of expected sample files to reflect keyring colletion file

* PT-2156 - Fix tests for lib

- Added skip to some tests in lib that file when run with PXC, because not supported to work with PXC
- Adjusted configuration files for PXC, so they allow LOAD DATA/SELECT INTO OUTFILE commands
- Adjusted data samples, so they do not depend on auto increment values
- Fixed lib tests, failing with PXC

* PT-2156 - Fix tests for lib

Updated tests for pt-online-schema-change, so they work with PXC and skipped if designed for semi-synchronous replication setup

* PT-2156 - Fix tests for lib

- Added cluster-specific samples for t/lib/SchemaIterator.t
- Removed extra debugging print from t/pt-table-checksum/pt-1728.t

* PT-2156 - Fix tests for lib

Evgeniy's review on July 20

* Update t/lib/TableSyncer.t

Removed comment left after debugging

* Update t/pt-mysql-summary/pt-mysql-summary_encryption.t

Removed extra debug output

* PT-2156 - Fix tests for lib

Tabs to spaces
2023-08-02 14:50:21 +03:00
Carlos Salguero
54bee8399a PT-1720 pmp won't error on unknown options 2019-06-27 10:32:23 -03:00
Carlos Salguero
43a58c4c64 PT-76 Fixed cmd line parsing for lines having # 2017-02-25 13:52:46 -03:00
Frank Cizmich
f8c8411297 simplified conditional for testing if HOME is set 2015-01-19 14:58:47 -02:00
Frank Cizmich
18f85786ba added test. removed space 2015-01-14 14:36:44 -02:00
Frank Cizmich
a7e1975eea parse_options checks if HOME is set 2015-01-13 17:36:26 -02:00
Frank Cizmich
dc4c506483 many scripts failed when reading no-version-check from global config file - 1361293 2014-10-06 19:04:49 -02:00
Frank Cizmich
cde3e26140 fixed pt-mest --version
fixed version parsing in parse_options.sh , was incompatible with dash shell script
2014-07-10 17:15:13 -03:00
Daniel Nichter
a6dc5a91ec Read opts file in perl instead of 'cat file | perl' to avoid occasional 'cat: write error: Broken pipe'. 2013-08-09 21:21:55 +00:00
Brian Fraser
9e2ce2197f pt-ms & pt-stalk: Enable the standard mysql options 2013-02-25 11:21:46 -03:00
Brian Fraser fraserb@gmail.com
84043cee75 parse_options.sh: Make sure that --help works under sh 2012-11-27 18:05:53 -03:00
Brian Fraser
289035a303 Merged fix-1038995-bash-options-starting-with-no 2012-08-28 22:05:33 -03:00
Brian Fraser
d53fadff74 Merged quote-tr-arguments 2012-08-24 20:02:48 -03:00
Brian Fraser fraserb@gmail.com
c2b006eeaf Fix for 1038995: pt-stalk notify-by-email fails 2012-08-20 19:22:31 -03:00
Daniel Nichter
3602bb252f Use non-Bashism indirect reference in parse_options. Change $@ to ${@:-} and update parse_options in all tools. 2012-08-14 11:46:47 -06:00
Daniel Nichter
9ddf90eeca Use ${@:-""} rather than $@, prevents error on ksh when no opts given. Remove set +u to see if it is no longer needed. 2012-08-14 11:07:10 -06:00
Brian Fraser fraserb@gmail.com
7f9f84a6d0 shell tools: Quote the arguments to tr 2012-08-13 12:23:18 -03:00
Daniel Nichter
487d14228b Handle --nofoo like --no-foo in parse_options.sh and update the Bash tools. 2012-07-21 11:57:53 -06:00
Daniel Nichter
e1b39b3d5f Use TRUE/FALSE for typeless option values in --help. Update parse_options.sh lib in Bash tools. 2012-07-21 11:40:39 -06:00
Brian Fraser fraserb@gmail.com
bc8f5a610c Change TMPDIR to PT_TMPDIR 2012-06-11 17:51:43 -03:00
Daniel Nichter
be8c0e6e18 Fix parsing opts from config file with leading and trailing space. 2012-01-30 11:15:28 -07:00
Daniel Nichter
89242d9fde Don't init a global with a global. 2012-01-30 10:20:31 -07:00
Daniel Nichter
8389da4c07 Use . instead of source. Quote func file. Verify --function. Add option_error() to parse_options.sh. Update libs in pt-stalk. 2012-01-30 09:22:25 -07:00
Daniel Nichter
81ae556f8b Use local IFS. 2012-01-26 13:04:23 -07:00
Daniel Nichter
6b017da6fe Use new pretty --help. 2012-01-26 12:59:48 -07:00
Daniel Nichter
81caf6addc Convert size \d+[KMGT] opts in parse_options.sh. 2012-01-26 10:44:55 -07:00
Daniel Nichter
c2fd3f54c2 Use "yes" for true, "" for false. Use $PO_DIR instead of $TMP_DIR/po. Add and test Baron's code for 'Options and values after processing arguments'. Make --help exit 0 unless there were errors. 2012-01-24 12:49:18 -07:00
Daniel Nichter
42a8e39635 Use better Bash. 2012-01-24 12:28:41 -07:00
Daniel Nichter
36c14f492a Don't use grep -q. 2012-01-24 12:15:29 -07:00
Daniel Nichter
4905e3503c Handle --config FILE[,FILE,...] in parse_options.sh. 2012-01-24 11:18:41 -07:00
Daniel Nichter
034f76d77e Fix handling EXT_ARGV. 2012-01-23 10:53:41 -07:00
Daniel Nichter
0d348ce289 Make parse_options work with everything: cmd line, config files, values with spaces, op val, op=val, etc. 2012-01-23 10:30:42 -07:00
Daniel Nichter
65a3ab5157 Handle values with spaces. Still needs work; one test is failing. 2012-01-21 13:59:02 -07:00
Daniel Nichter
acbc6b4622 Parse config files. Refactor parse_option.sh. Print --help and --version to STDOUT. 2012-01-20 11:34:51 -07:00
Daniel Nichter
51b93a6235 Fix --help description interpolation. 2012-01-19 12:20:33 -07:00
Daniel Nichter
6e2b670af6 Die if --log, --pid, or --dest aren't accessible. Also die if po dir isn't accessible. 2012-01-17 13:12:08 -07:00
Daniel Nichter
a9afea4506 Quote vals in Bash libs. Add tests for log_warn_die.sh and alt_cmds.sh. Make --help test path independent. 2012-01-11 11:31:41 -07:00
Daniel Nichter
0056014339 Let desc sentence be terminated by period of question mark. 2011-12-19 12:55:14 -07:00
Daniel Nichter
9baea8b7b6 Convert parse_option to sh, use Perl instead of awk, implement --help. 2011-12-19 12:51:47 -07:00
Daniel Nichter
3266e0aeca Don't use OPT_TMPDIR in tmpdir.sh. Define EXT_ARGV in parse_options.sh. 2011-12-19 11:29:21 -07:00
Daniel Nichter
a172a3f2a7 Return 0 only if no --help, --verion, or opt errors. 2011-12-15 12:12:18 -07:00
Daniel Nichter
f3ac1b20c2 Add usage_or_errors() to parse_options.sh. 2011-12-15 12:01:22 -07:00
Daniel Nichter
876e3533d0 Use LC_ALL=C to fix broken awk on some systems. 2011-12-07 11:58:33 -07:00
Daniel Nichter
f6306c9ec0 Test collect.sh. Use --run-time instead of --interval for collect loop. Fix and require per-test test names in util/test-bash-functions. Fix OPT_ERR in parse_options.sh. 2011-12-06 13:23:47 -07:00
Daniel Nichter
6764f4cd06 Close awk fhs to avoid 'too many open files' error. 2011-12-02 14:43:43 -07:00