Commit Graph

5051 Commits

Author SHA1 Message Date
Sveta Smirnova
cadf35abc4 PT-2083 - Pt-archiver --charset option is not working for MySQL8.0
- Changed logic, introduced by commit 1d1c13f
- Added test case
2023-12-22 23:11:31 +03:00
Sveta Smirnova
9b347dd466 Revert "PT-2083 - Pt-archiver --charset option is not working for MySQL8.0"
This reverts commit 284a1f945e.
2023-12-22 23:11:31 +03:00
Sveta Smirnova
1682aa202c PT-2083 - Pt-archiver --charset option is not working for MySQL8.0
- Changed logic, introduced by commit 1d1c13fbcb
- Added test case
2023-12-22 23:11:31 +03:00
Artem Gavrilov
7c9b8590d0 Merge pull request #725 from percona/dependabot/go_modules/golang.org/x/crypto-0.16.0
Bump golang.org/x/crypto from 0.15.0 to 0.16.0
2023-12-22 23:11:31 +03:00
Artem Gavrilov
c614c447e1 Merge pull request #726 from percona/dependabot/go_modules/github.com/rs/zerolog-1.31.0
Bump github.com/rs/zerolog from 1.30.0 to 1.31.0
2023-12-22 23:11:31 +03:00
dependabot[bot]
b6fb163417 Bump golang.org/x/crypto from 0.15.0 to 0.16.0
Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.15.0 to 0.16.0.
- [Commits](https://github.com/golang/crypto/compare/v0.15.0...v0.16.0)

---
updated-dependencies:
- dependency-name: golang.org/x/crypto
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-12-22 23:11:31 +03:00
Artem Gavrilov
224462e78d Merge pull request #727 from percona/dependabot/go_modules/github.com/google/go-cmp-0.6.0
Bump github.com/google/go-cmp from 0.5.9 to 0.6.0
2023-12-22 23:11:31 +03:00
dependabot[bot]
cf1e0a7ce6 Bump github.com/rs/zerolog from 1.30.0 to 1.31.0
Bumps [github.com/rs/zerolog](https://github.com/rs/zerolog) from 1.30.0 to 1.31.0.
- [Release notes](https://github.com/rs/zerolog/releases)
- [Commits](https://github.com/rs/zerolog/compare/v1.30.0...v1.31.0)

---
updated-dependencies:
- dependency-name: github.com/rs/zerolog
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-12-22 23:11:31 +03:00
Sveta Smirnova
57886d5665 Merge pull request #721 from oblitorum/PT-2277_impossible_on_condition
PT-2277 - fix pt-visual-explain for 'Impossible ON condition' case
2023-12-22 23:11:31 +03:00
Sveta Smirnova
a4cf465087 Merge pull request #706 from percona/Follow_PR-429_unstop_option_with_testcase
Follow PR-429 unstop option with testcase
2023-12-22 23:11:31 +03:00
dependabot[bot]
b075224544 Bump github.com/google/go-cmp from 0.5.9 to 0.6.0
Bumps [github.com/google/go-cmp](https://github.com/google/go-cmp) from 0.5.9 to 0.6.0.
- [Release notes](https://github.com/google/go-cmp/releases)
- [Commits](https://github.com/google/go-cmp/compare/v0.5.9...v0.6.0)

---
updated-dependencies:
- dependency-name: github.com/google/go-cmp
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-12-22 23:11:29 +03:00
Sveta Smirnova
5a2df41f90 Merge pull request #669 from ylacancellera/galera-log-explainer
Add pt-galera-log-explainer
2023-12-22 23:11:14 +03:00
Sveta Smirnova
4475641582 PR-669 - Add pt-galera-log-explainer
- Exceptions for identifiers and Galera library errors in .typos.toml
2023-12-22 23:11:13 +03:00
Sveta Smirnova
659bfded74 PR-669 - Add pt-galera-log-explainer
- Added exception for Go tests into .typos.toml
2023-12-22 23:11:13 +03:00
Sveta Smirnova
65ecf4158b PR-669 - Add pt-galera-log-explainer
- Added exception into .typos.toml for src/go/pt-galera-log-explainer/tests/
2023-12-22 23:11:13 +03:00
Sveta Smirnova
da9a8d3e17 PR-669 - Add pt-galera-log-explainer
- Added exception for IST into .typos.toml
2023-12-22 23:11:13 +03:00
Sveta Smirnova
99885fdbd5 Merge branch '3.x' into galera-log-explainer 2023-12-22 23:11:12 +03:00
Sveta Smirnova
060a5d7988 PR-669 - Add pt-galera-log-explainer
- Sync README.rst and docs/pt-galera-log-explainer.rst
2023-12-22 23:10:34 +03:00
Yoann La Cancellera
fd95589c96 preallocate lastcontexts map 2023-12-22 23:10:34 +03:00
Yoann La Cancellera
90ae30517a Move: chan closing in "main" func 2023-12-22 23:10:34 +03:00
Yoann La Cancellera
955fd75ca9 Rename ctx to logCtx, remove any mention of ctx 2023-12-22 23:10:34 +03:00
Yoann La Cancellera
bb6c5e1abd Fix: missed errors, minor formatting issues 2023-12-22 23:10:34 +03:00
Yoann La Cancellera
2a97f061db Imp: use strings.builder for conflicts 2023-12-22 23:10:34 +03:00
Yoann La Cancellera
d6d4d30283 Add: parallel on 2 unit tests 2023-12-22 23:10:34 +03:00
Yoann La Cancellera
aac8896e2f Update src/go/pt-galera-log-explainer/README.rst
Co-authored-by: Sveta Smirnova <svetasmirnova@users.noreply.github.com>
2023-12-22 23:10:34 +03:00
Yoann La Cancellera
98b7a7d52a Fix: README with -vvv, --grep-args, regex-list 2023-12-22 23:10:34 +03:00
Yoann La Cancellera
5d93fbbcc0 PR-669 - Add pt-galera-log-explainer percona#669
- Commented out whois command in README.rst
- Copied README.rst into docs directory, so user manual will include
  this tool
2023-12-22 23:10:34 +03:00
Yoann La Cancellera
27654e9853 Remove: --grep-args
Can be used to break the tool, and I actually never had an use-case
2023-12-22 23:10:34 +03:00
Yoann La Cancellera
3fae43123e Fix: typos 2023-12-22 23:10:34 +03:00
Yoann La Cancellera
7876a0511c Remove old comments, dead code 2023-12-22 23:10:34 +03:00
Yoann La Cancellera
ad91b7d407 Add: translate tests 2023-12-22 23:10:34 +03:00
Yoann La Cancellera
78aebd272d Commenting out whois+sed, will be re-added later 2023-12-22 23:10:34 +03:00
Yoann La Cancellera
2091c1a1f0 Refactoring: migrate translations to singleton
It was using maps in each context, which would be merged between
contexts, then injected each time we needed a message to display.

It had a limitation on complicated operator setups: historical
information would be overriden by newer associations.
(e.g, that IP was for node0 yesterday, now it's node1, so associations
have been overwritten and incorrect)

It also introduced complexity, such as forcing to define closures too
many times, merging maps, it would be harder to debug, and every files
were starting from empty translation maps.
Moreover, iterating on maps is guaranteed to be random so it could create
hard-to-debug output variations on complex cases.

Now it is a singleton in translate package, still using maps but now it
associates an array of "units" storing the timestamp with each piece of information.
It is protected by rwmutex, because map are not threadsafe. (there's no
parallel processing for now)

No regressions, and it passes "operator_ambiguous_ips_list_all_no_color"
where the old system failed.
It nows also can be used as an easy to read source of information in
itself
2023-12-22 23:10:32 +03:00
Yoann La Cancellera
e56fc45a05 Add: inconsistent vote regex corner-case 2023-12-22 23:10:08 +03:00
Yoann La Cancellera
246f875ed9 Add: shortuuid check, new date layout found 2023-12-22 23:10:08 +03:00
Yoann La Cancellera
a3f3a4d7e5 Add: same ip/name limitation on README.rst 2023-12-22 23:10:08 +03:00
Yoann La Cancellera
72fbe7496c Add: operator member assocations regex
It existed for non-operator setup, but was not working for operators due
to k8s logs not interpreting newlines and tabs
This operator version re-uses existing regular regex handlers directly
2023-12-22 23:10:08 +03:00
Yoann La Cancellera
4c8fe1d832 Improve: main_test
It must test multiple times to remove doubts.
As the tool is reading files and relying on maps, their access order are
random. It can impact some translations
2023-12-22 23:10:08 +03:00
Yoann La Cancellera
bd8f1ff5a4 Remove: propagation of ip propagation to older hash, Add: operator regression test
When adding "ownip", it was also propagating the new IP to the old hash.
But with operators, when IP where changing hash will also change, so
linking the new IP to old hash is anachronic. It is not wrong, but
depending on the order of map merges, the newest information could have
been overriden depending on the order of events.

That situation was producing X(2*number of conflicts) versions of output for operators, with
different md5sum, which could produce false-positive regression tests

So currently some information are not linked anymore, so some IPs are
not translated even though they could, but it is a limitation of using
maps as source of truth, as they are not versioned
2023-12-22 23:10:03 +03:00
Sveta Smirnova
ae67adbe92 Merge pull request #717 from percona/PT-2281_provide_container_name_for_copying_files_in_the_dump
PT-2281 - provide container name for copying files in the dump
2023-11-30 19:44:26 +03:00
Sveta Smirnova
10b70206fb Merge branch '3.x' into PT-2281_provide_container_name_for_copying_files_in_the_dump 2023-11-30 19:37:36 +03:00
Sveta Smirnova
5b55513485 Merge pull request #724 from surbhat1595/update3.x
Fix Trivy Scan Failure - update libraries
2023-11-30 19:35:22 +03:00
Surabhi Bhat
375b67ddf3 Fix Trivy Scan Failure - update libraries 2023-11-30 17:10:55 +05:30
Artem Gavrilov
9272c9028c Merge pull request #713 from szepeviktor/patch-1
Fix MongoDB StorageEngine
2023-11-29 18:25:12 +02:00
Artem Gavrilov
ebb940f1af Merge pull request #714 from szepeviktor/patch-2
Fix MongoDB Security
2023-11-29 18:24:03 +02:00
Sveta Smirnova
fe12a19e04 Merge pull request #720 from samiahlroos/3.x
build Go tools from top Makefile
2023-11-29 14:29:28 +03:00
Sveta Smirnova
43ae487f40 PT-2281 - provide container name for copying files in the dump
- Implemented error handling when container name is not specified
- Added test case for error handling
2023-11-29 05:06:27 +03:00
Jason
b2b6311723 PT-2277 - fix pt-visual-explain for 'Impossible ON condition' case 2023-11-29 02:30:44 +08:00
Sami Ahlroos
5e1dfaf218 build Go tools from top Makefile 2023-11-28 14:29:58 +02:00
Sveta Smirnova
0d10bc96b8 Merge pull request #719 from percona/Make_OrderedBy_not_exported_fix
Make OrderedBy not exported
2023-11-23 22:15:34 +03:00