Commit Graph

300 Commits

Author SHA1 Message Date
Brian Fraser
1fb316b63e Merge lp:~percona-toolkit-dev/percona-toolkit/fix-897758 2012-01-31 16:16:27 -03:00
Daniel Nichter
024906eceb Test bug 819450. 2012-01-31 11:40:24 -07:00
Daniel Nichter
1a619cc47c Test and fix typo in MasterSlave.pm and update that module in all tools. 2012-01-31 09:53:06 -07:00
Brian Fraser
807dbcfe21 Fix for #897758 2012-01-31 13:15:15 -03:00
Brian Fraser
73c1e466d7 Several fixes & changes:
* qtime and stime computed correctly
* Interactive mode and changing groups doesn't fail
* Interactive mode no longer uses a file to gather samples.
2012-01-30 17:44:18 -03:00
Daniel Nichter
be8c0e6e18 Fix parsing opts from config file with leading and trailing space. 2012-01-30 11:15:28 -07:00
Daniel Nichter
caa91f39fa Log collector PID. 2012-01-30 10:05:35 -07:00
Daniel Nichter
e954505dd2 Don't print errors in data files; let the general -output file catch them. Print TS lines before data. Try to find sysctl manually. Add _pidof() to alt_cmds.sh. 2012-01-27 17:37:59 -07:00
Daniel Nichter
6b017da6fe Use new pretty --help. 2012-01-26 12:59:48 -07:00
Daniel Nichter
05ac0be136 Change --disk-byte-limit to --disk-bytes-free and --disk-pct-limit to --disk-pct-free. 2012-01-26 12:45:44 -07:00
Daniel Nichter
d7d5381863 Make check_disk_space() use bytes (given new size type options with are converted to bytes, 1k=>1024). 2012-01-26 12:19:47 -07:00
Daniel Nichter
81caf6addc Convert size \d+[KMGT] opts in parse_options.sh. 2012-01-26 10:44:55 -07:00
Daniel Nichter
dd44a9b851 Add --test-matching to replace testing via STDIN/ARGV. 2012-01-25 11:37:10 -07:00
Daniel Nichter
b47679cf97 Implement --[no]collect. 2012-01-24 13:20:07 -07:00
Daniel Nichter
c2fd3f54c2 Use "yes" for true, "" for false. Use $PO_DIR instead of $TMP_DIR/po. Add and test Baron's code for 'Options and values after processing arguments'. Make --help exit 0 unless there were errors. 2012-01-24 12:49:18 -07:00
Daniel Nichter
fa6a6cb8ff Merge lp:~percona-toolkit-dev/percona-toolkit/pt-stalk-2.0-docs r155. 2012-01-24 12:01:47 -07:00
Daniel Nichter
3c97ae27d1 Add and test --config to pt-stalk. 2012-01-24 11:50:48 -07:00
Daniel Nichter
4905e3503c Handle --config FILE[,FILE,...] in parse_options.sh. 2012-01-24 11:18:41 -07:00
Daniel Nichter
0f1687608d Ignore SIGCHLD to avoid zombies. 2012-01-24 09:55:18 -07:00
Daniel Nichter
034f76d77e Fix handling EXT_ARGV. 2012-01-23 10:53:41 -07:00
Daniel Nichter
0d348ce289 Make parse_options work with everything: cmd line, config files, values with spaces, op val, op=val, etc. 2012-01-23 10:30:42 -07:00
Daniel Nichter
65a3ab5157 Handle values with spaces. Still needs work; one test is failing. 2012-01-21 13:59:02 -07:00
Daniel Nichter
acbc6b4622 Parse config files. Refactor parse_option.sh. Print --help and --version to STDOUT. 2012-01-20 11:34:51 -07:00
Daniel Nichter
51b93a6235 Fix --help description interpolation. 2012-01-19 12:20:33 -07:00
Daniel Nichter
ba4b4f3059 Log how pt-stalk was ran. Update modules in tool. Tweak 'Starting' and 'Exiting' log lines. 2012-01-19 11:51:24 -07:00
Daniel Nichter
9e29cc205a Make test quiet. 2012-01-19 11:13:01 -07:00
Daniel Nichter
2412e01aa0 Use which to get programs. Don't create file unless the program or file exists. 2012-01-19 10:46:48 -07:00
Brian Fraser
ad552756b2 Automatic headers & improvements. 2012-01-18 19:01:19 -03:00
Brian Fraser
5b43ed0d5e More changes as per Baron's review.
Tries to implement a facsimile to http://www.xaprb.com/blog/2011/03/18/how-to-gather-statistics-at-regular-intervals/
For both sampling and rendering.
2012-01-18 05:19:48 -03:00
Daniel Nichter
6e2b670af6 Die if --log, --pid, or --dest aren't accessible. Also die if po dir isn't accessible. 2012-01-17 13:12:08 -07:00
Brian Fraser
05fec15473 Fixes as per Baron's review. 2012-01-17 11:40:01 -03:00
Brian Fraser
076c0d70b1 (Whoops. Forgot to commit the changed tests) 2012-01-16 09:48:59 -03:00
Brian Fraser
d01d838b64 Several changes as per Baron & Daniel's mails.
Most importantly, it replaces --zero-rows with --show-inactive, and
changes the default logic used to decide when to print a device.
2012-01-16 09:37:53 -03:00
Daniel Nichter
cfce6e6eb2 More quoting and tweaking re Baron's review. 2012-01-13 10:02:17 -07:00
Daniel Nichter
87d12c9802 Don't warn about invalid lines, just debug them. Anchor TS pattern. Unset --sample-time unless --group-by sample. 2012-01-12 14:26:31 -07:00
Daniel Nichter
60e16254d3 Correction to r140: only the test marked in this diff needs to be fixed. 2012-01-12 12:09:01 -07:00
Daniel Nichter
9404ff84ef Rewrite pt-diskstats.t but all tests need to be fixed. Update modules in pt-diskstats, use PTDEBUG, check regex opts. Remove output_fh from Diskstats. Fix DiskstatsMenu header so update-modules can see it. 2012-01-12 12:06:50 -07:00
Daniel Nichter
8d70a272fe Simplify parse_diskstats_line() and _calc_delta_for(). Use UPPERCASE for constants. Don't save unused values in dev stats array. Use actual values from an OptionParser/pt-diskstats. 2012-01-12 10:09:40 -07:00
Brian Fraser
3165b3c0f8 Slew of changes from Daniel's review. 2012-01-12 10:37:49 -03:00
Daniel Nichter
a9afea4506 Quote vals in Bash libs. Add tests for log_warn_die.sh and alt_cmds.sh. Make --help test path independent. 2012-01-11 11:31:41 -07:00
Brian Fraser
6d47e958c7 Change ->filter_zeroed_rows into ->zero_rows. 2012-01-10 16:28:32 -03:00
Brian Fraser
13210d1978 Explicit setter for filename. 2012-01-10 14:16:44 -03:00
Brian Fraser
5ad1bc4fbb Explicit setter for device_regex and column_regex. 2012-01-10 14:14:32 -03:00
Brian Fraser
93279a03da Explicit setter for out_fh. 2012-01-10 14:05:02 -03:00
Brian Fraser
187d921069 Explicit setter for filter_zeroed_rows 2012-01-10 13:46:05 -03:00
Brian Fraser
25909caa4e Explicit setters for (curr|prev|first)_ts. 2012-01-10 13:40:51 -03:00
Brian Fraser
9fd8e8d61d Make a test clean up after itself. 2012-01-10 11:26:11 -03:00
Brian Fraser
b4289010b1 Several fixes. --save-samples and --help should work now. 2012-01-10 10:47:50 -03:00
Daniel Nichter
a85dffd511 Test for bug 821709. 2012-01-09 11:10:35 -07:00
Daniel Nichter
520948c14e Update sample files. 2012-01-05 11:54:27 -07:00