Commit Graph

2612 Commits

Author SHA1 Message Date
nilnandan
6588510632 PT-1718 - Have pt-stalk collect performance_schema.threads along with information_schema.processlist
- Update collect.sh file and add code for collecting threads details.
- Add PT-1718-threads.t test file for testing this fix.
2025-07-30 14:11:43 +00:00
Sveta Smirnova
7a8fee3d86 Merge pull request #974 from marek-knappe/PT-2457-pt-online-schema-change-add-drop-tablespace-Option
fix(pt-online-schema-change): correct --remove-data-dir default behav…
2025-07-23 13:11:59 +03:00
Sveta Smirnova
8f068a9d59 PT-2418 - pt-online-schema-change 3.7.0 lost data when exe alter xxx rename column xxx
- Added clean up to the test
- Added test for enabled option --check-alter
- Removed extra spaces
2025-07-21 16:45:10 +03:00
Marek Knappe
4a9a4bb903 PT-2418: Fix column data loss during RENAME COLUMN operations
The pt-online-schema-change tool was not properly handling RENAME COLUMN
syntax (MySQL 8.0+), causing renamed columns to be excluded from the
data copy operation. This resulted in NULL values for renamed columns
after the schema change.

The issue was in the find_renamed_cols() function which only supported
CHANGE COLUMN syntax but not RENAME COLUMN syntax. Added support for
RENAME COLUMN parsing to properly detect column renames and include
them in the common_cols list for data copying.

Fixes: PT-2418
2025-07-02 12:45:00 +10:00
Marek Knappe
6c9ed6ed5b Changed optionparser to allow for default: no to be false and run update-modules #PT-2457 2025-06-25 10:58:43 +10:00
Marek Knappe
d0d046122b fix(pt-online-schema-change): correct --remove-data-dir default behavior (#PT-2458)
- Fixed issue where --remove-data-dir incorrectly defaulted to true

feat(pt-online-schema-change): add support for TABLESPACE removal (#PT-2457)
- Implemented detection and removal of TABLESPACE clause during schema changes
2025-06-24 17:09:55 +10:00
Sveta Smirnova
d5d39a83fa Merge pull request #890 from dbnski/long-variable-values
pt-config-diff: MySQL truncates run-time variable values longer than 1024 characters
2025-06-22 15:53:09 +03:00
Sveta Smirnova
b3bf684f39 Merge pull request #947 from percona/PT-2129_pt-online-schem-change_fails_on_non-readable_version_check_file
PT-2129 - pt-online-schem-change and other tools fail on non-readable…
2025-06-13 02:09:35 +03:00
Sveta Smirnova
528007e2b0 Merge pull request #953 from pakud/patch-2
Update documentation of pt-query-digest - better description for --output secure-slowlog
2025-06-12 17:37:25 +03:00
Sveta Smirnova
46f5a2d220 Merge pull request #945 from percona/PT-2424_Typo_in_pt-table-checksum_error_message_--resume_and_--no-empty-replicate-table_are_mutually_exclusive
PT-2424 - Typo in pt-table-checksum error message "--resume and --no-…
2025-06-12 17:29:25 +03:00
Maciej Dobrzanski
55f2167ed0 - Updated MySQLConfig.pm to correctly support very long variable values
- Added test cases for pt-config-diff
2025-06-06 20:39:24 +02:00
Paweł Kudzia
d2db8f5789 Update pt-query-digest
pt-query-digest - fixing documentation for --output secure-slowlog option
2025-04-17 14:11:01 +02:00
Sveta Smirnova
ef2dbd887f PT-2129 - pt-online-schem-change and other tools fail on non-readable version check file
- Implemented fix in lib/VersionCheck.pm
- Updated modules in all tools
- Added test case to t/pt-query-digest/version_check.t
2025-03-29 23:22:44 +03:00
Sveta Smirnova
ebacadf098 Revert "PT-2424 - Typo in pt-table-checksum error message "--resume and --no-empty-replicate-table are mutually exclusive""
This reverts commit e964e17f21.
2025-03-27 21:40:32 +03:00
Sveta Smirnova
c49c58db2b Merge pull request #941 from percona/PT-2355_pt-online-schema-change_should_not_resume_a_job_with_empty_boundaries
PT-2355 - pt-online-schema-change should not resume a job with empty …
2025-03-27 21:13:43 +03:00
Sveta Smirnova
9711db87a7 Merge pull request #944 from percona/PT-2407_pt-online-schema-change_exit_stauts_return_code_is_0_even_if_it_does_NOT_succeed
PT-2407 - pt-online-schema-change exit status(return code) is 0 even …
2025-03-27 21:13:27 +03:00
Sveta Smirnova
905490bac5 PT-2424 - Typo in pt-table-checksum error message "--resume and --no-empty-replicate-table are mutually exclusive"
- Fixed typo
- Added test case
2025-03-27 21:11:31 +03:00
Sveta Smirnova
e964e17f21 PT-2424 - Typo in pt-table-checksum error message "--resume and --no-empty-replicate-table are mutually exclusive"
- Fixed typo
- Added test case
2025-03-27 21:09:10 +03:00
Sveta Smirnova
c3a201d5f8 Update bin/pt-online-schema-change 2025-03-26 18:37:42 +03:00
Sveta Smirnova
2474b1f45b Update bin/pt-online-schema-change 2025-03-26 18:35:41 +03:00
Sveta Smirnova
88367c1dea PT-2407 - pt-online-schema-change exit status(return code) is 0 even if it does NOT succeed
- Changed die call for the case when ALTER TABLE fails for the new table
- Removed stalled comment from Frank
- Added test case
2025-03-26 17:51:35 +03:00
Sveta Smirnova
840ba6926b PT-2355 - pt-online-schema-change should not resume a job with empty boundaries
- The tool should still fail, so I improved error message and added test case
2025-03-22 00:01:56 +03:00
Sveta Smirnova
f9ea94f195 Merge pull request #918 from drwonky/PT-2422
PT-2422 Fix unconstrained UPDATE to pt_osc_history table
2025-03-18 15:04:43 +03:00
Sveta Smirnova
c92d95bc38 Merge pull request #903 from Robertoh98/PT-2410
PT-2410 - Fixing the export with output-format=csv when there are null values
2025-03-18 15:02:03 +03:00
Sveta Smirnova
69cbfca27f Merge branch '3.x' into HEAD 2025-03-13 02:24:07 +03:00
Perry Harrington
9e9f7434d1 PT-2422 Fix unconstrained UPDATE to pt_osc_history table
Ensure that entries in the history table are updated by job_id
instead of updating ALL instances of jobs in the history table.
2025-01-28 11:59:23 -08:00
Perry Harrington
dc77289d60 PT-2389 Fix unconditional ALTER on new table with resume
When running with --resume option the ALTER runs on the new table
even if the new table exists and has already been altered.

This causes a deterministic failure every time the --resume option
is used.  This fix tests if --resume is given and does not run
ALTER on the new table.  If pt-osc did not successfully alter
the new table during the previous invocation, this could cause the
ALTER to not be applied.

The right fix would be to compare the DDL of the _new table to
the proposed DDL generated by pt-osc and only run ALTER if they
do not match.
2025-01-28 10:56:47 -08:00
Sveta Smirnova
a06b3877c8 Merge pull request #909 from percona/PT-2400-pt-table-checksum_reports_the_error_for_warning_code_4164
PT-2400 - pt-table-checksum reports the error for warning code 4164
2025-01-14 18:17:30 +03:00
Sveta Smirnova
5a4bd2f1da Merge pull request #910 from percona/typos_2025_01
Fixed typos found by the GitHub workflow
2025-01-14 18:10:12 +03:00
Sveta Smirnova
6f62b4dc63 Merge pull request #907 from percona/remove_unused_variable_force_concat_enums
Remove unused variable force_concat_enums
2025-01-14 18:08:33 +03:00
Sveta Smirnova
0a98a81370 Merge pull request #863 from hpoettker/PT-2378_table_sync_with_more_fp_precision
PT-2378 - extended FP precision in pt-table-sync
2025-01-14 18:06:55 +03:00
Sveta Smirnova
f837672d1d Merge pull request #861 from hpoettker/PT-2377_table_sync_with_utf8_json
PT-2377 - fixed pt-table-sync for JSON utf8 strings
2025-01-14 18:04:41 +03:00
Henning Poettker
1e581be06a PT-2378 - extended FP precision in pt-table-sync
pt-table-sync now uses up to 17 decimal digits when writing
floating point numbers in the generated SQL statements.
This is necessary to prevent unintended data changes.
2025-01-13 09:31:51 +01:00
Sveta Smirnova
3e69100477 Fixed typos found by the GitHub workflow 2025-01-10 23:07:03 +03:00
Sveta Smirnova
c796b2c148 PT-2400 - pt-table-checksum reports the error for warning code 4164
- Fixed typo
- Added test case
2025-01-10 23:01:35 +03:00
Sveta Smirnova
1bec1fdde8 Remove unused variable force_concat_enums
- Removed variable
- Adjusted utils/update-modules, so it does not process symlinks
2024-12-31 20:14:16 +03:00
Sveta Smirnova
ce20bc7dd1 Merge pull request #860 from hpoettker/PT-2375_table_sync_with_generated_columns
PT-2375 - fixed pt-table-sync for tables with generated columns
2024-12-27 18:08:08 +03:00
Henning Poettker
16b06dcfc2 PT-2377 - fixed pt-table-sync for JSON utf8 strings
The MySQL driver DBD::mysql does not decode JSON values as utf8
although MySQL uses utf8mb4 for all JSON strings.

This change decodes JSON values as utf8 (when not already done)
such that SQL statements are generated correctly.
2024-12-27 13:46:55 +01:00
Roberto de Bem
d5ec5d9ca8 PT-2410 - Removing the enclosed by on \N(Null) values and removing the space existent after the comma 2024-12-21 15:00:37 -03:00
Sveta Smirnova
02ada0ddc9 Release 3.7.0
- Updated version
2024-12-19 18:41:01 +03:00
Sveta Smirnova
e9fb4101fd Merge branch '3.x' into release-v3.7.0 2024-12-19 17:42:43 +03:00
Artem Gavrilov
c4260e5d7a Fix typos 2024-12-18 16:11:27 +02:00
Maciej Dobrzanski
bcbb4e59ab Read @@global object variable when SHOW VARIABLES returns a potentially truncated value 2024-12-03 20:28:01 +01:00
Sveta Smirnova
e038b275ef PT-2340 - Support MySQL 8.4
- Added Lmo submodules into pt-visual-explain
2024-12-02 17:32:32 +03:00
Henning Poettker
5f14441d19 PT-2375 - fixed pt-table-sync for tables with generated columns
Previously, pt-table-sync generated DML statements that included
the generated columns of a table, which is however rejected by
the database and not necessary for the required sync statements.
2024-11-14 23:51:40 +01:00
Sveta Smirnova
8b802722db PT-2340 - Support MySQL 8.4
- Adjusted tools and tests which fail due to fixed update-modules command
- Adjsted t/pt-table-checksum/basics.t test for 8.0
2024-11-13 21:23:39 +03:00
Sveta Smirnova
bb66ab0845 PT-2340 - Support MySQL 8.4
- Implemented functions get_replica_name and get_source_name in lib/MasterSlave.pm I did not implement similar functions in other places, because they set other variables as well, not only replica_name or source_name.
2024-11-13 02:04:39 +03:00
Sveta Smirnova
a1093ff12c PT-2340 - Support MySQL 8.4
- s/slave lag/replica lag/ in tests
- reverted rename of COM_REGISTER_SLAVE to COM_REGISTER_REPLICA, because the constant still named COM_REGISTER_SLAVE in 8.4
- removed some slave leftovers from pt-replica-find
2024-11-12 15:18:36 +03:00
Sveta Smirnova
a2102efb86 PT-2340 - Support MySQL 8.4
- s/slave lag/replica lag/ in reports
2024-10-07 15:53:46 +03:00
Sveta Smirnova
aab0b0cd22 PT-2340 - Support MySQL 8.4
- Fixed typos
2024-10-06 22:55:48 +03:00