Commit Graph

2679 Commits

Author SHA1 Message Date
Sveta Smirnova ee5b249156 Merge pull request #1023 from peppla/fix-access-requirement-for-data-directory
Replace validation logic for data-dir in pt-osc to use innodb_directories.
2026-03-30 15:02:32 +03:00
Sveta Smirnova d37d843aac PR-1023 - Replace validation logic for data-dir in pt-osc to use innodb_directories.
- Data directory could be in innodb_data_home_dir, added this case as well
- Added test case
- Removed diagnostic messages from t/pt-online-schema-change/pt-244.t
2026-03-27 22:42:12 +03:00
Sveta Smirnova 9a74e15460 Merge pull request #1057 from xmj147220591/fix/pt-archiver-bulk-insert-escape
Fix field misalignment in pt-archiver when using --bulk-insert with special characters
2026-03-25 16:49:58 +03:00
Sveta Smirnova dd589f0b49 Merge pull request #1065 from percona/PT-2215_pt-table-sync_does_not_recognize_the_privileges_in_roles_for_MariaDB
Pt 2215 pt table sync does not recognize the privileges in roles for maria db
2026-02-17 20:36:05 +03:00
Sveta Smirnova 4c03acb4ed Merge pull request #1062 from percona/PT-2220_pt-heartbeats_--check-read-only_option_behaves_strangely
PT-2220 - pt-heartbeat's --check-read-only option behaves strangely
2026-02-16 17:05:18 +03:00
Sveta Smirnova f21f864dba Update copyright year to 2026
- Removed copyright notes in the middle of the file
2026-01-31 01:48:02 +03:00
Sveta Smirnova 5402b92110 Update copyright year to 2026
- Updated reference of legacy FSF address with currently recommended way to get actual copy of GPL 2.
- Replaced "Percona Ireland Ltd." and other old Percona names with "Percona LLC and/or it affiliates"
- Updated copyright year for these outdated entries
2026-01-31 01:42:00 +03:00
Sveta Smirnova 981ecd09db Update copyright year to 2026
- Updated copyright year in Perl/Bash tools and docs
2026-01-30 17:25:04 +03:00
Sveta Smirnova 84f96df600 Merge pull request #1055 from percona/PT-2503_pt-eustack-resolver_does_not_have_--version_option
Pt 2503 pt eustack resolver does not have   version option
2026-01-26 21:09:57 +03:00
Sveta Smirnova a925e73708 PT-2215 - pt-table-sync does not recognize the privileges in roles for MariaDB
- Removed unnecessary FOR clause from the SHOW GRANTS statement (we do not need it since 4.1.2 and we are not going to support legacy MySQL versions if such a support breaks modern versions support).
2026-01-23 15:05:25 +03:00
Sveta Smirnova 0afd03e5eb PT-2220 - pt-heartbeat's --check-read-only option behaves strangely
- Created fix and test case
2026-01-22 19:29:40 +03:00
Sveta Smirnova cb66c67fe2 PT-23 - ps files in pt-stalk samples disclose MySQL password
- Added password-related warnings into the documentation
2026-01-16 16:45:15 +03:00
Sveta Smirnova 289bca047f PT-23 - ps files in pt-stalk samples disclose MySQL password
- Added a warning for cases when the user provides MySQL password on the
  command line
- Added test case
2026-01-16 16:08:31 +03:00
wu.xu ad57c0fc1b Fix field misalignment in pt-archiver bulk-insert with special characters
Fixed escape() function to properly escape special characters (tabs,
newlines, backslashes) in the correct order when using --bulk-insert.

The original single regex replacement could cause incorrect escaping
order. Now escaping is done in sequence: backslash first, then newline,
then tab, ensuring proper field alignment when data contains these
special characters.

Fixes issue where fields would misalign when archiving data containing
tabs, newlines, or backslashes with --bulk-insert option.
2026-01-16 14:40:41 +08:00
Sveta Smirnova 20e25a6fd0 PT-2503 - pt-eustack-resolver does not have --version option
- Cleaned warnings seen before
- Added test case
2026-01-15 20:08:06 +03:00
Sveta Smirnova 55eea5734c PT-2503 - pt-eustack-resolver does not have --version option
- Aligned pt-eustack-resolver with other tools, so options are processed standard way
2026-01-14 17:50:07 +03:00
Sveta Smirnova 440befcf4c RM-1554 - Percona Toolkit 3.7.1
- Updated version properly
2025-12-13 17:17:11 +03:00
Sveta Smirnova ffa765f471 RM-1554 - Percona Toolkit 3.7.1
- Updated Go to 1.25.5
- Updated version for all tools
2025-12-12 16:01:47 +03:00
Sveta Smirnova 8918850389 Merge pull request #1039 from percona/PT-2498_pt-sift_does_not_work_starting_from_version_3.7.0
PT-2498 - pt-sift does not work starting from version 3.7.0
2025-12-03 16:34:03 +03:00
Sveta Smirnova 380a8085de PT-2498 - pt-sift does not work starting from version 3.7.0
- Added missed module into the tool
- Modified test case, so it tests if this interactive tool works, so we
  do not miss cases like this in the future
2025-12-01 16:21:11 +03:00
Sveta Smirnova 2b350d908e PT-2250 - pt-table-checksum reports error if recursion method is DSN
- We are now setting parent to current source server in get_cxn_from_dsn_table
2025-11-25 17:00:12 +03:00
Sveta Smirnova 95588dd76e PT-2492 - t/pt-online-schema-change/pt-200.t fails after fix for PT-1151
- Fixed typo in bin/pt-table-checksum
2025-11-21 23:30:50 +03:00
Sveta Smirnova eed2c43dcc PT-2492 - t/pt-online-schema-change/pt-200.t fails after fix for PT-1151
- Updated regular expression
2025-11-21 17:06:59 +03:00
Sveta Smirnova 247bc246fb Merge pull request #1013 from percona/PMM-11406-percona-toolkit-update
PMM-11406 Better check to prevent errors from missing fields.
2025-11-12 21:41:55 +03:00
Pep Pla c162562ae3 Replaced validation logic for data-dir 2025-10-30 14:17:23 +01:00
Jiří Čtvrtka 7a26991fb3 PMM-11406 Another typo. 2025-10-02 13:44:30 +02:00
Jiří Čtvrtka d016effd18 PMM-11406 Fix typos in repo. 2025-10-02 13:39:09 +02:00
Sveta Smirnova 64ced79f7d Merge pull request #1005 from percona/PT-2289_Allow_pt-stalk_do_disable_ps-lock-transactions_data_collection_via_parameter
Pt 2289 allow pt stalk do disable ps lock transactions data collection via parameter
2025-09-16 13:40:22 +03:00
Sveta Smirnova 2dbdb8642b Merge pull request #1006 from percona/PT-1151_LP_1225577_pt-online-schema-change_can_silently_drop_rows
PT-1151 - LP #1225577: pt-online-schema-change can silently drop rows
2025-09-12 14:25:42 +03:00
Sveta Smirnova bfeaa98379 PT-2289 - Allow pt-stalk do disable ps-lock-transactions data collection via parameter
- Fixed typo found during review
2025-09-10 18:19:03 +03:00
Sveta Smirnova 2ac8385d2d Merge pull request #1012 from nilnandan/PT-2014-pt-config-diff_does_not_honor_case_insensitivity_flag
PT-2014 - Updated MySQLConfigComparer.pm so now it can honor case insensitivity…
2025-09-10 18:16:33 +03:00
Sveta Smirnova f550652dbf PT-2014 - pt-config-diff does not honor case insensitivity flag
- Fixed the proposed fix
- Fixed proposed configuration files
- Added test case
2025-09-09 19:25:13 +03:00
nilnandan 4e190a34ef Updated MySQLConfigComparer.pm so now it can honor case insensitivity. cnf1 and cnf2 are test files. 2025-09-08 14:12:12 +00:00
Sveta Smirnova 21fd4f7b90 PT-2470 - pt-table-sync supports recursion methods dsn and cluster but documentation does not mention it
- Updated documentation for the option --recursion-method
- I did not mention cluster, because pt-table-sync does not make sense with the cluster
- Test case for the --recursion-method=dsn is in ssl.t
2025-09-08 15:27:20 +03:00
Sveta Smirnova 20b3196cda PT-1151 - LP #1225577: pt-online-schema-change can silently drop rows
- Found case when --check-unique-index-change does not catch error:
  UNIQUE without KEY or INDEX keyword and fixed regular expression
2025-09-08 02:26:30 +03:00
Sveta Smirnova 919970abe9 PT-2289 - Allow pt-stalk do disable ps-lock-transactions data collection via parameter
- Modified t/pt-stalk/pt-stalk.t, so it calls function purge_samples with the correct number of parameters
- Fixed purge_samples, so it can work if variable OPT_PREFIX is not defined
2025-09-07 01:34:05 +03:00
Sveta Smirnova cdc24c10f0 PT-2289 - Allow pt-stalk do disable ps-lock-transactions data collection via parameter
- Implemented _should_skip function as was suggested
2025-09-05 16:08:43 +03:00
Sveta Smirnova 66d20ae6da PT-2289 - Allow pt-stalk do disable ps-lock-transactions data collection via parameter
- Adjusted the implementation
- Created test cases
2025-09-03 00:41:06 +03:00
Sveta Smirnova 2b5ceb9fee Merge pull request #1002 from Shopify/PT-2015_fix_comparing_unsorted_flags
PT-2015 Fix pt-config-diff not sorting flags
2025-09-02 14:56:24 +03:00
Sveta Smirnova c5c6bf34c6 Merge pull request #1003 from percona/PT-2305_pt-online-schema-change_should_error_if_server_is_a_slave_in_row_based_replication
PT-2305 - pt-online-schema-change should error if server is a slave in row based replication
2025-09-02 14:55:48 +03:00
Sveta Smirnova 68a4540a3d PT-2289 - Allow pt-stalk do disable ps-lock-transactions data collection via parameter
- Implemented feature
- Started working on the test
2025-09-01 18:17:04 +03:00
Sveta Smirnova 0d0e7210f7 PT-2322 - pt-mysql-summary does not detect jemalloc.
- Added fix and test case. Fix checks for end of word (space or newline) instead of space.
2025-08-29 15:09:12 +03:00
Sveta Smirnova 699b28d2a3 PT-2305 - pt-online-schema-change should error if server is a slave in row based replication
- Removed use Data::Dumper
2025-08-29 13:52:09 +03:00
Sveta Smirnova ab620a6707 PT-2305 - pt-online-schema-change should error if server is a slave in row based replication
- Implemented fix and test case
- Updated documentation
2025-08-29 01:33:18 +03:00
Hartley McGuire 47f7638d60 PT-2015 Fix pt-config-diff not sorting flags
Previously, flags would be compared in the exact order they are output
by MySQL, which can result in false negatives if the input ordering does
not match.

Example from the ticket:

```
[root@avvr-dbm51 ~]# pt-config-diff /etc/my.cnf h=localhost,P=3047
1 config difference
Variable                  /etc/my.cnf  avvr-dbm51
========================= ============ ============
myisam_recover_options    FORCE,BACKUP BACKUP,FORCE
```

This commit fixes the issue by sorting the flags before comparison to
ensure that any ordering differences will not report a diff.

Co-authored-by: Jonathan Gnagy <jonathan@therubyist.org>
2025-08-27 16:12:27 +00:00
Sveta Smirnova 6854715795 Merge pull request #891 from ehooi/PT-2401
PT-2401 - remove check to fix the 'table does not exist' problem when lower_case_table_names=2 is set
2025-08-26 19:44:15 +03:00
Sveta Smirnova c1d3ebc72a Merge pull request #995 from percona/PT-2435_t_pt-online-schema-change_pt-1717-resume.t_fails_after_PT-2355_fix
PT-2435 - t/pt-online-schema-change/pt-1717-resume.t fails after PT-2…
2025-08-26 19:43:32 +03:00
Sveta Smirnova 670f4d159b Merge pull request #992 from percona/PT-1423_LP_1682929_pt-table-checksum_First_chunk_takes_too_long
PT-1423 - LP #1682929: pt-table-checksum: First chunk takes too long
2025-08-26 19:43:16 +03:00
Sveta Smirnova a0dffc51e4 Merge pull request #989 from agejevasv/fix-precedence-error
Fix script crashing with precedence error
2025-08-26 19:43:00 +03:00
Sveta Smirnova 9e799fd04b Merge pull request #981 from Nyele93/PT-2465_patch_fix_for_mariadb_10.5_above
PT-2465 patch fix for erroneous flavour mismatch in mariadb-10.5.x and above
2025-08-26 19:42:44 +03:00