Commit Graph

4913 Commits

Author SHA1 Message Date
svetasmirnova
9427c16314 PT-2037 - regression fixes
Re-added fix for PT-1340 that was reverted by fix for PT-1398
2022-01-23 03:55:35 +03:00
svetasmirnova
623fdaec91 PT-2037 - option --system-only for pt-stalk
This commit:
1. Moves all changes to the proper place: lib/bash/collect.sh
2. Refactors pt-stalk so it is more modular
3. Places fix for PT-1734 into the right place: lib/bash/collect.sh
4. Fixes tests for PT-1336
2022-01-22 21:21:05 +03:00
svetasmirnova
1f6c95f524 PT-2037 - reviewer suggestions
Refactoring pt-stalk to make it easier to call system and MySQL data collections separately
2022-01-21 04:12:43 +03:00
svetasmirnova
d6e899404e PT-2037 Option --system-only for pt-stalk
Option --system-only triggers only operating system related captures, ignoring all others.
2022-01-19 18:41:05 +03:00
svetasmirnova
5a46d3df77 PT-2037 Added option --system-only to pt-stalk 2022-01-11 01:20:10 +03:00
Nurlan Moldomurov
1c725e94e6 PMM-9337 Update go 1.17 (#529) 2022-01-03 15:02:23 +03:00
Maxim Kondratenko
037b6ed502 SAAS-800 Integrate WhiteSource 2021-12-27 11:41:37 +02:00
Sveta Smirnova
b2860eee31 PT-1336 pt-stalk removes user files from destination (#524)
* PT-1336 Added file name checks and -maxdepth 1 parameter

* PT-1336 pt-stalk removes user files from the destination directory

* Added check that files to be removed were created by pt-stalk

* Added option -maxdepth 1 to find command, so the tool does not search for files in the nested directories

* Added unit tests

* This should fix PT-1812 also
2021-12-10 09:18:18 -03:00
Lenz Grimmer
fde683fb5d PT-1887: Fixed pt-diskstats to work on 5.x kernels (#526)
The amount of fields returned for disk statistics
changed in newer Linux kernel versions to 20 and
caused `pt-diskstat` to simply not provide any output
on these systems. Updated the check in the diskstats
parsing code to proceed with 20 fields as well.

Signed-off-by: Lenz Grimmer <lenz.grimmer@percona.com>
2021-12-03 13:19:36 -03:00
Carlos Salguero
a019907e6e PT-2023 Set out mode to utf8 (#523) 2021-11-18 14:41:35 -03:00
Robert Lankford
60ed28ab31 remove depedency on github.com/prometheus/common/log (#520)
* remove depedency on github.com/prometheus/common/log

* go mod tidy
2021-11-09 09:52:55 -03:00
Carlos Salguero
16716b3a7b PMM-7116 incorrect startup state (#519)
* Updated changelog for (WIP) 3.3.2

* Updated changelog

* PT-7116 Updated MyState results

* PT-7116 Updated MyState results

* PT-7116 Updated MyState results

* PMM-7116 Return the error in MyState

Don't manage the error, just bubble it up.
The client must know there was an error, even when the error is no
'real' like in Mongos instances (there is no error because there is no
replicaset for mongos or standalone)
2021-11-08 10:59:54 -03:00
Carlos Salguero
c5a22407a7 PT-2016 pt-table-sync and CRC32 columns (#521)
* PT-2016 CRC32 on key

* PT-2016 Added tests

* Removed commented out line
2021-11-03 13:53:30 -03:00
Carlos Salguero
951a333c81 PT-1398 Updated way of getting MySQL PID (#517) 2021-10-01 09:27:20 -03:00
Carlos Salguero
0d2c48456f PT-1627 Improve pt-mysql-summary jemalloc detection (#514)
* PT-1627 Changed jemalloc detection function

* Updated Tests
2021-10-01 09:19:25 -03:00
Carlos Salguero
9d6508da5f PT-1900 pt-query-digest not hiding parameter properly sometimes when parameter=binary (#510)
* PT-1900 WIP

* Fixed quoted strings regexes

* PT-1900 Fixed query rewriter to properly handle quoted text

* Fixed merge conflicts with 3.x branch
2021-09-27 08:23:23 -03:00
Carlos Salguero
d91ba9cadd PT-1959 Updated version number (#515)
Not updated in files that will be updated during the build like the
python script, Makefile.PL and some other files like documentation.
2021-09-20 10:27:29 -03:00
Jelle van der Waa
b19654fa48 Make build reproducible (#499)
By setting SOURCE_DATE_EPOCH builds the build binaries can become
reproducible as a rebuild will take the old build date as input.

Motivation: https://reproducible-builds.org
2021-09-20 10:26:27 -03:00
Carlos Salguero
dd2b144004 PMM-8575 migrate toolkit to modules (#512)
* PMM-8575 Fixed test

Fixed sandbox used by go programs, updated all tests.

* PMM-8575 Fixed test

Fixed sandbox used by go programs, updated all tests.

* Removed Gopkg

* Switched to go 1.16

* Updated go.mod

* Upgraded deps

* Updated deps
2021-09-10 16:08:58 -03:00
Sergey Kuzmichev
ad593c6de9 Fix for PT-1983: pt-summary has missing records for memory due to dmidecode changes (#513)
* Fix for PT-1983 pt-summary missing one DIMM

This is a fix for PT-1983. dmidecode now doesn't print "Speed: UKNOWN" for
missing DIMMs. pt-summary code relies on the Speed field to be there, and when
it's missing, rows get concatenated (or rather not broken down correctly).
Adjusted the relevant code to not rely on the Speed field to be present.

* Added test for the fix for PT-1983

Due to dmidecode changes in 3.2, pt-summary needs to be able to work
with memory-related info with some missing fields in the dmidecode
output. This commit adds a test with dmidecode output modified to
include new format.

In addition, fixing test that are failing due to commit c9ec74c251

* PT-1983: updated changelog to reflect the bug fixed
2021-09-08 07:32:30 -03:00
Carlos Salguero
e389d2181a PT-1800 Updated docs (#511) 2021-08-31 08:16:34 -03:00
Sergey Pronin
ee6a9da438 Update installation.rst (#508)
1. the list of operation systems is outdated
2. not on any installation page we have the list of supported OSes
3. we have supported OSes in our lifecycle doc - why add it here?
2021-08-20 11:22:54 +03:00
Paul Jacobs
e71fc0376b Spelling 2021-08-20 08:21:18 +03:00
Carlos Salguero
4b8ae0563f PMM-8489 Cluster ID for standalone server (#507)
* PMM-8489 Cluster ID for standalone server

* Updated error type

* Updated MyState to ignore errors on standalone servers

* Deleted dep files

* Revert "Deleted dep files"

This reverts commit 236303196b.

* Removed go.mod &^ updated lock

* Updated mongodb driver

* PMM-8489 Updated errors list
2021-08-18 11:22:47 -03:00
Roma Novikov
7eaca8a98e versions update (#505)
* versions update 

according to https://www.percona.com/services/policies/percona-software-support-lifecycle#pt

* correcting Debian versions (forgot to change them)

according to https://www.percona.com/services/policies/percona-software-support-lifecycle#pt
2021-08-10 07:50:41 -03:00
Carlos Salguero
d14d18a1bf PT-1997 Added error logs (#506) 2021-08-03 09:07:25 -03:00
Carlos Salguero
21c154d86b Updated changelog for PT-1940 2021-07-30 19:46:13 -03:00
duxthefux
4a32ca7675 Added mysql version check for bug fix introduced in 8.0.14 (#474)
Thanks for the fix.
2021-07-30 19:41:53 -03:00
dependabot[bot]
35a19ad0a4 Bump go.mongodb.org/mongo-driver from 1.3.4 to 1.5.1 (#501)
Bumps [go.mongodb.org/mongo-driver](https://github.com/mongodb/mongo-go-driver) from 1.3.4 to 1.5.1.
- [Release notes](https://github.com/mongodb/mongo-go-driver/releases)
- [Commits](https://github.com/mongodb/mongo-go-driver/compare/v1.3.4...v1.5.1)

---
updated-dependencies:
- dependency-name: go.mongodb.org/mongo-driver
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-07-29 16:27:18 -03:00
Carlos Salguero
ecf43e2a17 PT-1985 pt-deadlock db schema check (#502) 2021-07-29 12:15:53 -03:00
Carlos Salguero
543f30c073 PT-1986 Check schema exists upon start (#503) 2021-07-29 12:15:23 -03:00
Andrii Dema
d84cb2496e PT-1930: pt-k8s-debug-collector should not attempt collecting PXC information when running against PSMDB (#498)
* PT-1930: pt-k8s-debug-collector should not attempt collecting PXC information when running against PSMDB

https://jira.percona.com/browse/PT-1930

Removed PXC resources to collect while running with `--resource psmdb`

* Add more `psmdb` resources

Also resolves https://jira.percona.com/browse/PT-1934

* Add `resourceType` function to collect summaries for PXC/PSMDB when option `--cluster` is specified
2021-07-28 09:01:20 -03:00
Andrii Dema
b0597554ad PT-1931: pt-k8s-debug-collector does not gather summaries for PSMDB (#500)
https://jira.percona.com/browse/PT-1931

When I tried to reproduce the bug, `pt-mongodb-summary` didn't launch only when option `--cluster` was specified. This PR fixes this behavior and also fixes https://jira.percona.com/browse/PT-1932
2021-07-27 13:49:58 -03:00
Andrii Dema
1114eb4dad PT-1926: pt-k8s-debug-collector should not collect passwords (#497)
https://jira.percona.com/browse/PT-1926

Save secrets only with configuration data
2021-07-21 10:38:20 -03:00
グリアンドロ
bdbfd44a1f Updated CONTRIBUTE.md to describe the steps in more depth (#496) 2021-07-02 17:20:08 -03:00
I
8e334d9ed2 PT-1974: Support fingerprinting for --print in pt-kill (#495)
* PT-1974: Support fingerprinting for --print in pt-kill

This commit implements `--fingerprint` that modifies the `--print`
behaviour and forces the query fingerprint to be displayed instead of an
original query.

* Added changelog entry.
2021-06-24 11:40:32 -03:00
yoku0825
dcf237ef8c Fix test PT-1966 (#493)
* Detect raising error for PT-1966

* Fix non-duplicated column name for PT-1966

* More good way to catch an error. (PT-1966)

- https://github.com/percona/percona-toolkit/pull/493#pullrequestreview-678426876

* Add Changelog (PT-1966)

- https://github.com/percona/percona-toolkit/pull/493
2021-06-17 10:28:54 -03:00
Sergey Kuzmichev
49b570ed0c Fix for PT-1965 mysql-only lacks mysqladmin output (#492)
* Fix for PT-1965 mysql-only lacks mysqladmin output

This is a fix for PT-1965. Moved mysqladmin execution out of an if block
that contains stuff executed only when --mysql-only is not specified.
Before this fix, mysqladmin was not executed with --mysql-only.

* PT-1965: updated changelog to reflect the bug fixed
2021-06-10 08:43:07 -03:00
Carlos Salguero
0b97e1f471 PT-1747 pt-online-schema-change was bringing the database into a broken state (#491)
* PT-1717 Updated behavior for FKs

* Fixed rename_columns.t

* Fixed pt-244.t

* fixed drop swap test

* Fixed test for MySQL 8.0

* Updated test for MySQL 8

* Updated test for MySQL 8
2021-06-03 12:00:43 -03:00
Dávid Mikuš
4dd72d96b1 Add some missing attributes for members (#490) 2021-05-04 10:49:48 -03:00
Paul Jacobs
be856c84b5 Update copyright year 2021-05-04 15:42:25 +03:00
Carlos Salguero
c47ac4d4df PT release 3.3.1 testing branch (#486)
* PT release 3.3.1 testing branch

* Update pkgs version

* Updated version from build script
2021-04-30 10:08:05 -03:00
PaulJacobs-percona
2cd3673314 RM-1954 Release Notes 3.3.1 (#489) 2021-04-29 09:45:01 -03:00
Roma Novikov
d9b3280f07 Update pt-summary (#487) 2021-04-27 08:55:10 -03:00
Carlos Salguero
5a0cbd79fc PT-716 [WIP] Forced free to use wide mode (#485) 2021-04-06 10:13:21 -03:00
Carlos Salguero
d78acd961c PMM-7689 Updated data type for getLastErrorDefaults.w (#484)
This field is not being used by any tool but it is needed to decode
bigger structures having it. Since the value can be an int to indicate
the number 1-primary, etc, or 'majority', I've changed the field type
from int to interface{}
2021-04-05 14:45:46 -03:00
Carlos Salguero
e570cecbab PT-1914 Column data lost when 'Generated' is in the column comment (#482)
* PMM-1914 Fixed column parsing having generated

Fixed table parser code that errouneously considered a column as
generated when the default was empty DEFAULT '' and the COMMENT had
the word 'Generated'.

* PMM-1914 Updated TableParser in all programs

* PT-1914 Updated changelog

* PT-1914 Added test
2021-03-09 11:46:05 -03:00
Carlos Salguero
4f78d5450c PT-1919 drop-swap can drop triggers (#483)
* PT-1919 drop-swap can drop triggers

* PT-1919 Update changelog
2021-03-05 11:32:03 -03:00
PaulJacobs-percona
9913690ebc Merge pull request #481 from percona/pt-k8s-debug-collector-doc-correction
Update and rename pt-k8s-psmdb-summary.rst to pt-k8s-debug-collector.rst
2021-01-15 09:06:22 +03:00
Roma Novikov
9b62421772 Update and rename pt-k8s-psmdb-summary.rst to pt-k8s-debug-collector.rst 2021-01-14 21:10:55 +02:00