percona/percona-toolkit
1
0
Fork 0
mirror of https://github.com/percona/percona-toolkit.git synced 2025-12-14 02:01:23 +08:00
Code Issues Packages Projects Releases Wiki Activity

PT-1887: Fixed pt-diskstats to work on 5.x kernels (#526)

Browse Source 
The amount of fields returned for disk statistics
changed in newer Linux kernel versions to 20 and
caused `pt-diskstat` to simply not provide any output
on these systems. Updated the check in the diskstats
parsing code to proceed with 20 fields as well.

Signed-off-by: Lenz Grimmer <lenz.grimmer@percona.com>
This commit is contained in:
Lenz Grimmer
2021-12-03 16:19:36 +00:00
committed by GitHub
parent a019907e6e
commit fde683fb5d
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
bin/pt-diskstats
View File

@@ -2243,8 +2243,10 @@ sub parse_diskstats_line {
# linux kernel source => Documentation/iostats.txt
# 2.6+ => 14 fields
# 4.18+ => 18 fields
# 5.x+ => 20 fields (PT-1887)
my @num_fields = (14, 18, 20);
my @dev_stats = split ' ', $line;
return unless @dev_stats == 14 or @dev_stats == 18;
return unless grep {$_ == scalar(@dev_stats)} @num_fields;
my $read_bytes = $dev_stats[READ_SECTORS] * $block_size;
my $written_bytes = $dev_stats[WRITTEN_SECTORS] * $block_size;