Commit Graph

1834 Commits

Author SHA1 Message Date
Daniel Nichter
0b25accdf6 Merge trunk r478. 2012-12-04 16:54:50 -07:00
Daniel Nichter
510efda1b3 Update ExplainAnalyzer.t, QueryReportFormatter.t, and SchemaIterator.t for MySQL 5.6. 2012-12-04 23:47:20 +00:00
Daniel Nichter
0ad52d0003 Update DSNParser in pt-table-usage and pt-visual-explain to avoid https://refute.testnoir.com/percona-toolkit/jobs/percona-toolkit-mysql-5.6/2/results/errors#18960 because Sandbox sets {L} but new DSNParser is needed to check for and delete it. 2012-12-04 15:42:14 -07:00
Brian Fraser
d2f1742606 Merged fix-917770-pt-config-diff-uninit-value-crash 2012-12-04 13:43:40 -03:00
Brian Fraser
e0c8fac54e Merged doc-patch-empty-replicate-table-1074179 2012-12-04 13:42:22 -03:00
Brian Fraser
a7a0da3bc9 Refactor _parse_varvals.
Now it takes two arguments: A regexp and a string to match against.
_parse_varvals itself was split in three:  _preprocess_varvals,
_parse_varvals, and _process_val.

This also modifies the three places that call _parse_varvals; For
two, no real changes were needed, but parse_mysqld() required a fix
to deal with the two final lines of mysqld --help --verbose:

   To see what values a running MySQL server is using, type
   'mysqladmin variables' instead of 'mysqld --verbose --help'.
2012-12-04 05:02:56 -03:00
Daniel Nichter
9bd431e8b7 Use mysql.columns_priv instead of mysql.host as the empty table because mysql.host doesn't exist in 5.6. 2012-12-04 01:50:32 +00:00
Daniel Nichter
c094494f1f Fix CMD_MYSQL and CMD_MYSQLDUMP in pt-mysql-summary so they can be specified on cmd line, then do so in pt-mysql-summary.t so mysqldump 5.6 is used with 5.6 because earlier versions don't work with MySQL 5.6. 2012-12-04 01:31:52 +00:00
Daniel Nichter
e441b571c3 Fix a pt-osc test by analyzing table to get accurate explain estimate. 2012-12-04 00:51:24 +00:00
Daniel Nichter
7d896e5c49 Add 5.6 sample for t/pqd/explain.t test. 2012-12-04 00:44:32 +00:00
Daniel Nichter
526a12438e Fix pt-table-sync/basics.t data because timestamps in sakila.sql changed. 2012-12-04 00:34:56 +00:00
Daniel Nichter
e7c3e908bb Create percona_test.sentinel in start-sandbox so wait_for_slave() works for other sandboxes. skip_all for skip_innodb.t with 5.6 because of http://bugs.mysql.com/67798. 2012-12-04 00:14:20 +00:00
Daniel Nichter
cb640e2cad Fix 5.6 data. Make start-sandbox load extra .sql files. Make ptc/basics.t pass on 5.6. 2012-12-03 21:08:42 +00:00
Daniel Nichter
9edf7bf471 Merge 2.1 r476. 2012-12-03 20:08:27 +00:00
Daniel Nichter
6c9f4c0722 Fix sakila.sql so it loads on 5.0. Only wait 60s for replication for test-env start. 2012-12-03 20:06:47 +00:00
Daniel Nichter
6282ee8796 Make Net::Address::IP::Local optional in check-dev-env. 2012-12-01 20:08:00 -07:00
Daniel Nichter
d0bd80037e Don't use [[ ]] since it doesn't work on Ubuntu. 2012-12-01 21:08:11 +00:00
Daniel Nichter
c251c72eb3 Use good Bash in sandbox/start-sandbox. 2012-12-01 13:38:46 -07:00
Daniel Nichter
9b97298721 Don't use -pmsandbox because 5.6 mysql cli warns that it's not safe. Plus, /tmp/PORT/use already adds --defaults-file=/tmp/PORT/my.sandbox.cnf. 2012-12-01 11:17:18 -07:00
Daniel Nichter
11907bbbe8 Merge pt-archiver-pxc-tests 2012-11-30 13:02:56 -07:00
Daniel Nichter
e69533e492 Test with MyISAM tables. Add PXC section to pt-archiver docs. 2012-11-30 19:25:35 +00:00
Brian Fraser
76a010abee Fix for 917770: Use of uninitialized value in substitution (s///) at pt-config-diff line 1996
This turned out to be two bugs mangled into one.

First, _parse_varvals can deal with (var, undef), but not with (undef).
This is a problem because two of the trhee spots that call
_parse_varvals can return undef because of this:

      map  { $_ =~ m/^([^=]+)(?:=(.*))?$/ }
      grep { $_ !~ m/^\s*#/ }  # no # comment lines
      split("\n", $mysqld_section)

The problem is twofold. First, we are not skipping empty or
whitespace-only lines. That means that the map will fail,
and pass an undef to _parse_varvals. So this ended up in
a triple fix: Make _parse_varvals deal with a sole undef,
skip empty/whitespace lines, and change that map to

	map  { $_ =~ m/^([^=]+)(?:=(.*))?$/ ? ($1, $2) : () }

so even if the regex fails in the future, no sole undef
will be passed down the chain.
2012-11-30 16:17:45 -03:00
Daniel Nichter
8343f6b1f7 Conditionalize dest.t for PXC. 2012-11-30 18:34:14 +00:00
Daniel Nichter
2da682dff3 Fix pt-archiver tests to work with PXC in cluster mode. dest.t is still a work in progress. 2012-11-30 18:16:11 +00:00
Daniel Nichter
f6fd2b7470 Only run t/pt-table-checksum/pxc.t if in cluster mode. 2012-11-30 18:14:06 +00:00
Daniel Nichter
a9ccca199d Rewrite t/pt-archiver/pxc.t. 2012-11-30 18:13:25 +00:00
Daniel Nichter
72a129bce1 Add is_cluster_mode() to lib/Sandbox.pm. 2012-11-30 18:13:04 +00:00
Brian Fraser
739babd9bf Remove the B<> and reword the new text 2012-11-29 22:48:13 -03:00
Daniel Nichter
065e0a8c5e Merge 2.1 at r473. 2012-11-30 00:23:42 +00:00
Daniel Nichter
90a91cd384 Merge pt-osc-pxc-tests. 2012-11-29 17:10:51 -07:00
Daniel Nichter
8549fe5d99 Test and require wsrep_OSU_method=TOI. 2012-11-29 23:26:53 +00:00
Daniel Nichter
13318a9710 Update modules in ptc. 2012-11-29 22:32:31 +00:00
Daniel Nichter
9e97edebd2 Check PXC version in ptc and pt-osc, die if < 5.5.28. 2012-11-29 22:26:46 +00:00
Daniel Nichter
10c8654a49 Update PXC section in ptc and pt-osc docs to say that 5.5.28-23.7 is required, not 5.5.27-23.6 because of bug 1040108. 2012-11-29 22:09:32 +00:00
Brian Fraser
e71d3adb96 Merged fix-1079341-pt-osc-skip-myisam-fk-checks 2012-11-29 17:15:56 -03:00
Brian Fraser
2614eabd31 Merged fix-1074179-ptc-replicate-check-only-filters 2012-11-29 17:14:14 -03:00
Brian Fraser
b37c138ec8 Merged fix-1052475-ptc-uninit-crash-slave-errors 2012-11-29 17:12:29 -03:00
Brian Fraser
cddead8a69 Merged fix-831525-pqd-mangled-help 2012-11-29 17:10:54 -03:00
Brian Fraser
713457226a Merged fix-887638-ptqa-negative-at-byte 2012-11-29 17:09:33 -03:00
Brian Fraser
d496fbcf11 Tests for pt-archiver + PXC 2012-11-29 07:29:24 -03:00
Daniel Nichter
432b9e42b3 Remove time zone stuff from sakila.sql and update NibbleIterator.t tests. 2012-11-28 15:00:30 -07:00
Daniel Nichter
4027019589 Fix code comment. 2012-11-28 21:44:56 +00:00
Daniel Nichter
51f5466aef Re-dump sakila.sql so it has the same ts so NibbleIterator.t doesn't fail. Consequently update 2 ptc tests now that mysql.proc is empty. 2012-11-28 14:39:19 -07:00
Daniel Nichter
e9d064c816 Fix a code comment. 2012-11-28 21:19:52 +00:00
Daniel Nichter
824c34b5d2 Only check --alter if given. Fix some tests, add add_col to make some tests work on PXC or not. 2012-11-28 21:11:29 +00:00
Daniel Nichter
d515e3b382 r472 was a miscommit: it includes new --check-alter check for cluster node+MyISAM node and pxc.t. 2012-11-28 17:58:40 +00:00
Daniel Nichter
61b352a04d Fix sandbox/load-sakila-db so it exits on error. 2012-11-28 17:55:35 +00:00
Daniel Nichter
7b330c4817 Add and use basic_no_fks_innodb.sql with PXC to avoid MyISAM bugs. Make query_table.pl handle deadlock on START TRANSACTION. Give alter_active_table.t tests unique names. 2012-11-28 01:32:31 +00:00
Daniel Nichter
d30265d245 Use direct mysqldump for sakila to avoid PXC MyISAM bugs and so that tests like t/pt-online-schema-change/basics.t can restore sakila easily. 2012-11-28 01:29:49 +00:00
Daniel Nichter
5343d43528 Change basic_no_fks.sql back to MyISAM but with explicit aut-inc values. 2012-11-27 11:37:18 -07:00