percona/percona-toolkit
1
0
Fork 0
mirror of https://github.com/percona/percona-toolkit.git synced 2025-09-02 02:34:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

fixed side effects of typo correction of expire_logs_days

Browse Source
This commit is contained in:
Frank Cizmich
2014-09-19 13:05:53 -03:00
parent a4278961f9
commit 9fd72e0fb7
2 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
lib/VariableAdvisorRules.pm
View File

@@ -430,10 +430,10 @@ sub get_rules {
},
},
{
id => 'expire_log_days',
id => 'expire_logs_days',
code => sub {
my ( %args ) = @_;
return _var_eq($args{variables}->{expire_log_days}, 0)
return _var_eq($args{variables}->{expire_logs_days}, 0)
&& _var_seq($args{variables}->{log_bin}, "ON");
},
},

10
t/lib/VariableAdvisorRules.t
View File

@@ -276,12 +276,12 @@ my @cases = (
},
{ name => "expire_log_days",
vars => [qw(expire_log_days 0 log_bin ON)],
advice => [qw(expire_log_days)],
{ name => "expire_logs_days",
vars => [qw(expire_logs_days 0 log_bin ON)],
advice => [qw(expire_logs_days)],
},
{ name => "expire_log_days, log_bin OFF, only warns about log_bin",
vars => [qw(expire_log_days 0 log_bin OFF)],
{ name => "expire_logs_days, log_bin OFF, only warns about log_bin",
vars => [qw(expire_logs_days 0 log_bin OFF)],
advice => [qw(log_bin)],
},
{ name => "innodb_file_io_threads",