percona/percona-toolkit
1
0
Fork 0
mirror of https://github.com/percona/percona-toolkit.git synced 2026-05-17 01:01:27 +08:00
Code Issues Packages Projects Releases Wiki Activity

Don't log warning and set non-zero exit on API error, just retry.

Browse Source
This commit is contained in:
Daniel Nichter
2013-10-04 15:32:59 -07:00
parent f6661ca658
commit 9527daea4c
1 changed files with 10 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
bin/pt-agent
+10 -4
View File
@@ -5667,19 +5667,25 @@ sub get_api_client {
eval {
$entry_links = $client->get(link => $client->entry_link);
};
if ( $EVAL_ERROR ) {
$logger->warning("API error: $EVAL_ERROR");
if ( my $e = $EVAL_ERROR ) {
my $code = $client->response->code;
if ( $code && $code == 503 ) {
$logger->info("API is down for maintenance (503)");
}
else {
$logger->info("API error: $e");
}
}
elsif (
!$entry_links
|| (ref($entry_links) || '') ne 'HASH'
|| !scalar keys %$entry_links
) {
$logger->warning('API returned invalid entry links: '
$logger->info('API returned invalid entry links: '
. Dumper($entry_links));
}
elsif ( !$entry_links->{agents} ) {
$logger->warning('API did not return agents link: '
$logger->info('API did not return agents link: '
. Dumper($entry_links));
}
else {