percona/percona-toolkit
1
0
Fork 0
mirror of https://github.com/percona/percona-toolkit.git synced 2025-09-04 19:37:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add untested warning to DSNParser if using UTF-8 and DBD::mysql < 3.0008.

Browse Source
This commit is contained in:
Daniel Nichter
2013-02-12 19:09:25 -07:00
parent 924f3eb5da
commit 13172a05dc
1 changed files with 18 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
lib/DSNParser.pm
View File

@@ -58,7 +58,8 @@ sub new {
die "I need a $arg argument" unless $args{$arg};
}
my $self = {
opts => {} # h, P, u, etc. Should come from DSN OPTIONS section in POD.
opts => {}, # h, P, u, etc. Should come from DSN OPTIONS section in POD.
warn_broken_utf8 => 0,
};
foreach my $opt ( @{$args{opts}} ) {
if ( !$opt->{key} || !$opt->{desc} ) {
@@ -282,6 +283,22 @@ sub get_dbh {
$defaults->{mysql_local_infile} = 1;
}
# Check for broken DBD::mysql UTF-8.
eval {
require DBD::mysql;
};
if ( !$EVAL_ERROR ) {
if ( $defaults->{mysql_enable_utf8}
&& $DBD::mysql::VERSION lt '3.0008'
&& !$self->{warn_broken_utf8}++ )
{
warn "WARNING: UTF-8 support is enabled but DBD::mysql "
. "v$DBD::mysql::VERSION is installed which does not work "
. "correctly with UTF-8. You should install a newer version "
. "of DBD::mysql, else data will be displayed incorrectly.\n";
}
}
# Only add this if explicitly set because we're not sure if
# mysql_use_result=0 would leave default mysql_store_result
# enabled.