Commit Graph

501 Commits

Author SHA1 Message Date
Corey Butler
28c3aa8717 Merge pull request #1109 from wsobolewski/utf
Support whitespace and non-ASCII characters in path.
2024-11-13 22:24:54 -06:00
Corey Butler
a81c1b908c Merge pull request #1070 from wsobolewski/arm64
Arm64
2024-11-12 11:44:13 -06:00
Corey Butler
1f84908544 Merge pull request #1181 from stefan-ptrvch/older-version-installation-bugfix
Double Slash in URL Bugfix
2024-11-12 11:18:04 -06:00
Stefan Petrović
75f22001fb Fixed double slash bug that caused versions older than 16.9.0 to have incorrect URLs. 2024-11-08 11:11:57 +01:00
Corey Butler
6284f0ec44 Merge pull request #1172 from coreybutler/coreybutler-patch-10
Update bot.yml
2024-09-22 10:47:08 -05:00
Corey Butler
6c808c5c37 Update bot.yml 2024-09-22 10:46:38 -05:00
Corey Butler
718fd4a1ac Merge pull request #1161 from CyBot/master
Don't perform any changes when trying to use current node version
2024-09-10 09:32:49 -05:00
Tobias Kellner
95133cb1d0 Don't perform any changes when trying to use current node version 2024-08-02 20:46:51 +02:00
Wojciech Sobolewski
54a0243299 Update version check logic. 2024-08-01 19:44:11 +02:00
Corey Butler
e11ee22f85 Merge pull request #1158 from alanblins/fixLinkedinLink
Fix typo linkedin href
2024-07-19 10:50:45 -05:00
Alan Lins
37a3f3e85f Fix typo linkedin href 2024-07-19 14:56:38 +01:00
Corey Butler
a0b28cea92 Merge pull request #1156 from coreybutler/coreybutler-patch-9
Update README.md
2024-07-15 16:27:31 -05:00
Corey Butler
f35af2896c Update README.md 2024-07-15 16:27:09 -05:00
Corey Butler
6819caa528 Update README.md 2024-07-15 15:51:10 -05:00
Corey Butler
147aa4f49e Merge pull request #1135 from VISHNU-LMNTRIX/master
Fixed a small typo from README.md
2024-05-06 11:50:57 -05:00
Vishnu Prasad
d4b3867d20 Fixed a typo: 'The install' to 'To install' 2024-05-06 20:21:58 +05:30
Corey Butler
60d4312fbe Merge pull request #1131 from coreybutler/coreybutler-patch-8
Update README.md
2024-04-29 10:44:06 -05:00
Corey Butler
7a10d51df4 Update README.md 2024-04-29 10:42:13 -05:00
Wojciech Sobolewski
dc699f5960 Code cleanup. 2024-04-02 19:52:28 +02:00
Corey Butler
1e14623ddb Merge pull request #1114 from sagexfors/patch-1
Update README.md
2024-03-18 10:56:01 -05:00
sagexfors
dac961f4fd Update README.md
nvm check -> nvm debug
2024-03-16 11:22:35 +08:00
Wojciech Sobolewski
bab56dab69 Support whitespace and non-ASCI characters in path. 2024-02-27 21:14:49 +01:00
Corey Butler
94f952aebb Merge pull request #1105 from jamesbeegen/typo-fix
Fixed a typo in the word 'simplicity'
2024-02-23 17:05:08 +00:00
Beegen, James C (CGI Federal)
5c7b19ce69 Fixed a typo in the word 'simplicity' 2024-02-22 15:13:38 -05:00
Corey Butler
3ed627953c Merge pull request #1072 from coreybutler/dependabot/github_actions/actions/stale-9
Bump actions/stale from 8 to 9
2023-12-26 23:29:29 +00:00
Corey Butler
29656c93df Merge pull request #1058 from coreybutler/dependabot/go_modules/buildtools/iconize/golang.org/x/sys-0.1.0
Bump golang.org/x/sys from 0.0.0-20201018230417-eeed37f84f13 to 0.1.0 in /buildtools/iconize
2023-12-26 23:28:36 +00:00
Corey Butler
db51c48d9f Merge pull request #1078 from Nasfame/github/fix-issue-template
chore: fix github issue template for older versions
2023-12-22 14:25:05 +00:00
Hiro
9f932c3fbc Update bug_report.yml
fix issue template for older versions
2023-12-21 10:33:29 +05:30
dependabot[bot]
b0155032f9 Bump actions/stale from 8 to 9
Bumps [actions/stale](https://github.com/actions/stale) from 8 to 9.
- [Release notes](https://github.com/actions/stale/releases)
- [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md)
- [Commits](https://github.com/actions/stale/compare/v8...v9)

---
updated-dependencies:
- dependency-name: actions/stale
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-12-08 10:15:42 +00:00
Wojciech Sobolewski
f52379fca3 Update arch detection. 2023-12-04 13:59:01 +01:00
Wojciech Sobolewski
5167c809dc Update build script 2023-12-04 10:16:06 +01:00
Wojciech Sobolewski
b657035a0b Merge branch 'coreybutler:master' into arm64 2023-12-03 13:30:05 +01:00
Wojciech Sobolewski
b07894d8ca Merge branch 'master' of https://github.com/wsobolewski/nvm-windows 2023-12-03 13:28:32 +01:00
Corey Butler
7af9934eaf Add error messages for failed version lookups (when nodejs.org returns partial/no results. Resolves #1064. 1.1.12 2023-11-22 10:41:38 -06:00
dependabot[bot]
770cc28139 Bump golang.org/x/sys in /buildtools/iconize
Bumps [golang.org/x/sys](https://github.com/golang/sys) from 0.0.0-20201018230417-eeed37f84f13 to 0.1.0.
- [Commits](https://github.com/golang/sys/commits/v0.1.0)

---
updated-dependencies:
- dependency-name: golang.org/x/sys
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-11-07 18:23:20 +00:00
Corey Butler
4854ee0832 Merge branch 'master' of github.com:coreybutler/nvm-windows 2023-11-07 12:22:49 -06:00
Corey Butler
3c736ab164 Add debugging option to identify IPv6 configurations and remind users it is slow. 2023-11-07 12:22:12 -06:00
Corey Butler
4b31ca31e1 Merge pull request #967 from nineninesevenfour/fix-spaces-build-bat
allow to run build.bat on paths with spaces
2023-10-10 17:21:00 +00:00
Corey Butler
9c37af6290 Merge pull request #965 from nineninesevenfour/fix-932-path-with-spaces
fix issue #932
2023-10-10 17:19:34 +00:00
Corey Butler
a73ef54a42 Merge pull request #1049 from Juneezee/master
Avoid unnecessary byte/string conversion
2023-10-10 17:14:26 +00:00
Eng Zer Jun
683357f2f3 Avoid unnecessary byte/string conversion
We can use `(*regexp.Regexp).MatchString` instead of
`(*regexp.Regexp).Match([]byte(...))` to avoid unnecessary `[]byte`
conversions and reduce allocations.

Example benchmark:

func BenchmarkMatch(b *testing.B) {
	reg, _ := regexp.Compile("[^0-9]")

	for i := 0; i < b.N; i++ {
		if match := reg.Match([]byte("v")); !match {
			b.Fail()
		}
	}
}

func BenchmarkMatchString(b *testing.B) {
	reg, _ := regexp.Compile("[^0-9]")

	for i := 0; i < b.N; i++ {
		if match := reg.MatchString("v"); !match {
			b.Fail()
		}
	}
}

BenchmarkMatch-16          	19712776	        65.47 ns/op	       1 B/op	       1 allocs/op
BenchmarkMatchString-16    	24261463	        51.16 ns/op	       0 B/op	       0 allocs/op

Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
2023-10-10 18:53:32 +08:00
Corey Butler
71713ecc75 Merge pull request #1048 from acdvorak/patch-1
Fix small typo in README.md
2023-10-09 18:07:53 +00:00
Andrew C. Dvorak
90b67e0ec1 Fix small typo in README.md
`installter` → `installer`
2023-10-09 10:23:23 -05:00
Corey Butler
27bd0d0def Update README.md
closes #1044
2023-10-06 13:22:43 -05:00
Corey Butler
e0e573a710 Merge pull request #1042 from coreybutler/coreybutler-patch-7
Update bug_report.yml
2023-10-02 17:26:21 +00:00
Corey Butler
34f5f135ae Update bug_report.yml 2023-10-02 12:26:11 -05:00
Corey Butler
d7c80b285b Update bug_report.yml 2023-10-02 12:25:44 -05:00
Corey Butler
511644513b Merge pull request #1041 from coreybutler/coreybutler-patch-6
Update bug_report.yml
2023-10-02 17:24:39 +00:00
Corey Butler
4d76e3077a Update bug_report.yml 2023-10-02 12:24:23 -05:00
Corey Butler
27e38b2a17 Merge pull request #1040 from coreybutler/coreybutler-patch-5
Update bug_report.yml
2023-10-02 17:23:26 +00:00