From 76dd2feb30ca11d4d094500da2e5bb4edfb9b860 Mon Sep 17 00:00:00 2001 From: Paddy Xu Date: Wed, 24 Jan 2018 19:11:16 +0200 Subject: [PATCH] remove all destructors --- .../ArchiveFileListView.xaml.cs | 5 ----- .../QuickLook.Plugin.ArchiveViewer/ArchiveInfoPanel.xaml.cs | 5 ----- QuickLook.Plugin/QuickLook.Plugin.ArchiveViewer/Plugin.cs | 5 ----- QuickLook.Plugin/QuickLook.Plugin.CsvViewer/Plugin.cs | 5 ----- QuickLook.Plugin/QuickLook.Plugin.HtmlViewer/Plugin.cs | 5 ----- QuickLook.Plugin/QuickLook.Plugin.IPreviewHandlers/Plugin.cs | 5 ----- QuickLook.Plugin/QuickLook.Plugin.MailViewer/Plugin.cs | 5 ----- QuickLook.Plugin/QuickLook.Plugin.MarkdownViewer/Plugin.cs | 5 ----- .../QuickLook.Plugin.PDFViewer/PdfViewerControl.xaml.cs | 5 ----- QuickLook.Plugin/QuickLook.Plugin.PDFViewer/Plugin.cs | 5 ----- .../QuickLook.Plugin.VideoViewer/ViewerPanel.xaml.cs | 5 ----- QuickLook/Controls/BusyDecorator/BusyDecorator.cs | 5 ----- QuickLook/GlobalKeyboardHook.cs | 5 ----- QuickLook/Helpers/Updater.cs | 4 ++++ QuickLook/PipeServerManager.cs | 5 ----- 15 files changed, 4 insertions(+), 70 deletions(-) diff --git a/QuickLook.Plugin/QuickLook.Plugin.ArchiveViewer/ArchiveFileListView.xaml.cs b/QuickLook.Plugin/QuickLook.Plugin.ArchiveViewer/ArchiveFileListView.xaml.cs index 1298514..c324784 100644 --- a/QuickLook.Plugin/QuickLook.Plugin.ArchiveViewer/ArchiveFileListView.xaml.cs +++ b/QuickLook.Plugin/QuickLook.Plugin.ArchiveViewer/ArchiveFileListView.xaml.cs @@ -37,11 +37,6 @@ namespace QuickLook.Plugin.ArchiveViewer IconManager.ClearCache(); } - ~ArchiveFileListView() - { - Dispose(); - } - public void SetDataContext(object context) { treeGrid.DataContext = context; diff --git a/QuickLook.Plugin/QuickLook.Plugin.ArchiveViewer/ArchiveInfoPanel.xaml.cs b/QuickLook.Plugin/QuickLook.Plugin.ArchiveViewer/ArchiveInfoPanel.xaml.cs index c999dc2..4fd4560 100644 --- a/QuickLook.Plugin/QuickLook.Plugin.ArchiveViewer/ArchiveInfoPanel.xaml.cs +++ b/QuickLook.Plugin/QuickLook.Plugin.ArchiveViewer/ArchiveInfoPanel.xaml.cs @@ -74,11 +74,6 @@ namespace QuickLook.Plugin.ArchiveViewer public event PropertyChangedEventHandler PropertyChanged; - ~ArchiveInfoPanel() - { - Dispose(); - } - private void BeginLoadArchive(string path) { new Task(() => diff --git a/QuickLook.Plugin/QuickLook.Plugin.ArchiveViewer/Plugin.cs b/QuickLook.Plugin/QuickLook.Plugin.ArchiveViewer/Plugin.cs index 2f599dd..fa8a32b 100644 --- a/QuickLook.Plugin/QuickLook.Plugin.ArchiveViewer/Plugin.cs +++ b/QuickLook.Plugin/QuickLook.Plugin.ArchiveViewer/Plugin.cs @@ -62,10 +62,5 @@ namespace QuickLook.Plugin.ArchiveViewer _panel?.Dispose(); _panel = null; } - - ~Plugin() - { - Cleanup(); - } } } \ No newline at end of file diff --git a/QuickLook.Plugin/QuickLook.Plugin.CsvViewer/Plugin.cs b/QuickLook.Plugin/QuickLook.Plugin.CsvViewer/Plugin.cs index 72501bd..d0e7c08 100644 --- a/QuickLook.Plugin/QuickLook.Plugin.CsvViewer/Plugin.cs +++ b/QuickLook.Plugin/QuickLook.Plugin.CsvViewer/Plugin.cs @@ -58,10 +58,5 @@ namespace QuickLook.Plugin.CsvViewer _panel = null; } - - ~Plugin() - { - Cleanup(); - } } } \ No newline at end of file diff --git a/QuickLook.Plugin/QuickLook.Plugin.HtmlViewer/Plugin.cs b/QuickLook.Plugin/QuickLook.Plugin.HtmlViewer/Plugin.cs index 094f90e..2ab0052 100644 --- a/QuickLook.Plugin/QuickLook.Plugin.HtmlViewer/Plugin.cs +++ b/QuickLook.Plugin/QuickLook.Plugin.HtmlViewer/Plugin.cs @@ -63,10 +63,5 @@ namespace QuickLook.Plugin.HtmlViewer _panel?.Dispose(); _panel = null; } - - ~Plugin() - { - Cleanup(); - } } } \ No newline at end of file diff --git a/QuickLook.Plugin/QuickLook.Plugin.IPreviewHandlers/Plugin.cs b/QuickLook.Plugin/QuickLook.Plugin.IPreviewHandlers/Plugin.cs index dfed9f5..44723f5 100644 --- a/QuickLook.Plugin/QuickLook.Plugin.IPreviewHandlers/Plugin.cs +++ b/QuickLook.Plugin/QuickLook.Plugin.IPreviewHandlers/Plugin.cs @@ -75,10 +75,5 @@ namespace QuickLook.Plugin.IPreviewHandlers _panel?.Dispose(); _panel = null; } - - ~Plugin() - { - Cleanup(); - } } } \ No newline at end of file diff --git a/QuickLook.Plugin/QuickLook.Plugin.MailViewer/Plugin.cs b/QuickLook.Plugin/QuickLook.Plugin.MailViewer/Plugin.cs index b93bb6d..7f6dded 100644 --- a/QuickLook.Plugin/QuickLook.Plugin.MailViewer/Plugin.cs +++ b/QuickLook.Plugin/QuickLook.Plugin.MailViewer/Plugin.cs @@ -81,10 +81,5 @@ namespace QuickLook.Plugin.MailViewer throw new Exception($"{path} is not a valid msg file."); } - - ~Plugin() - { - Cleanup(); - } } } \ No newline at end of file diff --git a/QuickLook.Plugin/QuickLook.Plugin.MarkdownViewer/Plugin.cs b/QuickLook.Plugin/QuickLook.Plugin.MarkdownViewer/Plugin.cs index bdcd7b9..2af8e7b 100644 --- a/QuickLook.Plugin/QuickLook.Plugin.MarkdownViewer/Plugin.cs +++ b/QuickLook.Plugin/QuickLook.Plugin.MarkdownViewer/Plugin.cs @@ -63,11 +63,6 @@ namespace QuickLook.Plugin.MarkdownViewer _panel = null; } - ~Plugin() - { - Cleanup(); - } - private string GenerateMarkdownHtml(string path) { var md = File.ReadAllText(path); diff --git a/QuickLook.Plugin/QuickLook.Plugin.PDFViewer/PdfViewerControl.xaml.cs b/QuickLook.Plugin/QuickLook.Plugin.PDFViewer/PdfViewerControl.xaml.cs index 4cf40b4..10633b3 100644 --- a/QuickLook.Plugin/QuickLook.Plugin.PDFViewer/PdfViewerControl.xaml.cs +++ b/QuickLook.Plugin/QuickLook.Plugin.PDFViewer/PdfViewerControl.xaml.cs @@ -94,11 +94,6 @@ namespace QuickLook.Plugin.PDFViewer ReRenderCurrentPage(); } - ~PdfViewerControl() - { - Dispose(); - } - public event EventHandler CurrentPageChanged; private void NavigatePage(object sender, int delta) diff --git a/QuickLook.Plugin/QuickLook.Plugin.PDFViewer/Plugin.cs b/QuickLook.Plugin/QuickLook.Plugin.PDFViewer/Plugin.cs index 68638fc..6b0e8e2 100644 --- a/QuickLook.Plugin/QuickLook.Plugin.PDFViewer/Plugin.cs +++ b/QuickLook.Plugin/QuickLook.Plugin.PDFViewer/Plugin.cs @@ -103,10 +103,5 @@ namespace QuickLook.Plugin.PDFViewer { _context.Title = $"{Path.GetFileName(_path)} ({_pdfControl.CurrentPage + 1} / {_pdfControl.TotalPages})"; } - - ~Plugin() - { - Cleanup(); - } } } \ No newline at end of file diff --git a/QuickLook.Plugin/QuickLook.Plugin.VideoViewer/ViewerPanel.xaml.cs b/QuickLook.Plugin/QuickLook.Plugin.VideoViewer/ViewerPanel.xaml.cs index aea30d1..3b05cda 100644 --- a/QuickLook.Plugin/QuickLook.Plugin.VideoViewer/ViewerPanel.xaml.cs +++ b/QuickLook.Plugin/QuickLook.Plugin.VideoViewer/ViewerPanel.xaml.cs @@ -238,11 +238,6 @@ namespace QuickLook.Plugin.VideoViewer mediaElement.Play(); } - ~ViewerPanel() - { - Dispose(); - } - [NotifyPropertyChangedInvocator] protected virtual void OnPropertyChanged([CallerMemberName] string propertyName = null) { diff --git a/QuickLook/Controls/BusyDecorator/BusyDecorator.cs b/QuickLook/Controls/BusyDecorator/BusyDecorator.cs index 7d4b637..bbf07ca 100644 --- a/QuickLook/Controls/BusyDecorator/BusyDecorator.cs +++ b/QuickLook/Controls/BusyDecorator/BusyDecorator.cs @@ -130,11 +130,6 @@ namespace QuickLook.Controls.BusyDecorator Math.Max(ret.Height, _busyHost.RenderSize.Height)); } - ~BusyDecorator() - { - Dispose(); - } - #region IsBusyIndicatorShowing Property /// diff --git a/QuickLook/GlobalKeyboardHook.cs b/QuickLook/GlobalKeyboardHook.cs index a4f02a0..638391d 100644 --- a/QuickLook/GlobalKeyboardHook.cs +++ b/QuickLook/GlobalKeyboardHook.cs @@ -48,11 +48,6 @@ namespace QuickLook internal event KeyEventHandler KeyDown; internal event KeyEventHandler KeyUp; - ~GlobalKeyboardHook() - { - Dispose(); - } - internal static GlobalKeyboardHook GetInstance() { return _instance ?? (_instance = new GlobalKeyboardHook()); diff --git a/QuickLook/Helpers/Updater.cs b/QuickLook/Helpers/Updater.cs index d5758e1..97d521a 100644 --- a/QuickLook/Helpers/Updater.cs +++ b/QuickLook/Helpers/Updater.cs @@ -85,10 +85,14 @@ namespace QuickLook.Helpers var notes = string.Empty; + var count = 0; foreach (var item in json) { notes += $"# {item["name"]}\r\n\r\n"; notes += item["body"] + "\r\n\r\n"; + + if (count++ > 10) + break; } var changeLogPath = Path.GetTempFileName() + ".md"; diff --git a/QuickLook/PipeServerManager.cs b/QuickLook/PipeServerManager.cs index 15a3933..f86bee1 100644 --- a/QuickLook/PipeServerManager.cs +++ b/QuickLook/PipeServerManager.cs @@ -152,11 +152,6 @@ namespace QuickLook } } - ~PipeServerManager() - { - Dispose(); - } - public static PipeServerManager GetInstance() { return _instance ?? (_instance = new PipeServerManager());