From cf2948420809e591d23d73aa2aae4c59d44a8f19 Mon Sep 17 00:00:00 2001 From: Leon Pascal Thierschmidt Date: Thu, 9 Apr 2020 01:03:56 +0200 Subject: [PATCH 1/3] Changed logic so that plugin only supports ".url"s that contain urls with protocol http or https Ref: QL-Win#625 --- QuickLook.Plugin/QuickLook.Plugin.HtmlViewer/Plugin.cs | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/QuickLook.Plugin/QuickLook.Plugin.HtmlViewer/Plugin.cs b/QuickLook.Plugin/QuickLook.Plugin.HtmlViewer/Plugin.cs index 6acc768..8d6cade 100644 --- a/QuickLook.Plugin/QuickLook.Plugin.HtmlViewer/Plugin.cs +++ b/QuickLook.Plugin/QuickLook.Plugin.HtmlViewer/Plugin.cs @@ -26,7 +26,9 @@ namespace QuickLook.Plugin.HtmlViewer { public class Plugin : IViewer { - private static readonly string[] Extensions = { ".mht", ".mhtml", ".htm", ".html", ".svg", ".url" }; + // TODO: Handle urls based on protocol + private static readonly string[] Extensions = { ".mht", ".mhtml", ".htm", ".html", ".svg" }; + private static readonly string[] SupportedProtocols = { "http", "https" }; private WebpagePanel _panel; @@ -39,7 +41,7 @@ namespace QuickLook.Plugin.HtmlViewer public bool CanHandle(string path) { - return !Directory.Exists(path) && Extensions.Any(path.ToLower().EndsWith); + return !Directory.Exists(path) && (Extensions.Any(path.ToLower().EndsWith) || (path.ToLower().EndsWith(".url") && SupportedProtocols.Contains(Helper.GetUrlPath(path).Split(':')[0].ToLower()))); } public void Prepare(string path, ContextObject context) From 8e801d9fa48aa05b578f0167f3f289cde0530172 Mon Sep 17 00:00:00 2001 From: Leon Pascal Thierschmidt Date: Thu, 9 Apr 2020 01:13:21 +0200 Subject: [PATCH 2/3] Remove TODO --- QuickLook.Plugin/QuickLook.Plugin.HtmlViewer/Plugin.cs | 1 - 1 file changed, 1 deletion(-) diff --git a/QuickLook.Plugin/QuickLook.Plugin.HtmlViewer/Plugin.cs b/QuickLook.Plugin/QuickLook.Plugin.HtmlViewer/Plugin.cs index 8d6cade..5f8d2fd 100644 --- a/QuickLook.Plugin/QuickLook.Plugin.HtmlViewer/Plugin.cs +++ b/QuickLook.Plugin/QuickLook.Plugin.HtmlViewer/Plugin.cs @@ -26,7 +26,6 @@ namespace QuickLook.Plugin.HtmlViewer { public class Plugin : IViewer { - // TODO: Handle urls based on protocol private static readonly string[] Extensions = { ".mht", ".mhtml", ".htm", ".html", ".svg" }; private static readonly string[] SupportedProtocols = { "http", "https" }; From 25e6d6b9cb4bb82e6b6ddf553b1eb3aa16d83bde Mon Sep 17 00:00:00 2001 From: Leon Pascal Thierschmidt Date: Sat, 2 May 2020 16:18:15 +0200 Subject: [PATCH 3/3] Fixed merging-error Removed `.url` from `private static readonly string[] Extensions` --- QuickLook.Plugin/QuickLook.Plugin.HtmlViewer/Plugin.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/QuickLook.Plugin/QuickLook.Plugin.HtmlViewer/Plugin.cs b/QuickLook.Plugin/QuickLook.Plugin.HtmlViewer/Plugin.cs index 784fa8e..520e03e 100644 --- a/QuickLook.Plugin/QuickLook.Plugin.HtmlViewer/Plugin.cs +++ b/QuickLook.Plugin/QuickLook.Plugin.HtmlViewer/Plugin.cs @@ -1,4 +1,4 @@ -// Copyright © 2017 Paddy Xu +// Copyright © 2017 Paddy Xu // // This file is part of QuickLook program. // @@ -26,7 +26,7 @@ namespace QuickLook.Plugin.HtmlViewer { public class Plugin : IViewer { - private static readonly string[] Extensions = { ".mht", ".mhtml", ".htm", ".html", ".url" }; + private static readonly string[] Extensions = { ".mht", ".mhtml", ".htm", ".html" }; private static readonly string[] SupportedProtocols = { "http", "https" }; private WebpagePanel _panel;