windows/QuickLook
1
0
Fork 0
mirror of https://github.com/QL-Win/QuickLook.git synced 2025-09-15 12:49:13 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

fix memory leak and set object to null when switching viewer target

Browse Source
This commit is contained in:
Paddy Xu
2017-05-17 21:55:30 +03:00
parent 410411692e
commit 482325a479
11 changed files with 66 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
QuickLook.Plugin/QuickLook.Plugin.ArchiveViewer/ArchiveInfoPanel.xaml.cs
View File

@@ -127,6 +127,9 @@ namespace QuickLook.Plugin.ArchiveViewer
private string[] GetPathFragments(string path)
{
if (string.IsNullOrEmpty(path))
return new string[0];
var frags = path.Split('\\', '/').Where(f => !string.IsNullOrEmpty(f)).ToArray();
return frags.Select((s, i) => frags.Take(i + 1).Aggregate((a, b) => a + "\\" + b)).ToArray();

19
QuickLook.Plugin/QuickLook.Plugin.ArchiveViewer/Plugin.cs
View File

@@ -16,18 +16,18 @@ namespace QuickLook.Plugin.ArchiveViewer
if (Directory.Exists(path))
return false;
using (var stream = File.OpenRead(path))
switch (Path.GetExtension(path).ToLower())
{
try
{
ArchiveFactory.Open(stream);
}
catch (Exception)
{
case ".zip":
case ".rar":
case ".7z":
case ".gz":
case ".tar":
return true;
default:
return false;
}
}
return true;
}
public void Prepare(string path, ContextObject context)
@@ -50,6 +50,7 @@ namespace QuickLook.Plugin.ArchiveViewer
GC.SuppressFinalize(this);
_panel?.Dispose();
_panel = null;
}
~Plugin()

1
QuickLook.Plugin/QuickLook.Plugin.HtmlViewer/Plugin.cs
View File

@@ -48,6 +48,7 @@ namespace QuickLook.Plugin.HtmlViewer
GC.SuppressFinalize(this);
_panel?.Dispose();
_panel = null;
}
~Plugin()

1
QuickLook.Plugin/QuickLook.Plugin.ImageViewer/Plugin.cs
View File

@@ -52,6 +52,7 @@ namespace QuickLook.Plugin.ImageViewer
public void Cleanup()
{
_ip = null;
}
}
}

1
QuickLook.Plugin/QuickLook.Plugin.MarkdownViewer/Plugin.cs
View File

@@ -49,6 +49,7 @@ namespace QuickLook.Plugin.MarkdownViewer
GC.SuppressFinalize(this);
_panel?.Dispose();
_panel = null;
}
~Plugin()

1
QuickLook.Plugin/QuickLook.Plugin.TextViewer/Plugin.cs
View File

@@ -58,6 +58,7 @@ namespace QuickLook.Plugin.TextViewer
public void Cleanup()
{
_tvp = null;
}
}
}

1
QuickLook.Plugin/QuickLook.Plugin.VideoViewer/PluginInterface.cs
View File

@@ -55,6 +55,7 @@ namespace QuickLook.Plugin.VideoViewer
public void Cleanup()
{
_vp?.Dispose();
_vp = null;
}
}
}

8
QuickLook.Plugin/QuickLook.Plugin.VideoViewer/ViewerPanel.xaml.cs
View File

@@ -1,5 +1,6 @@
using System;
using System.ComponentModel;
using System.Diagnostics;
using System.Windows.Controls;
using System.Windows.Input;
using FontAwesome.WPF;
@@ -51,11 +52,16 @@ namespace QuickLook.Plugin.VideoViewer
: FontAwesomeIcon.PlayCircleOutline;
}
[DebuggerNonUserCode]
private void ShowErrorNotification(object sender, MediaErrorRoutedEventArgs e)
{
_context.ShowNotification("", "An error occurred while loading the video.");
mediaElement.Stop();
_context.ShowNotification("", "An error occurred while loading the video.");
Dispose();
throw new Exception("fallback to default viewer.");
}
public void LoadAndPlay(string path)