chore: code review

2025-10-20 10:44:59 +00:00 · 2020-03-01 20:29:03 +08:00
parent 5d3333ca8c
commit 65bdc75ca6
4 changed files with 7 additions and 13 deletions
--- a/src/index-bar/index.js
+++ b/src/index-bar/index.js
@@ -76,7 +76,6 @@ export default createComponent({
    highlightStyle() {
      const { highlightColor } = this;
      if (highlightColor) {
-        /* istanbul ignore else */
        return {
          color: highlightColor,
        };
@@ -135,17 +134,14 @@ export default createComponent({
    },

    getScrollerRect() {
-      const { scroller } = this;
-      let scrollerRect = {
+      if (this.scroller.getBoundingClientRect) {
+        return this.scroller.getBoundingClientRect();
+      }
+
+      return {
        top: 0,
        left: 0,
      };
-
-      if (scroller.getBoundingClientRect) {
-        scrollerRect = scroller.getBoundingClientRect();
-      }
-
-      return scrollerRect;
    },

    getElementTop(ele, scrollerRect) {