ui/vant
1
0
Fork 0
mirror of https://github.com/youzan/vant.git synced 2025-10-20 18:54:24 +00:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

[Improvement] optimize passive events (#478)

Browse Source
This commit is contained in:
neverland
2017-12-25 15:58:44 +08:00
committed by GitHub
parent 2d2a368e2c
commit 30f22b28ed
5 changed files with 51 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
packages/waterfall/directive.js
View File

@@ -1,4 +1,5 @@
import Utils from '../utils/scroll';
import { on, off } from '../utils/event';
const CONTEXT = '@@Waterfall';
const OFFSET = 300;
@@ -14,8 +15,8 @@ function doBindEvent() {
this.scrollEventListener = Utils.debounce(handleScrollEvent.bind(this), 200);
this.scrollEventTarget = Utils.getScrollEventTarget(this.el);
var disabledExpr = this.el.getAttribute('waterfall-disabled');
var disabled = false;
const disabledExpr = this.el.getAttribute('waterfall-disabled');
let disabled = false;
if (disabledExpr) {
this.vm.$watch(disabledExpr, (value) => {
this.disabled = value;
@@ -25,10 +26,10 @@ function doBindEvent() {
}
this.disabled = disabled;
var offset = this.el.getAttribute('waterfall-offset');
const offset = this.el.getAttribute('waterfall-offset');
this.offset = Number(offset) || OFFSET;
this.scrollEventTarget.addEventListener('scroll', this.scrollEventListener);
on(this.scrollEventTarget, 'scroll', this.scrollEventListener, true);
this.scrollEventListener();
}
@@ -119,7 +120,9 @@ export default function(type) {
unbind(el) {
const context = el[CONTEXT];
context.scrollEventTarget && context.scrollEventTarget.removeEventListener('scroll', context.scrollEventListener);
if (context.scrollEventTarget) {
off(context.scrollEventTarget, 'scroll', context.scrollEventListener);
}
}
};
};