mirror of
https://github.com/percona/percona-toolkit.git
synced 2025-09-03 11:05:48 +00:00

* PT-2160 - Fix tests for pt-online-schema-change Re-enabled tests after MySQL bug #89441 fix in 8.0.14 and later Updated t/pt-online-schema-change/samples/basic_no_fks_innodb.sql, so its unique index is NOT NULL Added synchonizations when tests are waiting for too long due to slave catch up Added innodb_directories option for t/pt-online-schema-change/pt-244.t * PT-2160 - Fix tests for pt-online-schema-change PT-2048 - pt-osc spans excessive connections to the replica when executing in the source t/pt-online-schema-change/slave_lag.t was failing due to PT-2048. I added code that reuses already created connections when checks for slave in the wait loop. It fixes slave_lag.t too. I also added that prints more detailed error when fails to connect to the replica. * PT-2160 - Fix tests for pt-online-schema-change Modified t/pt-online-schema-change/slave_lag.t, so it runs and clean ups faster. * PT-2160 - Fix tests for pt-online-schema-change Modified t/pt-online-schema-change/pt-1455.t, so it runs and clean ups faster. * PT-2160 - Fix tests for pt-online-schema-change Fixed search for HASH and BTREE keys broken by fix for PT-2123 Updated modules for pt-archiver Fixed die message for sandbox/start-sandbox Added global_grants table to list of exceptions for the ok function in lib/Sandbox.pm Added wait_for_slaves to bugs.t, so changes on the source are copied to replica before pt-osc starts working Updated PXC tests Added wait_for_slaves to pt-1455.t Fixed regular expression in pt-229.t, so it works with both 5.x and 8.0 versions Added innodb_directories option for pt-244.t, so it does not fail on 8.0 Modified slave_lag.t, so it is more stable and slow enough, so pt-osc can print message about delayed replicas
135 lines
4.8 KiB
Perl
135 lines
4.8 KiB
Perl
#!/usr/bin/env perl
|
|
|
|
BEGIN {
|
|
die "The PERCONA_TOOLKIT_BRANCH environment variable is not set.\n"
|
|
unless $ENV{PERCONA_TOOLKIT_BRANCH} && -d $ENV{PERCONA_TOOLKIT_BRANCH};
|
|
unshift @INC, "$ENV{PERCONA_TOOLKIT_BRANCH}/lib";
|
|
};
|
|
|
|
use strict;
|
|
use warnings FATAL => 'all';
|
|
use English qw(-no_match_vars);
|
|
use Test::More;
|
|
|
|
use Data::Dumper;
|
|
use PerconaTest;
|
|
use Sandbox;
|
|
|
|
require "$trunk/bin/pt-online-schema-change";
|
|
|
|
my $dp = new DSNParser(opts=>$dsn_opts);
|
|
my $sb = new Sandbox(basedir => '/tmp', DSNParser => $dp);
|
|
my $master_dbh = $sb->get_dbh_for('master');
|
|
|
|
my $vp = VersionParser->new($master_dbh);
|
|
|
|
if ($vp->cmp('8.0') > -1 && $vp->cmp('8.0.14') < 0 && $vp->flavor() !~ m/maria/i) {
|
|
plan skip_all => 'Cannot run this test under the current MySQL version';
|
|
}
|
|
|
|
if ( !$master_dbh ) {
|
|
plan skip_all => 'Cannot connect to sandbox master';
|
|
}
|
|
|
|
# The sandbox servers run with lock_wait_timeout=3 and it's not dynamic
|
|
# so we need to specify --set-vars innodb_lock_wait_timeout-3 else the
|
|
# tool will die.
|
|
my $master_dsn = 'h=127.1,P=12345,u=msandbox,p=msandbox';
|
|
my @args = (qw(--set-vars innodb_lock_wait_timeout=3 --alter-foreign-keys-method rebuild_constraints));
|
|
my $output;
|
|
my $exit_status;
|
|
my $sample = "t/pt-online-schema-change/samples/";
|
|
|
|
# ############################################################################
|
|
# https://bugs.launchpad.net/percona-toolkit/+bug/1215587
|
|
# Adding _ to constraints can create issues with constraint name length
|
|
# ############################################################################
|
|
|
|
$sb->load_file('master', "$sample/bug-1215587.sql");
|
|
|
|
# run once: we expect constraint names to be prefixed with one underscore
|
|
# if they havre't one, and to remove 2 if they have 2
|
|
($output, $exit_status) = full_output(
|
|
sub { pt_online_schema_change::main(@args,
|
|
"$master_dsn,D=bug1215587,t=Table1",
|
|
"--alter", "ENGINE=InnoDB",
|
|
qw(--execute)) },
|
|
);
|
|
|
|
my $query = <<__SQL;
|
|
SELECT TABLE_NAME, CONSTRAINT_NAME
|
|
FROM information_schema.KEY_COLUMN_USAGE
|
|
WHERE table_schema='bug1215587'
|
|
and (TABLE_NAME='Table1' OR TABLE_NAME='Table2')
|
|
and CONSTRAINT_NAME LIKE '%fkey%'
|
|
ORDER BY TABLE_NAME, CONSTRAINT_NAME
|
|
__SQL
|
|
|
|
my $constraints = $master_dbh->selectall_arrayref($query);
|
|
# why we need to sort? Depending on the MySQL version and the characters set, the ORDER BY clause
|
|
# in the query will return different values so, it is better to rely on our own sorted results.
|
|
my @sorted_constraints = sort { @$a[0].@$a[1] cmp @$b[0].@$b[1] } @$constraints;
|
|
|
|
is_deeply(
|
|
\@sorted_constraints,
|
|
[
|
|
['Table1', '__fkey1a'],
|
|
['Table1', '_fkey1b'],
|
|
['Table2', '__fkey2b'],
|
|
['Table2', '_fkey2a'],
|
|
],
|
|
"First run adds or removes underscore from constraint names, accordingly"
|
|
);
|
|
|
|
# run second time: we expect constraint names to be prefixed with one underscore
|
|
# if they havre't one, and to remove 2 if they have 2
|
|
($output, $exit_status) = full_output(
|
|
sub { pt_online_schema_change::main(@args,
|
|
"$master_dsn,D=bug1215587,t=Table1",
|
|
"--alter", "ENGINE=InnoDB",
|
|
qw(--execute)) },
|
|
);
|
|
|
|
$constraints = $master_dbh->selectall_arrayref("SELECT TABLE_NAME, CONSTRAINT_NAME FROM information_schema.KEY_COLUMN_USAGE WHERE table_schema='bug1215587' and (TABLE_NAME='Table1' OR TABLE_NAME='Table2') and CONSTRAINT_NAME LIKE '%fkey%' ORDER BY TABLE_NAME, CONSTRAINT_NAME");
|
|
@sorted_constraints = sort { @$a[0].@$a[1] cmp @$b[0].@$b[1] } @$constraints; # read above why we need to sort
|
|
|
|
is_deeply(
|
|
\@sorted_constraints,
|
|
[
|
|
['Table1', '__fkey1b'],
|
|
['Table1', 'fkey1a'],
|
|
['Table2', '__fkey2a'],
|
|
['Table2', 'fkey2b'],
|
|
],
|
|
"Second run adds or removes underscore from constraint names, accordingly"
|
|
);
|
|
|
|
# run third time: we expect constraints to be the same as we started (toggled back)
|
|
($output, $exit_status) = full_output(
|
|
sub { pt_online_schema_change::main(@args,
|
|
"$master_dsn,D=bug1215587,t=Table1",
|
|
"--alter", "ENGINE=InnoDB",
|
|
qw(--execute)) },
|
|
);
|
|
|
|
$constraints = $master_dbh->selectall_arrayref("SELECT TABLE_NAME, CONSTRAINT_NAME FROM information_schema.KEY_COLUMN_USAGE WHERE table_schema='bug1215587' and (TABLE_NAME='Table1' OR TABLE_NAME='Table2') and CONSTRAINT_NAME LIKE '%fkey%' ORDER BY TABLE_NAME, CONSTRAINT_NAME");
|
|
@sorted_constraints = sort { @$a[0].@$a[1] cmp @$b[0].@$b[1] } @$constraints; # read above why we need to sort
|
|
|
|
is_deeply(
|
|
\@sorted_constraints,
|
|
[
|
|
['Table1', '_fkey1a'],
|
|
['Table1', 'fkey1b'],
|
|
['Table2', '_fkey2b'],
|
|
['Table2', 'fkey2a'],
|
|
],
|
|
"Third run toggles constraint names back to how they were"
|
|
);
|
|
|
|
# #############################################################################
|
|
# Done.
|
|
# #############################################################################
|
|
$sb->wipe_clean($master_dbh);
|
|
ok($sb->ok(), "Sandbox servers") or BAIL_OUT(__FILE__ . " broke the sandbox");
|
|
done_testing;
|