Brian Fraser 76a010abee
Fix for 917770: Use of uninitialized value in substitution (s///) at pt-config-diff line 1996 ...
This turned out to be two bugs mangled into one.
First, _parse_varvals can deal with (var, undef), but not with (undef).
This is a problem because two of the trhee spots that call
_parse_varvals can return undef because of this:
map { $_ =~ m/^([^=]+)(?:=(.*))?$/ }
grep { $_ !~ m/^\s*#/ } # no # comment lines
split("\n", $mysqld_section)
The problem is twofold. First, we are not skipping empty or
whitespace-only lines. That means that the map will fail,
and pass an undef to _parse_varvals. So this ended up in
a triple fix: Make _parse_varvals deal with a sole undef,
skip empty/whitespace lines, and change that map to
map { $_ =~ m/^([^=]+)(?:=(.*))?$/ ? ($1, $2) : () }
so even if the regex fails in the future, no sole undef
will be passed down the chain.
2012-11-30 16:17:45 -03:00
2012-10-24 12:43:26 -06:00
2012-11-19 18:41:34 +00:00
2012-01-19 12:46:56 -07:00
2012-01-19 12:46:56 -07:00
2012-01-19 12:46:56 -07:00
2012-08-27 15:04:51 -03:00
2012-08-15 17:28:52 -03:00
2012-07-17 16:47:33 -06:00
2012-08-20 14:21:07 -06:00
2012-07-17 16:47:33 -06:00
2012-02-20 11:37:34 -07:00
2012-11-08 17:47:00 -03:00
2012-10-30 16:57:06 -06:00
2012-05-10 14:06:52 -07:00
2012-06-05 12:28:36 -03:00
2012-06-05 12:28:36 -03:00
2012-08-10 15:36:34 -03:00
2012-02-01 19:12:03 -03:00
2012-10-17 19:19:44 -03:00
2012-08-15 16:24:19 -06:00
2012-07-11 15:46:58 -06:00
2012-01-19 12:46:56 -07:00
2012-01-19 12:46:56 -07:00
2012-01-19 12:46:56 -07:00
2012-01-19 12:46:56 -07:00
2012-01-19 12:46:56 -07:00
2012-09-24 16:24:36 -03:00
2012-01-19 12:46:56 -07:00
2012-06-11 12:54:26 -04:00
2012-06-04 10:08:06 -04:00
2012-01-19 12:46:56 -07:00
2012-01-19 12:46:56 -07:00
2012-08-02 10:57:36 -06:00
2012-01-19 12:46:56 -07:00
2012-01-19 12:46:56 -07:00
2012-10-31 12:04:30 -03:00
2012-01-19 12:46:56 -07:00
2012-01-19 12:46:56 -07:00
2012-10-19 16:13:13 -06:00
2012-11-30 16:17:45 -03:00
2012-01-19 12:46:56 -07:00
2012-06-03 17:20:12 -04:00
2012-05-25 15:27:23 -06:00
2012-07-26 16:44:24 -06:00
2012-03-29 15:23:38 -06:00
2012-10-30 12:42:42 -03:00
2012-01-19 12:46:56 -07:00
2012-11-08 06:12:29 -03:00
2012-01-19 12:46:56 -07:00
2012-11-06 11:35:49 -03:00
2012-05-23 16:07:05 -06:00
2012-01-19 12:46:56 -07:00
2012-08-01 18:43:03 -03:00
2012-01-19 12:46:56 -07:00
2012-06-03 17:20:12 -04:00
2012-04-03 11:03:17 -06:00
2012-08-16 19:18:14 -03:00
2012-08-06 11:37:51 -03:00
2012-01-19 12:46:56 -07:00
2012-03-26 16:40:46 -06:00
2012-11-10 09:54:39 -03:00
2012-06-28 15:04:10 -06:00
2012-08-15 13:28:14 -06:00
2012-01-19 12:46:56 -07:00
2012-08-22 08:20:59 -06:00
2012-01-19 12:46:56 -07:00
2012-11-16 11:36:59 -03:00
2012-01-19 12:46:56 -07:00
2012-01-19 12:46:56 -07:00
2012-11-21 17:04:42 -03:00
2012-03-30 15:47:37 -03:00
2012-10-30 19:02:03 -03:00
2012-01-19 12:46:56 -07:00
2012-01-19 12:46:56 -07:00
2012-03-29 22:16:53 -04:00
2012-04-03 11:03:17 -06:00
2012-01-19 12:46:56 -07:00
2012-07-19 13:19:26 -03:00
2012-08-24 19:50:34 -03:00
2012-06-11 07:55:23 -04:00
2012-11-09 13:48:17 -03:00
2012-06-07 14:53:47 -04:00
2012-08-24 19:58:16 -03:00
2012-01-19 12:46:56 -07:00
2012-08-27 10:42:39 -06:00
2012-01-19 12:46:56 -07:00
2012-06-07 14:53:47 -04:00
2012-01-19 12:46:56 -07:00
2012-07-30 11:52:53 -03:00
2012-01-19 12:46:56 -07:00
2012-01-19 12:46:56 -07:00
2012-02-07 11:07:41 -03:00
2012-08-21 09:24:19 -06:00
2012-07-30 11:44:28 -03:00
2012-09-20 10:54:55 -03:00
2012-07-19 12:12:28 -03:00
2012-01-19 12:46:56 -07:00
Brian Fraser
76a010abee