mirror of
https://github.com/percona/percona-toolkit.git
synced 2025-09-10 13:11:32 +00:00
01daf0030e
In the case we are trying to migrate a table with no PK nor an unique key, pt-archiver was failing to select the correct rows for deletion. This fix implemented here is to add ALL columns in the WHERE clause of the DELETE command. This way, we are deleting only the exact same row we just migrated but using columns instead of an index.
87 lines
2.5 KiB
Perl
87 lines
2.5 KiB
Perl
#!/usr/bin/env perl
|
|
|
|
BEGIN {
|
|
die "The PERCONA_TOOLKIT_BRANCH environment variable is not set.\n"
|
|
unless $ENV{PERCONA_TOOLKIT_BRANCH} && -d $ENV{PERCONA_TOOLKIT_BRANCH};
|
|
unshift @INC, "$ENV{PERCONA_TOOLKIT_BRANCH}/lib";
|
|
};
|
|
|
|
use strict;
|
|
use warnings FATAL => 'all';
|
|
use English qw(-no_match_vars);
|
|
use Test::More;
|
|
|
|
use PerconaTest;
|
|
use Sandbox;
|
|
require "$trunk/bin/pt-archiver";
|
|
|
|
my $dp = new DSNParser(opts=>$dsn_opts);
|
|
my $sb = new Sandbox(basedir => '/tmp', DSNParser => $dp);
|
|
my $dbh = $sb->get_dbh_for('master');
|
|
|
|
if ( !$dbh ) {
|
|
plan skip_all => 'Cannot connect to sandbox master';
|
|
}
|
|
else {
|
|
plan tests => 4;
|
|
}
|
|
|
|
my $output;
|
|
my $rows;
|
|
my $cnf = "/tmp/12345/my.sandbox.cnf";
|
|
|
|
$sb->create_dbs($dbh, ['test']);
|
|
|
|
# #############################################################################
|
|
# Issue 1166: Don't LIMIT 1 for unique indexes
|
|
# #############################################################################
|
|
$sb->load_file('master', 't/pt-archiver/samples/issue_131.sql');
|
|
$sb->load_file('master', 't/pt-archiver/samples/issue_1166.sql');
|
|
|
|
$output = output(
|
|
sub { pt_archiver::main(qw(--where 1=1 --dry-run --source),
|
|
"F=$cnf,D=test,t=issue_131_src", qw(--dest t=issue_131_dst)) }
|
|
);
|
|
like(
|
|
$output,
|
|
qr/DELETE FROM `test`\.`issue_131_src` WHERE \(`id` = \?\)$/m,
|
|
"No LIMIT 1 with unique index (issue 1166)"
|
|
);
|
|
|
|
# With non-unique index LIMIT 1 should appear.
|
|
|
|
$output = output(
|
|
sub { pt_archiver::main(qw(--where 1=1 --dry-run --source),
|
|
"F=$cnf,D=test,t=issue_1166", "--purge") }
|
|
);
|
|
like(
|
|
$output,
|
|
qr/LIMIT 1$/m,
|
|
"LIMIT 1 with non-unique index (issue 1166)"
|
|
);
|
|
|
|
|
|
# #############################################################################
|
|
# This issue is related:
|
|
# Issue 1170: Allow bulk delete without LIMIT
|
|
# #############################################################################
|
|
$sb->load_file('master', 't/pt-archiver/samples/issue_131.sql');
|
|
|
|
$output = output(
|
|
sub { pt_archiver::main(qw(--where 1=1 --dry-run --source),
|
|
"F=$cnf,D=test,t=issue_131_src", qw(--bulk-delete --purge),
|
|
qw(--no-bulk-delete-limit --limit 3)) }
|
|
);
|
|
like(
|
|
$output,
|
|
qr/DELETE FROM `test`\.`issue_131_src` WHERE \(\(\(`id` >= \?\)\)\) AND \(\(\(`id` <= \?\)\)\) AND \(1=1\)$/m,
|
|
"No LIMIT with bulk delete (issue 1170)"
|
|
);
|
|
|
|
# #############################################################################
|
|
# Done.
|
|
# #############################################################################
|
|
$sb->wipe_clean($dbh);
|
|
ok($sb->ok(), "Sandbox servers") or BAIL_OUT(__FILE__ . " broke the sandbox");
|
|
exit;
|