#!/usr/bin/env perl BEGIN { die "The PERCONA_TOOLKIT_BRANCH environment variable is not set.\n" unless $ENV{PERCONA_TOOLKIT_BRANCH} && -d $ENV{PERCONA_TOOLKIT_BRANCH}; unshift @INC, "$ENV{PERCONA_TOOLKIT_BRANCH}/lib"; }; use strict; use warnings FATAL => 'all'; use English qw(-no_match_vars); use Test::More; use Data::Dumper; use PerconaTest; use Sandbox; use SqlModes; require "$trunk/bin/pt-online-schema-change"; my $dp = new DSNParser(opts=>$dsn_opts); my $sb = new Sandbox(basedir => '/tmp', DSNParser => $dp); my $source_dbh = $sb->get_dbh_for('source'); my $replica_dbh = $sb->get_dbh_for('replica1'); if ( !$source_dbh ) { plan skip_all => 'Cannot connect to sandbox source'; } elsif ( !$replica_dbh ) { plan skip_all => 'Cannot connect to sandbox replica1'; } # The sandbox servers run with lock_wait_timeout=3 and it's not dynamic # so we need to specify --set-vars innodb_lock_wait_timeout=3 else the # tool will die. my $source_dsn = 'h=127.1,P=12345,u=msandbox,p=msandbox'; my @args = (qw(--set-vars innodb_lock_wait_timeout=3)); my $output; my $exit_status; my $sample = "t/pt-online-schema-change/samples/"; # ############################################################################ # https://bugs.launchpad.net/percona-toolkit/+bug/1336734 # pt-online-schema-change 2.2.17 adds --null-to-not-null feature # ############################################################################ $sb->load_file('source', "$sample/bug-1336734.sql"); ($output, $exit_status) = full_output( sub { pt_online_schema_change::main(@args, "$source_dsn,D=test,t=lp1336734", "--execute", "--null-to-not-null", # notice we are not using a DEFAULT value, to also # test if the "default default" value for datatype # is used "--alter", "MODIFY COLUMN name VARCHAR(20) NOT NULL", qw(--chunk-size 2 --print)) }, ); my $test_rows = $source_dbh->selectall_arrayref("SELECT id, name FROM test.lp1336734 ORDER BY id"); ok (!$exit_status, "--null-to-not-null exit status = 0" ); is_deeply( $test_rows, [ [ '1', 'curly' ], [ '2', 'larry' ], [ '3', '' ], [ '4', 'moe' ] ], "--null-to-not-null default value good" ); # ############################################################################ # https://bugs.launchpad.net/percona-toolkit/+bug/994002 # pt-online-schema-change 2.1.1 doesn't choose the PRIMARY KEY # ############################################################################ $sb->load_file('source', "$sample/pk-bug-994002.sql"); ($output, $exit_status) = full_output( sub { pt_online_schema_change::main(@args, "$source_dsn,D=test,t=t", "--alter", "add column (foo int)", qw(--chunk-size 2 --dry-run --print)) }, ); # Must chunk the table to detect the next test correctly. like( $output, qr/next chunk boundary/, "Bug 994002: chunks the table" ); unlike( $output, qr/FORCE INDEX\(`guest_language`\)/, "Bug 994002: doesn't choose non-PK" ); # ############################################################################ # https://bugs.launchpad.net/percona-toolkit/+bug/1002448 # ############################################################################ $sb->load_file('source', "$sample/bug-1002448.sql"); ($output, $exit_status) = full_output( sub { pt_online_schema_change::main(@args, "$source_dsn,D=test1002448,t=table_name", "--alter", "add column (foo int)", qw(--chunk-size 2 --dry-run --print)) }, ); unlike( $output, qr/\QThe new table `test1002448`.`_table_name_new` does not have a PRIMARY KEY or a unique index which is required for the DELETE trigger/, "Bug 1002448: mistakenly uses indexes instead of keys" ); # ############################################################################ # https://bugs.launchpad.net/percona-toolkit/+bug/1003315 # ############################################################################ $sb->load_file('source', "$sample/bug-1003315.sql"); # Have to use full_output here, because the error message may happen during # cleanup, and so won't be caught by output(). ($output, $exit_status) = full_output( sub { pt_online_schema_change::main(@args, "$source_dsn,D=test1003315,t=A", "--alter", "ENGINE=InnoDB", "--alter-foreign-keys-method", "auto", "--dry-run", qw(--chunk-size 2 --dry-run --print)) }, ); is( $exit_status, 0, "Bug 1003315: Correct exit value for a dry run" ); unlike( $output, qr/\QError updating foreign key constraints: Invalid --alter-foreign-keys-method:/, "Bug 1003315: No error when combining --alter-foreign-keys-method auto and --dry-run" ); like( $output, qr/\QNot updating foreign key constraints because this is a dry run./, "Bug 1003315: But now we do get an explanation from --dry-run" ); # ############################################################################ # This fakes the conditions to trigger the chunk index error # ############################################################################ { my $o = new OptionParser(file => "$trunk/bin/pt-table-checksum"); $o->get_specs(); $o->set('check-plan', 1); # check-plan is true by default no warnings; local *pt_online_schema_change::explain_statement = sub { return { key => 'some_key' } }; { package PerconaTest::Fake::NibbleIterator; sub AUTOLOAD { our $AUTOLOAD = $AUTOLOAD; return if $AUTOLOAD =~ /one_nibble/; return { lower => [], upper => [] } } } eval { pt_online_schema_change::nibble_is_safe( Cxn => 1, tbl => {qw( db some_db tbl some_table )}, NibbleIterator => bless({}, "PerconaTest::Fake::NibbleIterator"), OptionParser => $o, ); }; like( $EVAL_ERROR, qr/Error copying rows at chunk.*because MySQL chose/, "Dies if MySQL isn't using the chunk index" ); $o->set('quiet', 1); eval { pt_online_schema_change::nibble_is_safe( Cxn => 1, tbl => {qw( db some_db tbl some_table )}, NibbleIterator => bless({}, "PerconaTest::Fake::NibbleIterator"), OptionParser => $o, ); }; like( $EVAL_ERROR, qr/Error copying rows at chunk.*because MySQL chose/, "...even if --quiet was specified", ); } # ############################################################################ # Bug 1041372: ptc-osc and long table names # https://bugs.launchpad.net/percona-toolkit/+bug/1041372 # ############################################################################ my $orig_tbl = 'very_very_very_very_very_very_very_very_very_long_table_name'; $source_dbh->do(q{DROP DATABASE IF EXISTS `bug_1041372`}); $source_dbh->do(q{CREATE DATABASE `bug_1041372`}); for my $i ( 0..4 ) { my $tbl = $orig_tbl . ("a" x $i); $source_dbh->do(qq{create table `bug_1041372`.$tbl (a INT NOT NULL AUTO_INCREMENT PRIMARY KEY )}); $source_dbh->do(qq{insert into `bug_1041372`.$tbl values (1), (2), (3), (4), (5)}); $sb->wait_for_replicas(); ($output) = full_output(sub { pt_online_schema_change::main(@args, '--alter', "ADD COLUMN ptosc INT", '--execute', "$source_dsn,D=bug_1041372,t=$tbl") }); like( $output, qr/\QSuccessfully altered `bug_1041372`.`$tbl`/, "pt-osc works on long table names (length " . length($tbl) . ")" ); } my $triggers = $source_dbh->selectall_arrayref(qq{SHOW TRIGGERS FROM `bug_1041372`}); is_deeply( $triggers, [], "No triggers left for long table names" ) or diag(Dumper($triggers)); $source_dbh->do(q{DROP DATABASE IF EXISTS `bug_1041372`}); # ############################################################################ # https://bugs.launchpad.net/percona-toolkit/+bug/1062324 # pt-online-schema-change sets bad DELETE trigger when changing Primary Key # ############################################################################ $sb->load_file('source', "$sample/del-trg-bug-1062324.sql"); { # pt-osc has no --no-drop-triggers option, so we hijack its sub. no warnings; local *pt_online_schema_change::drop_triggers = sub { return }; # Run the tool but leave the original and new tables as-is, # and leave the triggers. ($output, $exit_status) = full_output( sub { pt_online_schema_change::main(@args, "$source_dsn,D=test,t=t1", "--alter", "drop key 2bpk, drop key c3, drop primary key, drop c1, add primary key (c2, c3(4)), add key (c3(4))", qw(--no-check-alter --execute --no-drop-new-table --no-swap-tables)) }, ); # Since _t1_new no longer has the c1 column, the bug caused this # query to throw "ERROR 1054 (42S22): Unknown column 'test._t1_new.c1' # in 'where clause'". eval { $source_dbh->do("DELETE FROM test.t1 WHERE c1=1"); }; is( $EVAL_ERROR, "", "No delete trigger error after altering PK (bug 1062324)" ) or diag($output); my $row; SKIP: { skip 'Not for PXC' if ( $sb->is_cluster_mode ); # The original row was (c1,c2,c3) = (1,1,1). We deleted where c1=1, # so the row where c2=1 AND c3=1 should no longer exist. my $row = $source_dbh->selectrow_arrayref("SELECT * FROM test._t1_new WHERE c2=1 AND c3=1"); is( $row, undef, "Delete trigger works after altering PK (bug 1062324)" ); } # Another instance of this bug: # https://bugs.launchpad.net/percona-toolkit/+bug/1103672 $sb->load_file('source', "$sample/del-trg-bug-1103672.sql"); ($output, $exit_status) = full_output( sub { pt_online_schema_change::main(@args, "$source_dsn,D=test,t=t1", "--alter", "drop primary key, add column _id int unsigned not null primary key auto_increment FIRST", qw(--no-check-alter --execute --no-drop-new-table --no-swap-tables)) }, ); eval { $source_dbh->do("DELETE FROM test.t1 WHERE id=1"); }; is( $EVAL_ERROR, "", "No delete trigger error after altering PK (bug 1103672)" ) or diag($output); $row = $source_dbh->selectrow_arrayref("SELECT * FROM test._t1_new WHERE id=1"); is( $row, undef, "Delete trigger works after altering PK (bug 1103672)" ); } # ############################################################################# # Something like http://bugs.mysql.com/bug.php?id=45694 means we should not # use LOCK IN SHARE MODE with MySQL 5.0. # ############################################################################# $sb->load_file('source', "$sample/basic_no_fks_innodb.sql"); ($output, $exit_status) = full_output( sub { pt_online_schema_change::main(@args, "$source_dsn,D=pt_osc,t=t", "--alter", "add column (foo int)", qw(--execute --print)) }, ); if ( $sandbox_version eq '5.0' ) { unlike( $output, qr/LOCK IN SHARE MODE/, "No LOCK IN SHARE MODE for MySQL $sandbox_version" ); } else { like( $output, qr/LOCK IN SHARE MODE/, "LOCK IN SHARE MODE for MySQL $sandbox_version", ); } # ############################################################################ # https://bugs.launchpad.net/percona-toolkit/+bug/1171653 # # ############################################################################ $sb->load_file('source', "$sample/utf8_charset_tbl.sql"); ($output, $exit_status) = full_output( sub { pt_online_schema_change::main(@args, "$source_dsn,D=test1171653,t=t", "--alter", "drop column foo", qw(--execute --print)) }, ); my $row = $source_dbh->selectrow_arrayref("SHOW CREATE TABLE test1171653.t"); like( $row->[1], qr/DEFAULT CHARSET=utf8/, "Bug 1171653: table charset is not preserved" ); # ############################################################################# # https://bugs.launchpad.net/percona-toolkit/+bug/1188264 # pt-online-schema-change error copying rows: Undefined subroutine # &pt_online_schema_change::get # ############################################################################# # In exec_nibble() we had: # if ( get('statistics') ) { # $err .= "but further occurrences will be reported " # . "by --statistics when the tool finishes.\n"; # } # which is called when copying rows causes a MySQL warning # for the first time. So to test this code path, we need to # cause a MySQL warning while copying rows. $sb->load_file('source', "$sample/basic_no_fks_innodb.sql"); #This string will be too long after we modify the table so it will cause a warning about the value being truncated in the new table. The other column values are a single character. Note: if STRICT_TRANS or STRICT_ALL is set , an error is raised instead of a warning. STRICT_TRANS is default in 5.7+ $source_dbh->do("INSERT INTO pt_osc.t VALUES (null, 'This string will be too long.', NOW())"); ($output, $exit_status) = full_output( sub { pt_online_schema_change::main(@args, "$source_dsn,D=pt_osc,t=t", "--alter", "modify c varchar(8)", qw(--execute --print)) }, ); is( $exit_status, 0, "Bug 1188264: 0 exit" ); unlike( $output, qr/Undefined subroutine/i, "Bug 1188264: no undefined subroutine" ); like( $output, qr/error 1265/, # Data truncated for column 'c' at row 21 "Bug 1188264: warning about expected MySQL error 1265" ); # ############################################################################# # Issue 1315130 # Failed to detect child tables in other schema, and falsely identified # child tables in own schema # ############################################################################# $sb->load_file('source', "$sample/bug-1315130_cleanup.sql"); $sb->load_file('source', "$sample/bug-1315130.sql"); $output = output( sub { pt_online_schema_change::main(@args, "$source_dsn,D=bug_1315130_a,t=parent_table", '--dry-run', '--alter', "add column c varchar(16)", '--alter-foreign-keys-method', 'auto'), }, ); like( $output, qr/Child tables:\s*`bug_1315130_a`\.`child_table_in_same_schema` \(approx\. 1 rows\)\s*`bug_1315130_b`\.`child_table_in_second_schema` \(approx\. 1 rows\)[^`]*?Will/s, "Identify child tables in other schemas and ignore child tables from same schema referencing same named parent in other schema.", ); # clear databases with their foreign keys $sb->load_file('source', "$sample/bug-1315130_cleanup.sql"); # ############################################################################# # Issue 1315130 # Failed to detect child tables in other schema, and falsely identified # child tables in own schema # ############################################################################# $sb->load_file('source', "$sample/bug-1315130_cleanup.sql"); $sb->load_file('source', "$sample/bug-1315130.sql"); $output = output( sub { pt_online_schema_change::main(@args, "$source_dsn,D=bug_1315130_a,t=parent_table", '--dry-run', '--alter', "add column c varchar(16)", '--alter-foreign-keys-method', 'auto', '--only-same-schema-fks'), }, ); like( $output, qr/Child tables:\s*`bug_1315130_a`\.`child_table_in_same_schema` \(approx\. 1 rows\)[^`]*?Will/s, "Ignore child tables in other schemas.", ); # clear databases with their foreign keys $sb->load_file('source', "$sample/bug-1315130_cleanup.sql"); # ############################################################################# # Issue 1340728 # fails when no index is returned in EXPLAIN, even though --nocheck-plan is set # (happens on HASH indexes) # ############################################################################# $sb->load_file('source', "$sample/bug-1340728_cleanup.sql"); $sb->load_file('source', "$sample/bug-1340728.sql"); # insert a few thousand rows (else test isn't valid) # will make a big string to do an extended insert because it's much faster my $big_insert = 'INSERT INTO bug_1340728.test VALUES '; my $rows = 4999; for (my $i = 0; $i < $rows; $i++) { $big_insert .= "(NULL, 'xx'),"; } $big_insert .= "(NULL, 'xx')"; $source_dbh->do($big_insert); # This big test causes replica lag error on slow boxes $sb->wait_for_replicas(); $output = output( sub { pt_online_schema_change::main(@args, "$source_dsn,D=bug_1340728,t=test", '--execute', '--alter', "ADD COLUMN c INT", '--nocheck-plan', ), }, ); like( $output, qr/Successfully altered/s, "--nocheck-plan ignores plans without index", ); # clear databases $sb->load_file('source', "$sample/bug-1340728_cleanup.sql"); # ############################################################################# # Issue LP 1446928 # Avoids an error trapping loop when --alter option contains an invalid # statement. # If this test fails it might lead to "segmentation fault" or "out of memory" # ############################################################################# ($output, $exit_status) = full_output( sub { pt_online_schema_change::main(@args, "$source_dsn,D=sakila,t=actor", '--execute', '--alter-foreign-keys-method=drop_swap', '--alter', "GIBBERISH", '--nocheck-plan', ), }, ); like( $output, qr/Error altering new table/s, "Bug 1446928: Avoid error trapping loop when --alter is invalid", ); # ############################################################################ # https://bugs.launchpad.net/percona-toolkit/+bug/1506748 # test that setting sql_mode via --set-vars works # ############################################################################ # first we create a table with a valid default date $sb->load_file('source', "$sample/sql_mode_issue_lp1506748.sql"); my $modes = new SqlModes($source_dbh, global =>1); # We clear all modes. In this state, setting an invalid default date generates # an error. $modes->set_mode_string(''); # Now we run the command, but set sql_mode to allow invalid dates for # the session. # While we're at it, test that we can set more than one mode by double escaping # the commas. (must be explained in docs) ($output, $exit_status) = full_output( sub { pt_online_schema_change::main(@args, "$source_dsn,D=test,t=lp1506748", "--execute", "--set-vars", "sql_mode=\'STRICT_ALL_TABLES\\,ALLOW_INVALID_DATES\'", "--alter", "MODIFY COLUMN birthday DATE DEFAULT '1970-02-31'", ) }, ); ok ((!$exit_status && $output =~ /success/i) , "--set-vars sql_mode=\\'a\\\\,b\\' works" ) or diag("[$output][$exit_status]"); $source_dbh->do("drop database test"); $modes->restore_original_modes(); # ############################################################################ # https://bugs.launchpad.net/percona-toolkit/+bug/1526105 # Not necessarily a bug, but more of an enhancement. # ############################################################################ # We will run pt-osc more than 10 times using --no-drop-old-table and expect # no errors. $sb->load_file('source', "$sample/simple_test_table.sql"); my $errors = 0; my $successes = 0; for (1..12) { ($output, $exit_status) = full_output( sub { pt_online_schema_change::main(@args, "$source_dsn,D=test,t=test", "--execute", "--no-drop-old-table", "--alter", "ENGINE=InnoDB", ) }, ); if ($exit_status) { $errors++; } if ( $output =~ /Successfully/i ) { $successes++; } } ok ( (!$errors && $successes == 12), "Issue #1526105 - no-drop-old-table fails after 10 tries" ); $source_dbh->do("DROP DATABASE IF EXISTS test"); $sb->load_file('source', "$sample/bug-1613915.sql"); $output = output( sub { pt_online_schema_change::main(@args, "$source_dsn,D=test,t=o1", '--execute', '--alter', "ADD COLUMN c INT", '--chunk-size', '10', ), }, ); like( $output, qr/Successfully altered/s, "bug-1613915 enum field in primary key", ); $rows = $source_dbh->selectrow_arrayref( "SELECT COUNT(*) FROM test.o1"); is( $rows->[0], 100, "bug-1613915 correct rows count" ) or diag(Dumper($rows)); $source_dbh->do("DROP DATABASE IF EXISTS test"); $sb->load_file('source', "$sample/bug-1613915.sql"); $output = output( sub { pt_online_schema_change::main(@args, "$source_dsn,D=test,t=o1", '--execute', '--alter', "ADD COLUMN c INT COMMENT 'change \"plus\" more than one word'", '--chunk-size', '10', '--no-check-alter', ), }, ); like( $output, qr/Successfully altered/s, "recognize comments", ); $rows = $source_dbh->selectrow_arrayref( "SELECT COUNT(*) FROM test.o1"); is( $rows->[0], 100, "recognize comments fields count" ) or diag(Dumper($rows)); $rows = $source_dbh->selectrow_arrayref("SHOW CREATE TABLE test.o1"); like( $rows->[1], qr/COMMENT 'change "plus" more than one word'/, "recognize comments", ); $source_dbh->do("DROP DATABASE IF EXISTS test"); # Test for --skip-check-replica-lag # Use the same files from previous test because for this test we are going to # run a nonop so, any file will work SKIP: { skip 'Not for PXC' if ( $sb->is_cluster_mode ); $source_dbh->do("DROP DATABASE IF EXISTS test"); $sb->load_file('source', "$sample/bug-1613915.sql"); $output = output( sub { pt_online_schema_change::main(@args, "$source_dsn,D=test,t=o1", '--execute', '--alter', "ENGINE=INNODB", '--skip-check-replica-lag', "h=127.0.0.1,P=".$sb->port_for('replica1'), ), }, ); my $skipping_str = "Skipping.*".$sb->port_for('replica1'); like( $output, qr/$skipping_str/s, "--skip-check-replica-lag", ); # Test for skip-check-replica-lag and empty replica port # Use the same data than the previous test $source_dbh->do("DROP DATABASE IF EXISTS test"); $sb->load_file('source', "$sample/bug-1613915.sql"); $output = output( sub { pt_online_schema_change::main(@args, "$source_dsn,D=test,t=o1", '--execute', '--alter', "ADD COLUMN c INT", '--chunk-size', '10', '--skip-check-replica-lag', "h=127.0.0.1", ), }, stderr => 1, ); unlike( $output, qr/Use of uninitialized value.*/, 'No syntax error if port is missed in --skip-check-replica-lag DSN', ) or diag($output); } # ############################################################################# # Done. # ############################################################################# $sb->wipe_clean($source_dbh); ok($sb->ok(), "Sandbox servers") or BAIL_OUT(__FILE__ . " broke the sandbox"); done_testing;