208 Commits

Author SHA1 Message Date
Yoann La Cancellera
7ecdae6ef6 PT-2102_pt-mysql-summary should support include in config files (#601)
* PT-2102 pt-mysql-summary should support include* in config file

includedir directories are now printed in the order of which they appear in root my.cnf

* PT-2102 pt-mysql-summary should support include* in config file

!include was not supported. Changed 'for' to 'while' to properly
test for '!includedir' and '!include'. Supports extra spaces between
files and !include.

* PT-2102 pt-mysql-summary should support include* in config file

Updates modules, added test case for !include and !includedir
Changed find_my_cnf function to make it try every regexes and only
returned when it find one

* Update pt-mysql-summary

Identation fix as suggested by review

* Update collect_mysql_info.sh

Identation as suggested by review

* PT-2102 pt-mysql-summary should support include* in config file

Fix formatting after review

---------

Co-authored-by: Sveta Smirnova <svetasmirnova@users.noreply.github.com>
2023-02-23 16:00:44 +03:00
Sveta Smirnova
a12d4aecea PT-2150 Fix tests for pt-mysql-summary (#582)
* PT-2150 Fix tests for pt-mysql-summary

- Added POSIX environment to tests, so they do not depend on the local user environment
- Enabled keyring plugin on 8.0
- Fixed encryption information collection in 8.0, see also PT-1588

* PT-2150 Fix tests for pt-mysql-summary

- Added support of the environment variable DISABLE_KEYRING, so we can diable keyring plugin in sandbox/servers/start

* PT-2150 Fix tests for pt-mysql-summary

- Reverted changes in the expected output for tests 006 and 007 made by commit 9190b5e6ac
Because the tool now works properly again and can parse Percona XtraDB Cluster data

* PT-2150 Fix tests for pt-mysql-summary

- Added comment '--read-samples' back to the test cases
2023-02-06 17:11:42 +03:00
グリアンドロ
163376af69 PT-2084 show slave status (#545)
* PT-2084 Readding SHOW SLAVE STATUS outputs to pt-stalk

Before, they were only gathered if version was 5.6 or prior.
Now, they are always gathered, no matter what version.
Since ${mysql_version} is only major.minor, we can't yet add
SHOW REPLICA STATUS, because it starts on 8.0.22 and we have
no way to check that. We will need to wait for 8.1 release.

* PT-2084 Ran update-modules to generate binaries with changes.

* PT-2084 Added checks for preemptive 8.1 SHOW SLAVE STATUS removal.

* PT-2084 Adding test case for SHOW SLAVE STATUS

* Update t/pt-stalk/pt-stalk-replication.t

---------

Co-authored-by: Sveta Smirnova <svetasmirnova@users.noreply.github.com>
2023-02-02 17:08:54 +03:00
Sveta Smirnova
19aa46d1a5 PT-1052 include numa information in pt tool output (#547)
* PT-1052: fix for pt-summary

* Re-added fix from commit 71fae6d117 into proper place: library directory
Added tests for PT-1052 (pt-summary only)

* Fixed tests for pt-summary,
set locale for pt-summary tests, so they are not affected by user environment.
Finished tests for PT-1052

* Added fix for PT-1983 into the proper place: library file

* PT-1052: fix for pt-stalk which now includes numastat data
2022-08-15 15:45:24 +03:00
Sveta Smirnova
ac3843bcb7 Pt 1897 lock information in8.0 in pt stalk (#544)
* PT-1897 pt-stalk on MySQL 8 not collecting lock information

For version prior 8.0 pt-stalk continue using Information Schema INNODB_LOCKS and INNODB_LOCK_WAITS tables for collecting lock information.
For version 8.0 and higher pt-stalk uses tables data_locks and data_lock_waits in Performance Schema

* PT-1897 - Better MariaDB support

We cannot simply compare version number with 8.0 to identify if lock tables are in Performance Schema,
because MariaDB 10.x still have them in the Information Schema.
Therefore added additional flag, indicating which syntax we should use

* Tests for PT-1897
2022-07-25 10:01:14 -03:00
Sveta Smirnova
07ee5eb1bf PS-2033, proof of concept (#540) 2022-07-11 15:51:29 +03:00
Sveta Smirnova
22ed941238 PT-1218: pt-stalk ominous open_tables function (#535)
After discussion change only affects error message that is more user-friendly now.
I also added two tests that check how open_tables function works in both cases:
with number of open tables less tha 1000 and greater than 1000
2022-03-22 09:33:05 -03:00
svetasmirnova
9427c16314 PT-2037 - regression fixes
Re-added fix for PT-1340 that was reverted by fix for PT-1398
2022-01-23 03:55:35 +03:00
svetasmirnova
623fdaec91 PT-2037 - option --system-only for pt-stalk
This commit:
1. Moves all changes to the proper place: lib/bash/collect.sh
2. Refactors pt-stalk so it is more modular
3. Places fix for PT-1734 into the right place: lib/bash/collect.sh
4. Fixes tests for PT-1336
2022-01-22 21:21:05 +03:00
Carlos Salguero
951a333c81 PT-1398 Updated way of getting MySQL PID (#517) 2021-10-01 09:27:20 -03:00
Carlos Salguero
54bee8399a PT-1720 pmp won't error on unknown options 2019-06-27 10:32:23 -03:00
Carlos Salguero
d589034b31 PT-1422 Improved MariaDB support in pt-mysql-summary 2018-07-30 14:45:00 -03:00
Carlos Salguero
f3bca3af41 PT-1554 Fixed library report_mysql_info 2018-05-28 12:07:03 -03:00
Carlos Salguero
e41b68c979 Merge branch '3.0' into PT-1536 2018-05-18 14:30:03 -03:00
Carlos Salguero
e26b567218 PT-1554 Improved jemalloc detection 2018-05-17 14:35:52 -03:00
Carlos Salguero
b6526f6739 PT-1536 Updated samples for mysql-summary tests 2018-05-11 11:58:47 -03:00
Carlos Salguero
a79299bb12 PT-1543 Added --list-encrypted-table to pt-mysql-summary 2018-04-24 14:49:33 -03:00
Carlos Salguero
3eccfcef4d PT-1530 Add support for encryption status to mysql-summary 2018-04-13 15:08:10 -03:00
Carlos Salguero
d2ea011e87 PT-1525 Added support for roles in mysql-summary 2018-04-06 15:10:09 -03:00
Carlos Salguero
f6c01fc5bf PT-1526 Add ndb status to pt-mysql-summary 2018-04-04 09:26:02 -03:00
Carlos Salguero
6e96a1123c Updated bash libraries 2018-04-03 16:37:40 -03:00
Carlos Salguero
fb2a347654 Merge branch 'collect_ndb_status' of https://github.com/fipar/percona-toolkit into fipar-collect_ndb_status 2018-03-19 15:38:17 -03:00
Carlos Salguero
53ce571bf1 PT-633 Added --mysql-only option to pt-stalk 2018-02-12 16:40:30 -03:00
Carlos Salguero
0786db016d PT-218 Added RocksDB status section to pt-stalk 2017-12-13 13:51:08 -03:00
Fernando Ipar
e90b3a77f5 removed accidentally hardcoded file name 2017-10-10 10:52:11 -03:00
Fernando Ipar
5b9ecef04c printing the ndb section 2017-10-10 10:50:26 -03:00
Fernando Ipar
a77b68ed73 Improved formatting of the ndb status a bit 2017-10-10 10:43:58 -03:00
Fernando Ipar
58d1d2c3b4 Added skel for ndb status collector 2017-10-09 22:26:46 -03:00
Carlos Salguero
511c80389f PT-152 Added SHOW SLAVE HOST to pt-mysql-summary 2017-08-29 15:45:13 -03:00
guriandoro
b775701551 Merge branch '3.0' into pt-stalk-collect-prepared-statements-LP1642750
Conflicts:
	bin/pt-stalk
	lib/bash/collect.sh
2017-06-10 11:45:33 -04:00
guriandoro
437d28837b Changes for LP1510809. ps -eaF is captured now.
Modified f argument, for F. From man pages:

" -F     Extra full format.  See the -f option, which -F implies."

The following columns have been added to the output, due to this
change:

SZ   size in physical pages of the core image of the process.
     This includes text, data, and stack space.  Device mappings
     are currently excluded; this is subject to change.

RSS  resident set size, the non-swapped physical memory that a
     task has used (inkiloBytes).

PSR  processor that process is currently assigned to.
2017-04-11 19:15:14 -04:00
Carlos Salguero
fac4be64b4 Merge branch '3.0' into issue-1642754 2017-03-28 14:08:51 -03:00
Carlos Salguero
1926bd60b4 PT-111 Collect MySQL variables 2017-03-28 14:03:40 -03:00
Carlos Salguero
be971eeee5 PT-80 Collect replication slave information 2017-03-27 17:30:06 -03:00
Carlos Salguero
ad73055a5b Changed how we invoke MySQL from pt-stalk 2017-03-22 19:38:09 -03:00
guriandoro
0e5a08342d Merge branch '3.0' into pt-stalk-collect-prepared-statements-LP1642750 2017-03-22 16:34:34 -04:00
Carlos Salguero
759ee9196e Updated collect.sh because of a syntax error 2017-03-22 17:32:14 -03:00
guriandoro
32745039b5 Merge branch '3.0' into pt-stalk-collect-prepared-statements-LP1642750 2017-03-22 16:19:19 -04:00
Carlos Salguero
a117e63e89 Added MySQL version check to stalk ps queries 2017-03-22 12:38:11 -03:00
guriandoro
e8ad42955d PT-90 Adding collect for LP:1642750
pt-stalk will now also collect from P_S.prepared_statements_instances
2017-03-22 10:53:34 -04:00
Carlos Salguero
91ec593da5 Merge pull request #174 from percona/PT-89
PT-89 Now top runs using -bn${OPT_RUN_TIME}
2017-03-21 19:25:30 +02:00
Carlos Salguero
2e64421972 Merge pull request #172 from percona/PT-76
PT-76 Fixed cmd line parsing for lines having #
2017-03-21 19:23:37 +02:00
Carlos Salguero
4a056cf3b0 PT-81 Collect information about locks and transactions using P_S 2017-03-21 13:45:59 -03:00
Carlos Salguero
076864c79e PT-89 Now top runs using -bn${OPT_RUN_TIME} 2017-03-01 13:30:09 -03:00
Carlos Salguero
43a58c4c64 PT-76 Fixed cmd line parsing for lines having # 2017-02-25 13:52:46 -03:00
Carlos Salguero
90e1e9cf1e PT-81 Moved functions to the collect module 2017-02-25 10:41:07 -03:00
frank-cizmich
c3f4705b67 pt-stalk sort transactions - lp1537416 2016-06-09 14:31:19 -03:00
frank-cizmich
377b50144b new var binlog_error_action caused bug in collect module 2016-02-11 17:44:20 -03:00
frank-cizmich
074c1edec5 pt-mysql-summary added ask-pass option 2015-07-28 17:08:58 -03:00
Frank Cizmich
f8c8411297 simplified conditional for testing if HOME is set 2015-01-19 14:58:47 -02:00