Brian Fraser fraserb@gmail.com
f8113b4676
A parse_ethtools() that actually works
2012-03-29 19:44:51 -03:00
Brian Fraser fraserb@gmail.com
996a76a68e
pt-summary shouldn't leave empty files; both summary tools should
...
die if passed a --save-samples directory that has files in it.
2012-03-29 19:21:32 -03:00
Brian Fraser fraserb@gmail.com
3ee8f9ba71
Fixed the Table Cache bugs.
...
Also makes t/lib/bash/collect_system_info.sh actually call setup_commands.
2012-03-28 15:29:57 -03:00
Brian Fraser fraserb@gmail.com
4bb5968c23
More fixes as per the reviews.
...
- Took out ${prefix}-
- get_var sanity
- pt-mysql-summary now follows pt-summary's suit and doesn't take
in files to write to
- pt-summary defers setting the CMD_FOO vars to a function, as
otherwise it would skip our PATH mungling.
2012-03-28 13:04:14 -03:00
Brian Fraser fraserb@gmail.com
ae6c1e3789
More fixes:
...
- pt-mysql-summary's --read-samples shouldn't need an active connection
- Bunch of pt-summary bugs, particularly several relating to disks.
2012-03-27 12:53:31 -03:00
Brian Fraser fraserb@gmail.com
0e4fa22d18
*-summary tools: Changes from the reviews. Tests for pt-mysql-summary not finished yet
2012-03-27 06:19:37 -03:00
Brian Fraser fraserb@gmail.com
3ffda5677b
pt-summary for 2.1, also changes to pt-mysql-summary from Daniel's review
2012-03-24 14:20:09 -03:00
Brian Fraser fraserb@gmail.com
88a9a66946
pt-mysql-summary for 2.1
2012-03-20 18:29:35 -03:00
Brian Fraser fraserb@gmail.com
55c7248c54
(more syncing)
2012-03-20 17:16:06 -03:00
Brian Fraser fraserb@gmail.com
31afeb73b5
(temp commit, syncing up)
2012-03-20 11:21:16 -03:00
Daniel Nichter
6e94c39072
Use Perl instead of awk to avoid 32-bit limitation.
2012-02-24 11:11:07 -07:00
Daniel Nichter
0ac6c35211
Fix _pidof() calls in collect.sh. Update Bash libs in pt-ioprofile.
2012-02-03 10:49:27 -07:00
Daniel Nichter
9c6b9ab33d
Use printf(%d) to avoid CentOS using floats.
2012-02-02 12:13:00 -07:00
Daniel Nichter
7be99c5140
Add _which() to alt_cmds.sh and update pt-stalk.
2012-02-02 12:04:28 -07:00
Daniel Nichter
c40e5db1bf
Fix lib tests for MySQL 5.0.
2012-02-02 10:56:55 -07:00
Daniel Nichter
cd91b583c1
Removed unused global vars.
2012-02-01 10:03:37 -07:00
Daniel Nichter
6205505263
Don't use basename and quote $dir in tmpdir.sh.
2012-01-31 10:20:37 -07:00
Daniel Nichter
be8c0e6e18
Fix parsing opts from config file with leading and trailing space.
2012-01-30 11:15:28 -07:00
Daniel Nichter
89242d9fde
Don't init a global with a global.
2012-01-30 10:20:31 -07:00
Daniel Nichter
8389da4c07
Use . instead of source. Quote func file. Verify --function. Add option_error() to parse_options.sh. Update libs in pt-stalk.
2012-01-30 09:22:25 -07:00
Daniel Nichter
d1a684b55b
Use _pidof() and _lsof() from Percona Monitoring Plugins. Use "" and "yes" exclusively in collect(). Don't exec cmds that need mysqld_pid unless mysqld_pid is defined. Use log() instead of echo.
2012-01-30 08:59:19 -07:00
Daniel Nichter
e954505dd2
Don't print errors in data files; let the general -output file catch them. Print TS lines before data. Try to find sysctl manually. Add _pidof() to alt_cmds.sh.
2012-01-27 17:37:59 -07:00
Daniel Nichter
81ae556f8b
Use local IFS.
2012-01-26 13:04:23 -07:00
Daniel Nichter
6b017da6fe
Use new pretty --help.
2012-01-26 12:59:48 -07:00
Daniel Nichter
05ac0be136
Change --disk-byte-limit to --disk-bytes-free and --disk-pct-limit to --disk-pct-free.
2012-01-26 12:45:44 -07:00
Daniel Nichter
d7d5381863
Make check_disk_space() use bytes (given new size type options with are converted to bytes, 1k=>1024).
2012-01-26 12:19:47 -07:00
Daniel Nichter
81caf6addc
Convert size \d+[KMGT] opts in parse_options.sh.
2012-01-26 10:44:55 -07:00
Daniel Nichter
c2fd3f54c2
Use "yes" for true, "" for false. Use $PO_DIR instead of $TMP_DIR/po. Add and test Baron's code for 'Options and values after processing arguments'. Make --help exit 0 unless there were errors.
2012-01-24 12:49:18 -07:00
Daniel Nichter
42a8e39635
Use better Bash.
2012-01-24 12:28:41 -07:00
Daniel Nichter
36c14f492a
Don't use grep -q.
2012-01-24 12:15:29 -07:00
Daniel Nichter
4905e3503c
Handle --config FILE[,FILE,...] in parse_options.sh.
2012-01-24 11:18:41 -07:00
Daniel Nichter
034f76d77e
Fix handling EXT_ARGV.
2012-01-23 10:53:41 -07:00
Daniel Nichter
0d348ce289
Make parse_options work with everything: cmd line, config files, values with spaces, op val, op=val, etc.
2012-01-23 10:30:42 -07:00
Daniel Nichter
65a3ab5157
Handle values with spaces. Still needs work; one test is failing.
2012-01-21 13:59:02 -07:00
Daniel Nichter
acbc6b4622
Parse config files. Refactor parse_option.sh. Print --help and --version to STDOUT.
2012-01-20 11:34:51 -07:00
Daniel Nichter
51b93a6235
Fix --help description interpolation.
2012-01-19 12:20:33 -07:00
Daniel Nichter
2412e01aa0
Use which to get programs. Don't create file unless the program or file exists.
2012-01-19 10:46:48 -07:00
Daniel Nichter
6e2b670af6
Die if --log, --pid, or --dest aren't accessible. Also die if po dir isn't accessible.
2012-01-17 13:12:08 -07:00
Daniel Nichter
b2bac5c765
Quote in tmpdir.sh and fix typo in doc.
2012-01-17 12:15:49 -07:00
Daniel Nichter
cfce6e6eb2
More quoting and tweaking re Baron's review.
2012-01-13 10:02:17 -07:00
Daniel Nichter
a9afea4506
Quote vals in Bash libs. Add tests for log_warn_die.sh and alt_cmds.sh. Make --help test path independent.
2012-01-11 11:31:41 -07:00
Daniel Nichter
0056014339
Let desc sentence be terminated by period of question mark.
2011-12-19 12:55:14 -07:00
Daniel Nichter
9baea8b7b6
Convert parse_option to sh, use Perl instead of awk, implement --help.
2011-12-19 12:51:47 -07:00
Daniel Nichter
3266e0aeca
Don't use OPT_TMPDIR in tmpdir.sh. Define EXT_ARGV in parse_options.sh.
2011-12-19 11:29:21 -07:00
Daniel Nichter
bb315948cd
Parse disk space using df -P -k.
2011-12-19 10:22:42 -07:00
Daniel Nichter
a172a3f2a7
Return 0 only if no --help, --verion, or opt errors.
2011-12-15 12:12:18 -07:00
Daniel Nichter
f3ac1b20c2
Add usage_or_errors() to parse_options.sh.
2011-12-15 12:01:22 -07:00
Daniel Nichter
92c8635c4a
Fix and test safeguards.sh. Implement disk space+margin check.
2011-12-14 16:12:43 -07:00
Daniel Nichter
90fbfaf41f
Don't quote $EXT_ARGV so multiple opts work.
2011-12-08 14:25:35 -07:00
Daniel Nichter
36e88c8e40
Fix typo.
2011-12-08 13:49:44 -07:00
