percona/percona-toolkit
1
0
Fork 0
mirror of https://github.com/percona/percona-toolkit.git synced 2025-09-20 10:55:01 +00:00
Code Issues Packages Projects Releases Wiki Activity
5,826 Commits 139 Branches 71 Tags
f72d9c9637bef19feb814d73867146484cfa0c8c
Commit Graph

2127 Commits

Author SHA1 Message Date
Sveta Smirnova
2b5ceb9fee Merge pull request #1002 from Shopify/PT-2015_fix_comparing_unsorted_flags 
PT-2015 Fix pt-config-diff not sorting flags
 2025-09-02 14:56:24 +03:00
Sveta Smirnova
c5c6bf34c6 Merge pull request #1003 from percona/PT-2305_pt-online-schema-change_should_error_if_server_is_a_slave_in_row_based_replication 
PT-2305 - pt-online-schema-change should error if server is a slave in row based replication
 2025-09-02 14:55:48 +03:00
Sveta Smirnova
0d0e7210f7 PT-2322 - pt-mysql-summary does not detect jemalloc. 
- Added fix and test case. Fix checks for end of word (space or newline) instead of space.
 2025-08-29 15:09:12 +03:00
Sveta Smirnova
ab620a6707 PT-2305 - pt-online-schema-change should error if server is a slave in row based replication 
- Implemented fix and test case
- Updated documentation
 2025-08-29 01:33:18 +03:00
Hartley McGuire
47f7638d60 PT-2015 Fix pt-config-diff not sorting flags 
Previously, flags would be compared in the exact order they are output
by MySQL, which can result in false negatives if the input ordering does
not match.

Example from the ticket:

```
[root@avvr-dbm51 ~]# pt-config-diff /etc/my.cnf h=localhost,P=3047
1 config difference
Variable                  /etc/my.cnf  avvr-dbm51
========================= ============ ============
myisam_recover_options    FORCE,BACKUP BACKUP,FORCE
```

This commit fixes the issue by sorting the flags before comparison to
ensure that any ordering differences will not report a diff.

Co-authored-by: Jonathan Gnagy <jonathan@therubyist.org>
 2025-08-27 16:12:27 +00:00
Sveta Smirnova
6414d071cd Merge pull request #997 from percona/PT-2467_t_pt-show-grants_basics.t_t_pt-table-checksum_basics.t_t_pt-table-sync_filters.t_t_pt-upgrade_diff_rows.t_fail_with_the_latest_PT 
PT-2467 - t/pt-show-grants/basics.t t/pt-table-checksum/basics.t t/pt…
 2025-08-26 19:43:51 +03:00
Sveta Smirnova
670f4d159b Merge pull request #992 from percona/PT-1423_LP_1682929_pt-table-checksum_First_chunk_takes_too_long 
PT-1423 - LP #1682929: pt-table-checksum: First chunk takes too long
 2025-08-26 19:43:16 +03:00
Sveta Smirnova
a0dffc51e4 Merge pull request #989 from agejevasv/fix-precedence-error 
Fix script crashing with precedence error
 2025-08-26 19:43:00 +03:00
Sveta Smirnova
9e799fd04b Merge pull request #981 from Nyele93/PT-2465_patch_fix_for_mariadb_10.5_above 
PT-2465 patch fix for erroneous flavour mismatch in mariadb-10.5.x and above
 2025-08-26 19:42:44 +03:00
Sveta Smirnova
afd8ccbbd5 PR-996 - Add invisible option to pt-duplicate-key-checker 
- Fixed test case
 2025-08-25 16:44:47 +03:00
Sveta Smirnova
495869da3e PT-2440 - Support for MariaDB 10.5 
- Updated non-libraries code in bin/pt-heartbeat, bin/pt-replica-restart, and bin/pt-slave-delay
- Adjusted lib/Sandbox.pm, so it does not require SSL for MariaDB
- Adjusted test case, so it is in line with other tests
 2025-08-23 03:32:33 +03:00
Sveta Smirnova
4154acadc1 PT-2467 - t/pt-show-grants/basics.t t/pt-table-checksum/basics.t t/pt-table-sync/filters.t t/pt-upgrade/diff_rows.t fail with the latest PT 
- Updated tests and results failed due to new percona.telemetry user
 2025-08-22 18:38:07 +03:00
utdrmac
059a6fb52c add test case 2025-08-20 16:20:12 -05:00
Nyele
6c9deb9d66 Merge branch 'percona:3.x' into PT-2465_patch_fix_for_mariadb_10.5_above 2025-08-18 14:44:30 +03:00
Sveta Smirnova
825dea7547 PT-1423 - LP #1682929: pt-table-checksum: First chunk takes too long 
- Modified the tool, so if both --chunk-size and --chunk-time are specified, it starts chunking with the indicated --chunk-size, and then adjusts chunk size to fit the time.
 2025-08-16 02:01:22 +03:00
Sveta Smirnova
82a2ac7a40 PR-989 - Fix script crashing with precedence error 
- Fixed typo in the tool code
- Added more diagnostic information into test for pt-1919
 2025-08-13 17:03:29 +03:00
Sveta Smirnova
702f837698 Merge pull request #988 from percona/PT-2052_Tools_should_default_to_unbuffered_stdout_stderr 
Pt 2052 tools should default to unbuffered stdout stderr
 2025-08-13 14:22:57 +03:00
Sveta Smirnova
0b91854014 Merge pull request #982 from percona/PT-191_add_ssl_options_to_DSN 
PT-191 - add ssl options to DSN
 2025-08-06 16:30:28 +03:00
Sveta Smirnova
51f40f2cbb PT-2052 - Tools should default to unbuffered stdout/stderr 
- Added test case
 2025-08-06 16:13:52 +03:00
Sveta Smirnova
5100e9b1aa PT-191 - add ssl options to DSN 
- Updated ssl tests, so they test option --mysql_ssl and DSN
 2025-07-30 17:18:38 +03:00
nilnandan
6588510632 PT-1718 - Have pt-stalk collect performance_schema.threads along with information_schema.processlist 
- Update collect.sh file and add code for collecting threads details.
- Add PT-1718-threads.t test file for testing this fix.
 2025-07-30 14:11:43 +00:00
Sveta Smirnova
2bea8ac44b PT-191 - add ssl options to DSN 
- Added test t/pt-replica-find/ssl.t
- Added option --mysql_ssl to all tools that support own connection
  options
 2025-07-29 22:02:49 +03:00
Sveta Smirnova
2954d5a749 PT-191 - add ssl options to DSN 
- Typo in t/pt-index-usage/ssl.t
- Missed test t/pt-query-digest/ssl.t
- Missed option --mysql_ssl in pt-query-digest
 2025-07-28 19:05:00 +03:00
Sveta Smirnova
b7094dfd09 PT-191 - add ssl options to DSN 
- Added test cases to ensure SSL is working in all tools
 2025-07-26 14:18:30 +03:00
Sveta Smirnova
7a8fee3d86 Merge pull request #974 from marek-knappe/PT-2457-pt-online-schema-change-add-drop-tablespace-Option 
fix(pt-online-schema-change): correct --remove-data-dir default behav…
 2025-07-23 13:11:59 +03:00
Sveta Smirnova
1d0487cf2f PT-2418 - pt-online-schema-change 3.7.0 lost data when exe alter xxx rename column xxx 
- Added instructions to skip the test if server version is less than 8.0
 2025-07-21 18:25:30 +03:00
Sveta Smirnova
8f068a9d59 PT-2418 - pt-online-schema-change 3.7.0 lost data when exe alter xxx rename column xxx 
- Added clean up to the test
- Added test for enabled option --check-alter
- Removed extra spaces
 2025-07-21 16:45:10 +03:00
mamadi
2dd8de7def created test case for patch 2025-07-16 16:45:17 +02:00
Marek Knappe
4a9a4bb903 PT-2418: Fix column data loss during RENAME COLUMN operations 
The pt-online-schema-change tool was not properly handling RENAME COLUMN
syntax (MySQL 8.0+), causing renamed columns to be excluded from the
data copy operation. This resulted in NULL values for renamed columns
after the schema change.

The issue was in the find_renamed_cols() function which only supported
CHANGE COLUMN syntax but not RENAME COLUMN syntax. Added support for
RENAME COLUMN parsing to properly detect column renames and include
them in the common_cols list for data copying.

Fixes: PT-2418
 2025-07-02 12:45:00 +10:00
Marek Knappe
d0d046122b fix(pt-online-schema-change): correct --remove-data-dir default behavior (#PT-2458) 
- Fixed issue where --remove-data-dir incorrectly defaulted to true

feat(pt-online-schema-change): add support for TABLESPACE removal (#PT-2457)
- Implemented detection and removal of TABLESPACE clause during schema changes
 2025-06-24 17:09:55 +10:00
Sveta Smirnova
d5d39a83fa Merge pull request #890 from dbnski/long-variable-values 
pt-config-diff: MySQL truncates run-time variable values longer than 1024 characters
 2025-06-22 15:53:09 +03:00
Sveta Smirnova
6fc8f66792 Delete t/pt-config-diff/samples/long_vars_80_2.cnf 2025-06-22 15:49:08 +03:00
Sveta Smirnova
71c8d866a5 Delete t/pt-config-diff/samples/long_vars_80_1.cnf 2025-06-22 15:48:35 +03:00
Sveta Smirnova
6cff1dfe77 Delete t/pt-config-diff/samples/long_vars_57_2.cnf 2025-06-22 15:48:19 +03:00
Sveta Smirnova
9b83a7dc74 Delete t/pt-config-diff/samples/long_vars_57_1.cnf 2025-06-22 15:47:56 +03:00
Sveta Smirnova
0c7e5d749c PR-890 - pt-config-diff: MySQL truncates run-time variable values longer than 1024 characters 
- Modified test case, so it works with versions 5.7, 8.0, and 8.4
  without changes
 2025-06-13 02:31:43 +03:00
Sveta Smirnova
b3bf684f39 Merge pull request #947 from percona/PT-2129_pt-online-schem-change_fails_on_non-readable_version_check_file 
PT-2129 - pt-online-schem-change and other tools fail on non-readable…
 2025-06-13 02:09:35 +03:00
Sveta Smirnova
46f5a2d220 Merge pull request #945 from percona/PT-2424_Typo_in_pt-table-checksum_error_message_--resume_and_--no-empty-replicate-table_are_mutually_exclusive 
PT-2424 - Typo in pt-table-checksum error message "--resume and --no-…
 2025-06-12 17:29:25 +03:00
Maciej Dobrzanski
55f2167ed0 - Updated MySQLConfig.pm to correctly support very long variable values 
- Added test cases for pt-config-diff
 2025-06-06 20:39:24 +02:00
Sveta Smirnova
ef2dbd887f PT-2129 - pt-online-schem-change and other tools fail on non-readable version check file 
- Implemented fix in lib/VersionCheck.pm
- Updated modules in all tools
- Added test case to t/pt-query-digest/version_check.t
 2025-03-29 23:22:44 +03:00
Sveta Smirnova
ebacadf098 Revert "PT-2424 - Typo in pt-table-checksum error message "--resume and --no-empty-replicate-table are mutually exclusive"" 
This reverts commit e964e17f21.
 2025-03-27 21:40:32 +03:00
Sveta Smirnova
c49c58db2b Merge pull request #941 from percona/PT-2355_pt-online-schema-change_should_not_resume_a_job_with_empty_boundaries 
PT-2355 - pt-online-schema-change should not resume a job with empty …
 2025-03-27 21:13:43 +03:00
Sveta Smirnova
9711db87a7 Merge pull request #944 from percona/PT-2407_pt-online-schema-change_exit_stauts_return_code_is_0_even_if_it_does_NOT_succeed 
PT-2407 - pt-online-schema-change exit status(return code) is 0 even …
 2025-03-27 21:13:27 +03:00
Sveta Smirnova
905490bac5 PT-2424 - Typo in pt-table-checksum error message "--resume and --no-empty-replicate-table are mutually exclusive" 
- Fixed typo
- Added test case
 2025-03-27 21:11:31 +03:00
Sveta Smirnova
e964e17f21 PT-2424 - Typo in pt-table-checksum error message "--resume and --no-empty-replicate-table are mutually exclusive" 
- Fixed typo
- Added test case
 2025-03-27 21:09:10 +03:00
Sveta Smirnova
88367c1dea PT-2407 - pt-online-schema-change exit status(return code) is 0 even if it does NOT succeed 
- Changed die call for the case when ALTER TABLE fails for the new table
- Removed stalled comment from Frank
- Added test case
 2025-03-26 17:51:35 +03:00
Sveta Smirnova
840ba6926b PT-2355 - pt-online-schema-change should not resume a job with empty boundaries 
- The tool should still fail, so I improved error message and added test case
 2025-03-22 00:01:56 +03:00
Sveta Smirnova
f9ea94f195 Merge pull request #918 from drwonky/PT-2422 
PT-2422 Fix unconstrained UPDATE to pt_osc_history table
 2025-03-18 15:04:43 +03:00
Sveta Smirnova
c92d95bc38 Merge pull request #903 from Robertoh98/PT-2410 
PT-2410 - Fixing the export with output-format=csv when there are null values
 2025-03-18 15:02:03 +03:00
Sveta Smirnova
f4a324581a PT-2410 - pt-archiver brokes when using output-format=csv and has null values 
- Updated t/pt-archiver/file.t
 2025-03-13 23:26:56 +03:00