percona/percona-toolkit
1
0
Fork 0
mirror of https://github.com/percona/percona-toolkit.git synced 2025-09-24 13:25:01 +00:00
Code Issues Packages Projects Releases Wiki Activity
5,751 Commits 140 Branches 71 Tags
f550652dbfa77d1f485767e1a7f71cb539c2f1d8
Commit Graph

2105 Commits

Author SHA1 Message Date
Sveta Smirnova
f550652dbf PT-2014 - pt-config-diff does not honor case insensitivity flag 
- Fixed the proposed fix
- Fixed proposed configuration files
- Added test case
 2025-09-09 19:25:13 +03:00
nilnandan
4e190a34ef Updated MySQLConfigComparer.pm so now it can honor case insensitivity. cnf1 and cnf2 are test files. 2025-09-08 14:12:12 +00:00
nilnandan
6588510632 PT-1718 - Have pt-stalk collect performance_schema.threads along with information_schema.processlist 
- Update collect.sh file and add code for collecting threads details.
- Add PT-1718-threads.t test file for testing this fix.
 2025-07-30 14:11:43 +00:00
Sveta Smirnova
7a8fee3d86 Merge pull request #974 from marek-knappe/PT-2457-pt-online-schema-change-add-drop-tablespace-Option 
fix(pt-online-schema-change): correct --remove-data-dir default behav…
 2025-07-23 13:11:59 +03:00
Sveta Smirnova
1d0487cf2f PT-2418 - pt-online-schema-change 3.7.0 lost data when exe alter xxx rename column xxx 
- Added instructions to skip the test if server version is less than 8.0
 2025-07-21 18:25:30 +03:00
Sveta Smirnova
8f068a9d59 PT-2418 - pt-online-schema-change 3.7.0 lost data when exe alter xxx rename column xxx 
- Added clean up to the test
- Added test for enabled option --check-alter
- Removed extra spaces
 2025-07-21 16:45:10 +03:00
Marek Knappe
4a9a4bb903 PT-2418: Fix column data loss during RENAME COLUMN operations 
The pt-online-schema-change tool was not properly handling RENAME COLUMN
syntax (MySQL 8.0+), causing renamed columns to be excluded from the
data copy operation. This resulted in NULL values for renamed columns
after the schema change.

The issue was in the find_renamed_cols() function which only supported
CHANGE COLUMN syntax but not RENAME COLUMN syntax. Added support for
RENAME COLUMN parsing to properly detect column renames and include
them in the common_cols list for data copying.

Fixes: PT-2418
 2025-07-02 12:45:00 +10:00
Marek Knappe
d0d046122b fix(pt-online-schema-change): correct --remove-data-dir default behavior (#PT-2458) 
- Fixed issue where --remove-data-dir incorrectly defaulted to true

feat(pt-online-schema-change): add support for TABLESPACE removal (#PT-2457)
- Implemented detection and removal of TABLESPACE clause during schema changes
 2025-06-24 17:09:55 +10:00
Sveta Smirnova
d5d39a83fa Merge pull request #890 from dbnski/long-variable-values 
pt-config-diff: MySQL truncates run-time variable values longer than 1024 characters
 2025-06-22 15:53:09 +03:00
Sveta Smirnova
6fc8f66792 Delete t/pt-config-diff/samples/long_vars_80_2.cnf 2025-06-22 15:49:08 +03:00
Sveta Smirnova
71c8d866a5 Delete t/pt-config-diff/samples/long_vars_80_1.cnf 2025-06-22 15:48:35 +03:00
Sveta Smirnova
6cff1dfe77 Delete t/pt-config-diff/samples/long_vars_57_2.cnf 2025-06-22 15:48:19 +03:00
Sveta Smirnova
9b83a7dc74 Delete t/pt-config-diff/samples/long_vars_57_1.cnf 2025-06-22 15:47:56 +03:00
Sveta Smirnova
0c7e5d749c PR-890 - pt-config-diff: MySQL truncates run-time variable values longer than 1024 characters 
- Modified test case, so it works with versions 5.7, 8.0, and 8.4
  without changes
 2025-06-13 02:31:43 +03:00
Sveta Smirnova
b3bf684f39 Merge pull request #947 from percona/PT-2129_pt-online-schem-change_fails_on_non-readable_version_check_file 
PT-2129 - pt-online-schem-change and other tools fail on non-readable…
 2025-06-13 02:09:35 +03:00
Sveta Smirnova
46f5a2d220 Merge pull request #945 from percona/PT-2424_Typo_in_pt-table-checksum_error_message_--resume_and_--no-empty-replicate-table_are_mutually_exclusive 
PT-2424 - Typo in pt-table-checksum error message "--resume and --no-…
 2025-06-12 17:29:25 +03:00
Maciej Dobrzanski
55f2167ed0 - Updated MySQLConfig.pm to correctly support very long variable values 
- Added test cases for pt-config-diff
 2025-06-06 20:39:24 +02:00
Sveta Smirnova
ef2dbd887f PT-2129 - pt-online-schem-change and other tools fail on non-readable version check file 
- Implemented fix in lib/VersionCheck.pm
- Updated modules in all tools
- Added test case to t/pt-query-digest/version_check.t
 2025-03-29 23:22:44 +03:00
Sveta Smirnova
ebacadf098 Revert "PT-2424 - Typo in pt-table-checksum error message "--resume and --no-empty-replicate-table are mutually exclusive"" 
This reverts commit e964e17f21.
 2025-03-27 21:40:32 +03:00
Sveta Smirnova
c49c58db2b Merge pull request #941 from percona/PT-2355_pt-online-schema-change_should_not_resume_a_job_with_empty_boundaries 
PT-2355 - pt-online-schema-change should not resume a job with empty …
 2025-03-27 21:13:43 +03:00
Sveta Smirnova
9711db87a7 Merge pull request #944 from percona/PT-2407_pt-online-schema-change_exit_stauts_return_code_is_0_even_if_it_does_NOT_succeed 
PT-2407 - pt-online-schema-change exit status(return code) is 0 even …
 2025-03-27 21:13:27 +03:00
Sveta Smirnova
905490bac5 PT-2424 - Typo in pt-table-checksum error message "--resume and --no-empty-replicate-table are mutually exclusive" 
- Fixed typo
- Added test case
 2025-03-27 21:11:31 +03:00
Sveta Smirnova
e964e17f21 PT-2424 - Typo in pt-table-checksum error message "--resume and --no-empty-replicate-table are mutually exclusive" 
- Fixed typo
- Added test case
 2025-03-27 21:09:10 +03:00
Sveta Smirnova
88367c1dea PT-2407 - pt-online-schema-change exit status(return code) is 0 even if it does NOT succeed 
- Changed die call for the case when ALTER TABLE fails for the new table
- Removed stalled comment from Frank
- Added test case
 2025-03-26 17:51:35 +03:00
Sveta Smirnova
840ba6926b PT-2355 - pt-online-schema-change should not resume a job with empty boundaries 
- The tool should still fail, so I improved error message and added test case
 2025-03-22 00:01:56 +03:00
Sveta Smirnova
f9ea94f195 Merge pull request #918 from drwonky/PT-2422 
PT-2422 Fix unconstrained UPDATE to pt_osc_history table
 2025-03-18 15:04:43 +03:00
Sveta Smirnova
c92d95bc38 Merge pull request #903 from Robertoh98/PT-2410 
PT-2410 - Fixing the export with output-format=csv when there are null values
 2025-03-18 15:02:03 +03:00
Sveta Smirnova
f4a324581a PT-2410 - pt-archiver brokes when using output-format=csv and has null values 
- Updated t/pt-archiver/file.t
 2025-03-13 23:26:56 +03:00
Sveta Smirnova
3cb46e61f7 PT-2410 - pt-archiver brokes when using output-format=csv and has null values 
- Added test case
 2025-03-13 22:57:46 +03:00
Sveta Smirnova
4bf48d864f PT-2422 - pt-online-schema-change race overwrites new_table_name 
- Added test case
 2025-03-13 21:30:00 +03:00
Sveta Smirnova
5c16d37020 PT-2389 - pt-online-schema-change resume functionality doesn't work with ADD/DROP column 
- Modified pt-1717-resume.t test case, so it passes now
 2025-03-12 17:31:43 +03:00
Perry Harrington
888af5f5ef Updated test for PT-1717 to perform meaningful alter so fix for PT-2389 would be exercised 2025-01-28 11:51:03 -08:00
Sveta Smirnova
a06b3877c8 Merge pull request #909 from percona/PT-2400-pt-table-checksum_reports_the_error_for_warning_code_4164 
PT-2400 - pt-table-checksum reports the error for warning code 4164
 2025-01-14 18:17:30 +03:00
Sveta Smirnova
e716a03060 Update t/pt-table-checksum/pt-2400.t 
Co-authored-by: EvgeniyPatlan <evgeniy.patlan@percona.com>
 2025-01-14 18:15:06 +03:00
Sveta Smirnova
0a98a81370 Merge pull request #863 from hpoettker/PT-2378_table_sync_with_more_fp_precision 
PT-2378 - extended FP precision in pt-table-sync
 2025-01-14 18:06:55 +03:00
Sveta Smirnova
f837672d1d Merge pull request #861 from hpoettker/PT-2377_table_sync_with_utf8_json 
PT-2377 - fixed pt-table-sync for JSON utf8 strings
 2025-01-14 18:04:41 +03:00
Henning Poettker
1e581be06a PT-2378 - extended FP precision in pt-table-sync 
pt-table-sync now uses up to 17 decimal digits when writing
floating point numbers in the generated SQL statements.
This is necessary to prevent unintended data changes.
 2025-01-13 09:31:51 +01:00
Sveta Smirnova
c796b2c148 PT-2400 - pt-table-checksum reports the error for warning code 4164 
- Fixed typo
- Added test case
 2025-01-10 23:01:35 +03:00
Sveta Smirnova
ce20bc7dd1 Merge pull request #860 from hpoettker/PT-2375_table_sync_with_generated_columns 
PT-2375 - fixed pt-table-sync for tables with generated columns
 2024-12-27 18:08:08 +03:00
Henning Poettker
16b06dcfc2 PT-2377 - fixed pt-table-sync for JSON utf8 strings 
The MySQL driver DBD::mysql does not decode JSON values as utf8
although MySQL uses utf8mb4 for all JSON strings.

This change decodes JSON values as utf8 (when not already done)
such that SQL statements are generated correctly.
 2024-12-27 13:46:55 +01:00
Sveta Smirnova
9f1e50cb58 PT-2340 - Support MySQL 8.4 
- Changed replica_parallel_workers in configuration for 8.0 and 8.4 to o, because wiat_for_replicas is buggy for multi-threaded slaves (cherry picked from commit d9b0219d9e)
- Minor tests diagnostic and cleanup
 2024-12-16 13:23:41 +03:00
Sveta Smirnova
44a2819055 PT-2340 - Support MySQL 8.4 
- Added wait_for_replicas call into t/pt-table-checksum/pt-1616.t
- Added diagnostic output into t/pt-upgrade/run_time.t, t/pt-table-sync/issue_627.t
 2024-12-03 16:25:58 +03:00
Henning Poettker
5f14441d19 PT-2375 - fixed pt-table-sync for tables with generated columns 
Previously, pt-table-sync generated DML statements that included
the generated columns of a table, which is however rejected by
the database and not necessary for the required sync statements.
 2024-11-14 23:51:40 +01:00
Henning Poettker
f8d736a89a Fixed flaky tests 
The tests previously tested assertions against the replica after
executing changes in the source without waiting for the
replication to converge.
 2024-11-14 22:58:42 +01:00
Sveta Smirnova
f57d63ab00 PT-2340 - Support MySQL 8.4 
- Added sleep to t/lib/MasterSlave.t, so it does not fail on fast machines
- Disabled SSL tests on versions earlier than 8.0
 2024-11-14 22:48:06 +03:00
Sveta Smirnova
3786d4e4ce PT-2340 - Support MySQL 8.4 
- Added SSL to 8.4 tests
 2024-11-14 03:20:43 +03:00
Sveta Smirnova
8b802722db PT-2340 - Support MySQL 8.4 
- Adjusted tools and tests which fail due to fixed update-modules command
- Adjsted t/pt-table-checksum/basics.t test for 8.0
 2024-11-13 21:23:39 +03:00
Sveta Smirnova
bb66ab0845 PT-2340 - Support MySQL 8.4 
- Implemented functions get_replica_name and get_source_name in lib/MasterSlave.pm I did not implement similar functions in other places, because they set other variables as well, not only replica_name or source_name.
 2024-11-13 02:04:39 +03:00
Sveta Smirnova
a1093ff12c PT-2340 - Support MySQL 8.4 
- s/slave lag/replica lag/ in tests
- reverted rename of COM_REGISTER_SLAVE to COM_REGISTER_REPLICA, because the constant still named COM_REGISTER_SLAVE in 8.4
- removed some slave leftovers from pt-replica-find
 2024-11-12 15:18:36 +03:00
Sveta Smirnova
fcb2d549b8 PT-2340 - Support MySQL 8.4 
- Adjusted pt-variable-advisor, so it reflects current defaults
 2024-10-04 19:02:07 +03:00