Daniel Nichter
e5300c78a0
Check slave threads and read-only in Sandbox::ok().
2012-06-03 13:09:46 -04:00
Daniel Nichter
d9a786d8f3
Add Sandbox::ok().
2012-06-03 12:46:12 -04:00
Daniel Nichter
09ddcd641e
Merge advisor-json-output and clean up pt-query-advisor docs.
2012-06-01 09:13:11 -06:00
Brian Fraser fraserb@gmail.com
0b5196a1f1
Merged ~percona-toolkit-dev/percona-toolkit/fix-1003315
2012-05-30 15:52:21 -03:00
Brian Fraser fraserb@gmail.com
8e04e3df60
Fix for 1003315: dry-run + alter-fk-method = auto always fail.
2012-05-30 14:27:07 -03:00
Brian Fraser fraserb@gmail.com
20d6ccff9e
Fix for 923896
2012-05-27 23:28:35 -03:00
Daniel Nichter
fcd8958fb7
Validate --max|critical-load early and strongly, and check that the var exists and is defined.
2012-05-25 15:27:23 -06:00
Daniel Nichter
bbe6125d8f
Validate --max|critical-load (work in progress).
2012-05-25 12:15:11 -06:00
Daniel Nichter
4b6fe95c6c
Handle MySQL 5.5 named values for concurrent_insert.
2012-05-24 14:52:11 -06:00
Daniel Nichter
bb5d64b4a6
Remove \, from any DSN part (value or bareword). Document that DSN values must be escaped.
2012-05-24 11:20:38 -06:00
Daniel Nichter
026d95ac24
Separate DSN parts using escaped commas instead so bareword values work.
2012-05-24 10:56:04 -06:00
Daniel Nichter
15146353f9
Use regex to split DSN parts to allow commas in values.
2012-05-24 10:32:39 -06:00
Daniel Nichter
491c076e75
Implement retry_on_error for Pipeline processes. Retry iteration proc twice, then fail completely. Fix mirror.t.
2012-05-23 16:07:05 -06:00
Daniel Nichter
d0d296ee16
Use SchemaIterator for filtering --sync-to-master and --replicate. Return arrayref from TableChecksum::find_replication_differences().
2012-05-21 15:50:40 -06:00
Daniel Nichter
e969d8d9f7
Implement and test --recursion-method=none in MasterSlave.pm and pt-table-checksum.
2012-05-17 08:11:30 -06:00
Daniel Nichter
d46285342a
Use 6 X with mktemp to make it work on some platforms and update all tools.
2012-05-16 11:38:48 -06:00
Daniel Nichter
350aa3a344
Merge fix-dupe-key-bug-894140.
2012-05-14 19:10:50 -06:00
Daniel Nichter
e932c89d9e
Fix bug that caused not all "right keys" to be compared in certain cases.
2012-05-14 19:05:32 -06:00
Daniel Nichter
5a77e8c09c
Fix scrolling header for --group-by=all.
2012-05-10 14:06:52 -07:00
Daniel Nichter
1c23b615b2
Add XXX comments where the Perl oddity is being used.
2012-05-10 10:21:44 -06:00
Daniel Nichter
f4957ba911
Use --chunk-size-limit || 1 for checking if a table can be done in one chunk to avoid chunking empty tables. Checksums for empty tables are now written.
2012-05-10 09:55:42 -06:00
Daniel Nichter
715f0f86e1
Merge fix-undef-arrayref-bug-995274.
2012-05-08 17:02:58 -06:00
Daniel Nichter
884d02bc2a
Lowercase index from EXPLAIN (unless it's PRIMARY) to match lowercase ident names from TableParser::parser().
2012-05-08 16:51:35 -06:00
Daniel Nichter
7a7c0fe157
Merge ../fix-ptc-pk-bug-978432.
2012-05-08 12:47:54 -06:00
Daniel Nichter
30b6b88766
Restore original NibbleIterator and implement simpler solution: only use MySQL's chosen index if --where.
2012-05-08 12:43:47 -06:00
Daniel Nichter
cc80f278d5
Code comment why MiB, GiB, etc. are used in shorten() and update that func in pt-summary and pt-mysql-summary.
2012-05-07 16:38:30 -06:00
Daniel Nichter
fdfd305dc5
Simplify and fix report_formatting::shorten(), and add Petabyte unit (in case it's needed). Update affected test samples. Add T_DIR to util/test-bash-functions.
2012-05-07 12:16:24 -06:00
Daniel Nichter
e2073065b1
EXPLAIN actual ascending nibble query to get MySQL's chosen index, and use that instead of the tool's chosen index. TODO: fix OobNibbleIterator.t and chunk_index.t.
2012-05-04 17:46:34 -06:00
Brian Fraser fraserb@gmail.com
85756b0e94
pt-kill: Add a --log-dsn option.
...
This is customer issue 23049.
2012-05-01 03:27:11 -03:00
Daniel Nichter
97b1209116
Remove useless var in SchemaIterator::_iterate_files() and update module in tools.
2012-04-03 12:21:15 -06:00
Daniel Nichter
c3b99d17a1
Add func to col ident struct to fix QueryAdvisorRules.t.
2012-04-03 11:03:17 -06:00
Daniel Nichter
0286631514
Merge summary-tools-2.1.
2012-04-03 10:14:55 -06:00
Daniel Nichter
b0b65fd8fd
Merge fix-log-parser-writer-bug-963225.
2012-04-03 09:56:11 -06:00
Brian Fraser fraserb@gmail.com
a01de98434
Fix for a bug in 32-bit Debian.
...
Namely, awk's printf("%d") doing what it's supposed to do, cast
it's operand to (int), which screws up large numbers.
The fix is simple, although it mostly just pushes the problem
under the rug; using %.0f instead of %d.
2012-04-03 12:50:12 -03:00
Daniel Nichter
0089f31a35
Merge pt-osc-2.1. Fix NibbleItertor.pm to work with OobNibbleIterator when resuming at oob boundaries (t/pt-table-checksum/resume.t was failing).
2012-04-03 09:33:10 -06:00
Brian Fraser fraserb@gmail.com
b807088b8e
Other instances of the substr(var, 0, n) bug
2012-04-03 11:29:36 -03:00
Brian Fraser fraserb@gmail.com
cfcef354b0
section(): Less printf, more awk
2012-04-03 11:07:30 -03:00
Brian Fraser fraserb@gmail.com
12bd26022a
Fix a section() bug.
...
Turns out that awk's indexes are documented to start from 1;
So what happens if you use 0? Apparently it's undefined behavior, so
substr(var, 0, 5);
and
substr(var, 1, 5);
May or may not actually do the same thing. In Debian 6, the former
doesn't quite work, and actually returns something like substr(var, 1, 4),
which broke section()'s output.
2012-04-03 10:55:51 -03:00
Daniel Nichter
403c93db3b
Handle Key_name or key_name in NibbleIterator::_get_index_cardinality().
2012-04-02 19:24:38 -06:00
Daniel Nichter
5eaa565566
Catch lost cleanup task (should rarely happen).
2012-04-02 19:20:56 -06:00
Daniel Nichter
34ada21344
Add comment about code that will fail with new Cxn due to NAME_lc.
2012-04-02 19:12:28 -06:00
Brian Fraser fraserb@gmail.com
c0dedd19bf
- section() revamp
...
- Redirect STDERR for the collection part in both tools
- rm_tempdir in sigtrap
- A part of pt-mysql-summary still depended on the system being run,
rather than the samples being read. Now it works properly.
2012-04-02 19:25:17 -03:00
Brian Fraser fraserb@gmail.com
6dbbd6de3b
The previous merge went a bit wrong, and left the libraries unsynced with the tools; This commit fixes it.
2012-04-02 13:36:17 -03:00
Daniel Nichter
c04b85a066
Update SchemaIterator, TableParser, and NibbleIterator in tools that use them. All tools' tests still pass.
2012-03-31 09:59:15 -06:00
Brian Fraser fraserb@gmail.com
761f8a5aac
Merge more of Baron's changes, also re-implement the MySQL Executables section
...
Plus other bugfixes.
2012-03-30 23:00:57 -03:00
Daniel Nichter
2bae569429
Don't use TABLE STATUS, use CREATE TABLE instead for the table's engine.
2012-03-30 18:46:08 -06:00
Daniel Nichter
1cd990a0f0
Update SchemaIterator in pt-table-sync. Make the module handle NAME_lc or not.
2012-03-30 18:15:54 -06:00
Brian Fraser fraserb@gmail.com
978b236985
Save the config file itself, not just its path.
2012-03-30 20:18:39 -03:00
Daniel Nichter
34602e89fe
Add pt-table-usage, copied and converted from mk-table-usage.
2012-03-30 16:45:10 -06:00
Daniel Nichter
4300f2908b
Add pt-fingerprint.
2012-03-30 16:07:37 -06:00
