Commit Graph

62 Commits

Author SHA1 Message Date
Sveta Smirnova
ec9cc2c910 Pt 1897 lock information in8.0 in pt stalk (#549)
* PT-1897 pt-stalk on MySQL 8 not collecting lock information

For version prior 8.0 pt-stalk continue using Information Schema INNODB_LOCKS and INNODB_LOCK_WAITS tables for collecting lock information.
For version 8.0 and higher pt-stalk uses tables data_locks and data_lock_waits in Performance Schema

* PT-1897 - Better MariaDB support

We cannot simply compare version number with 8.0 to identify if lock tables are in Performance Schema,
because MariaDB 10.x still have them in the Information Schema.
Therefore added additional flag, indicating which syntax we should use

* Tests for PT-1897

* PT-1897: added missed samples for tests

* PT-1897 Fixed retention test

Co-authored-by: Carlos Salguero <carlos.salguero@percona.com>
2022-08-30 18:14:26 +03:00
Sveta Smirnova
19aa46d1a5 PT-1052 include numa information in pt tool output (#547)
* PT-1052: fix for pt-summary

* Re-added fix from commit 71fae6d117 into proper place: library directory
Added tests for PT-1052 (pt-summary only)

* Fixed tests for pt-summary,
set locale for pt-summary tests, so they are not affected by user environment.
Finished tests for PT-1052

* Added fix for PT-1983 into the proper place: library file

* PT-1052: fix for pt-stalk which now includes numastat data
2022-08-15 15:45:24 +03:00
Sveta Smirnova
ac3843bcb7 Pt 1897 lock information in8.0 in pt stalk (#544)
* PT-1897 pt-stalk on MySQL 8 not collecting lock information

For version prior 8.0 pt-stalk continue using Information Schema INNODB_LOCKS and INNODB_LOCK_WAITS tables for collecting lock information.
For version 8.0 and higher pt-stalk uses tables data_locks and data_lock_waits in Performance Schema

* PT-1897 - Better MariaDB support

We cannot simply compare version number with 8.0 to identify if lock tables are in Performance Schema,
because MariaDB 10.x still have them in the Information Schema.
Therefore added additional flag, indicating which syntax we should use

* Tests for PT-1897
2022-07-25 10:01:14 -03:00
Sveta Smirnova
8ebc9534c6 Pt 2075 fix tests for pt stalk (#541)
* Added mysql.proxies_priv to list of exceptions from checks in Sandbox.pm

* Fixed test for slave_status for 5.7+
2022-07-11 15:55:16 +03:00
Sveta Smirnova
22ed941238 PT-1218: pt-stalk ominous open_tables function (#535)
After discussion change only affects error message that is more user-friendly now.
I also added two tests that check how open_tables function works in both cases:
with number of open tables less tha 1000 and greater than 1000
2022-03-22 09:33:05 -03:00
svetasmirnova
3767e57e15 PT-2037 - added test for the situation when both --system-only and --mysql-only are specified 2022-01-27 19:21:04 +03:00
svetasmirnova
623fdaec91 PT-2037 - option --system-only for pt-stalk
This commit:
1. Moves all changes to the proper place: lib/bash/collect.sh
2. Refactors pt-stalk so it is more modular
3. Places fix for PT-1734 into the right place: lib/bash/collect.sh
4. Fixes tests for PT-1336
2022-01-22 21:21:05 +03:00
svetasmirnova
1f6c95f524 PT-2037 - reviewer suggestions
Refactoring pt-stalk to make it easier to call system and MySQL data collections separately
2022-01-21 04:12:43 +03:00
svetasmirnova
d6e899404e PT-2037 Option --system-only for pt-stalk
Option --system-only triggers only operating system related captures, ignoring all others.
2022-01-19 18:41:05 +03:00
Sveta Smirnova
b2860eee31 PT-1336 pt-stalk removes user files from destination (#524)
* PT-1336 Added file name checks and -maxdepth 1 parameter

* PT-1336 pt-stalk removes user files from the destination directory

* Added check that files to be removed were created by pt-stalk

* Added option -maxdepth 1 to find command, so the tool does not search for files in the nested directories

* Added unit tests

* This should fix PT-1812 also
2021-12-10 09:18:18 -03:00
Carlos Salguero
9b20208a78 Re-merged PT-242 2018-07-05 11:04:44 -03:00
guriandoro
b775701551 Merge branch '3.0' into pt-stalk-collect-prepared-statements-LP1642750
Conflicts:
	bin/pt-stalk
	lib/bash/collect.sh
2017-06-10 11:45:33 -04:00
Carlos Salguero
fcd1cb173f More 5.7 tests fixed 2017-04-27 16:44:46 -03:00
Carlos Salguero
a7ffe2e032 Fixed tests for pt-stalk 2017-04-13 11:41:08 -03:00
Carlos Salguero
be971eeee5 PT-80 Collect replication slave information 2017-03-27 17:30:06 -03:00
guriandoro
32745039b5 Merge branch '3.0' into pt-stalk-collect-prepared-statements-LP1642750 2017-03-22 16:19:19 -04:00
Carlos Salguero
6f5585c493 Fixed pt-stalk mysql version comparisson 2017-03-22 16:57:53 -03:00
guriandoro
bbe373cd22 PT-90 Fixed function name and typos in test result string 2017-03-22 11:51:36 -04:00
guriandoro
6a960b6bfb PT-90 Adding file needed for tests 2017-03-22 11:37:41 -04:00
guriandoro
00cb8d6874 PT-90 Adding test for new changes 2017-03-22 11:37:09 -04:00
Carlos Salguero
4a056cf3b0 PT-81 Collect information about locks and transactions using P_S 2017-03-21 13:45:59 -03:00
Frank Cizmich
c149dbf5ff fixes pt-stalk not being to handle non-integers - issue 1335322 2014-06-27 17:49:50 -03:00
Daniel Nichter
2a1654c47b Merge pt-stalk-sleep-collect-option. 2013-12-13 20:31:53 -08:00
Daniel Nichter
69586fdf50 Revert r587: *do* sync on clock ticks. Fix pt-stalk.t (127.1 no longer works?). Enhance --sleep-collect docs. 2013-12-13 20:19:51 -08:00
Daniel Nichter
5f4891c795 Remove debug stuff from pt-stalk.t 2013-08-12 20:45:38 -07:00
Daniel Nichter
fdb9f5f291 Test debug. 2013-08-09 20:24:14 +00:00
Daniel Nichter
4babbc703c Test debug. 2013-08-09 20:20:19 +00:00
Daniel Nichter
732a5b90f4 Test debug. 2013-08-09 20:09:48 +00:00
Daniel Nichter
8a959cb6ad Test debug. 2013-08-09 20:04:25 +00:00
Daniel Nichter
6e7d1e851c Test debug. 2013-08-09 19:50:49 +00:00
Brian Fraser
59cd002335 Fix for 1156867: pt-stalk doesn't print the function name being used 2013-04-08 10:13:56 -03:00
Daniel Nichter
e3346332e1 Merge pt-ms-pt-stalk-standard-mysql-options. 2013-03-09 11:57:41 -07:00
Brian Fraser
6e964261b7 update-samples on pt-ms 2013-03-06 14:13:05 -03:00
Daniel Nichter
0da15fb083 Make --no-stalk _not_ force --iterations and other options. Extensively update the tool's docs. 2013-03-04 15:57:52 -07:00
Daniel Nichter
a56097fe6c Fix typo in t/pt-stalk/option_sanity.t. 2013-01-24 11:45:44 -07:00
Daniel Nichter
26cc08d3d9 Fix default log level in log_warn_die.sh. 2013-01-24 11:39:23 -07:00
Daniel Nichter
b196f50e60 Test --verbose. Remove global default OPT_VERBOSE from log_warn_die.sh so tool's option can set it. 2013-01-24 11:13:39 -07:00
Daniel Nichter
c077b1eb3d Include collector output in diag. 2012-10-23 17:51:59 -06:00
Daniel Nichter
d97912ef1c Even more waiting for _really_ slow Ubuntu 12 box. 2012-10-23 17:31:05 -06:00
Daniel Nichter
78e1f95257 Really wait for expected data in files. 2012-10-23 17:20:05 -06:00
Daniel Nichter
36ca6bbc23 Make "not stalking" tests more reliable. 2012-10-23 16:54:45 -06:00
Daniel Nichter
8ef6ee451f Wait for collectors before exiting. Use wait_until instead of sleep in pt-stalk.t, and add lots of diag info when tests fail. 2012-10-23 14:42:41 -06:00
Daniel Nichter
c060b650f2 Remove pt conf files before running Jenkins test else they can cause weird results. Make pt-stalk --collect run-time test more liberal. 2012-10-13 12:58:55 -06:00
Daniel Nichter
7ac44ba53a Document --plugin. Remove _hook suffix. 2012-10-03 12:31:36 -06:00
Daniel Nichter
c0bafdead9 Test --plugin. 2012-10-03 11:51:03 -06:00
Brian Fraser fraserb@gmail.com
fdcbbb63fc Bug 942114: bad "find" usage in pt-stalk 2012-08-13 12:39:28 -03:00
Baron Schwartz
af6d7e62ae update pt-stalk test so it works more reliably when passwordless login is set up, and so the cycle-count test is OK with nondeterminism of +/- 1 second 2012-06-04 11:53:44 -04:00
Daniel Nichter
98b384d845 Make pt-stalk/pt-stalk.t stable. Add PerconaTest::not_running(). 2012-06-03 13:29:45 -07:00
Daniel Nichter
bdbb66d22b Re-add calls to Sandbox::ok(). 2012-06-03 13:54:32 -04:00
Daniel Nichter
7423162c87 Make pt-stalk.t a little more reliable. 2012-04-03 11:11:11 -07:00