Commit Graph

476 Commits

Author SHA1 Message Date
Daniel Nichter
dd333380f2 Ignore the new 5.6 mysql stats tables in SchemaIterator and update that module in all tools and updated affected samples. 2012-12-05 18:27:12 +00:00
Daniel Nichter
0b25accdf6 Merge trunk r478. 2012-12-04 16:54:50 -07:00
Daniel Nichter
510efda1b3 Update ExplainAnalyzer.t, QueryReportFormatter.t, and SchemaIterator.t for MySQL 5.6. 2012-12-04 23:47:20 +00:00
Brian Fraser
d2f1742606 Merged fix-917770-pt-config-diff-uninit-value-crash 2012-12-04 13:43:40 -03:00
Daniel Nichter
9bd431e8b7 Use mysql.columns_priv instead of mysql.host as the empty table because mysql.host doesn't exist in 5.6. 2012-12-04 01:50:32 +00:00
Brian Fraser
76a010abee Fix for 917770: Use of uninitialized value in substitution (s///) at pt-config-diff line 1996
This turned out to be two bugs mangled into one.

First, _parse_varvals can deal with (var, undef), but not with (undef).
This is a problem because two of the trhee spots that call
_parse_varvals can return undef because of this:

      map  { $_ =~ m/^([^=]+)(?:=(.*))?$/ }
      grep { $_ !~ m/^\s*#/ }  # no # comment lines
      split("\n", $mysqld_section)

The problem is twofold. First, we are not skipping empty or
whitespace-only lines. That means that the map will fail,
and pass an undef to _parse_varvals. So this ended up in
a triple fix: Make _parse_varvals deal with a sole undef,
skip empty/whitespace lines, and change that map to

	map  { $_ =~ m/^([^=]+)(?:=(.*))?$/ ? ($1, $2) : () }

so even if the regex fails in the future, no sole undef
will be passed down the chain.
2012-11-30 16:17:45 -03:00
Daniel Nichter
90a91cd384 Merge pt-osc-pxc-tests. 2012-11-29 17:10:51 -07:00
Brian Fraser
713457226a Merged fix-887638-ptqa-negative-at-byte 2012-11-29 17:09:33 -03:00
Daniel Nichter
432b9e42b3 Remove time zone stuff from sakila.sql and update NibbleIterator.t tests. 2012-11-28 15:00:30 -07:00
Brian Fraser
b1e0aac38f Fixed various failing tests 2012-11-21 17:04:42 -03:00
Brian Fraser
06115737ee Fix for 887638: pt-query-digest prints negative byte offset 2012-11-15 15:17:03 -03:00
Brian Fraser
c811d60ae1 Pushed the lib/Percona/Toolkit.pm version, and added extra tests to t/lib/Percona/Toolkit.t 2012-11-13 12:10:25 -03:00
Brian Fraser fraserb@gmail.com
d63fd536f0 Lose dependency on File::Slurp append_file and prepend_file 2012-11-12 10:37:13 -03:00
Brian Fraser fraserb@gmail.com
718e49ffcf Merged test-Percona-Toolkit-VERSION 2012-11-10 16:27:10 -03:00
Brian Fraser
57740c4101 Missing /g in a Quoter regex 2012-11-10 09:54:39 -03:00
Brian Fraser
cafb2b3fb5 Merged fix-1062563-1063912-ptc-pxc-bugs 2012-11-09 18:41:32 -03:00
Brian Fraser
511a402911 Merged fix-1047335-crashed-tables 2012-11-09 13:48:17 -03:00
Brian Fraser
d827c7228d Merged OptionParser-remove-optional_value & updated modules 2012-11-09 13:31:13 -03:00
Brian Fraser
ab65692708 Split the Percona::XtraDB::Cluster tests in two files: One that requires a PXC sandbox, and a general tests file 2012-11-09 13:07:08 -03:00
Brian Fraser
7e459f2c24 t/lib/samples/bug_1047335_crashed_table.sql: Use a single INSERT with all the values instead of 1k statements 2012-11-09 12:34:07 -03:00
Brian Fraser
173a5766be Fixes per Daniel's review 2012-11-09 12:07:14 -03:00
Brian Fraser
7beb0b518e Reverted a few unnecessary changes 2012-11-08 17:47:00 -03:00
Brian Fraser
42a9cf4b6e Merged fix-1062563-1063912-ptc-pxc-bugs and resolved conflicts, added the missing Percona::XtraDB::Cluster file 2012-11-08 17:38:04 -03:00
Brian Fraser
bb47e4cdcc Removed the L option from the dsn_opts exported by PerconaTest, as it was useless and breaking tests, and added an L=1 to a leftover pt-archiver --bulk-insert call 2012-11-07 08:54:39 -03:00
Brian Fraser
470c4b9d41 Add some extra safety to t/lib/Percona/Toolkit.t in case we are not ebing run under a bzr directory 2012-11-07 04:42:04 -03:00
Brian Fraser
02a21749b0 Added t/lib/Percona/Toolkit.t 2012-11-07 04:35:43 -03:00
Brian Fraser
58b32bb5ef Merged fix-1073532-Mo-Scalar-Util-PP 2012-11-07 04:12:37 -03:00
Brian Fraser
aa79c9df57 Moved the PXC-dealing parts of Cxn.pm into Percona::XtraDB::Cluster 2012-11-07 04:06:50 -03:00
Daniel Nichter
e8cfb37341 Move ptc PXC tests from bugs.t to pxc.t. Remove 2>&1 from Sandbox.pm shell-outs: we should let errors go to stderr so we can trap them. Fix skip count in Cxn.t for PXC tests. 2012-11-06 16:10:01 -07:00
Brian Fraser
d3c7a059e7 Fixes per Daniel's review 2012-11-06 11:35:49 -03:00
Daniel Nichter
a0cd575c95 Merge fix-1009510-1039569-ptc-check-table-on-replicas 2012-11-05 10:54:21 -07:00
Daniel Nichter
0cffac95de Simplify how ptc checks slave tables. Move that code from TableParser to pt_table_checksum::check_slave_tables. Change --[no]check-replicate-table-columns to --[no]check-slave-tables. Move tests to error_handling.t. 2012-11-02 15:22:47 -06:00
Brian Fraser
6720831fd1 Merged fix-1059732-ptc-hash-functions 2012-11-02 01:23:59 -03:00
Brian Fraser
78da81fea5 Fixed a typo and added some regression tests 2012-11-01 17:04:00 -03:00
Brian Fraser fraserb@gmail.com
e6158cd2f8 Fix for 1073532: Mo doesn't work with Scalar::Util::PP
Unlike Scalar::Util, Scalar::Util::PP::looks_like_number shifts @_,
so calling it as &looks_like_number works differently in both
versions; see https://rt.cpan.org/Public/Bug/Display.html?id=80525
2012-10-31 12:04:30 -03:00
Brian Fraser
b9bfe6114c Merged fix-821715-enable-local-infile-in-dsn 2012-10-30 22:12:57 -03:00
Daniel Nichter
376572e637 Merge fix-995896-cat-in-daemon 2012-10-30 17:04:22 -06:00
Daniel Nichter
c8b31431b0 Handle slurp_file error specifically. Fix Daemon.t test plans. 2012-10-30 16:57:06 -06:00
Brian Fraser
ad4d69b3e2 Removed local $EVAL_ERROR, added a test using t/lib/samples/broken_tbl.frm, and updated all modules 2012-10-30 19:02:03 -03:00
Brian Fraser
35f5f8d1e4 Fix for 1047335: SchemaIterator fails when it encounters a crashed table 2012-10-30 18:35:49 -03:00
Brian Fraser fraserb@gmail.com
6e3d3e6c96 Removed optional_value, made --version-check have default: off, updated the tools and documentation with the changes, and added the auto value to Pingback.pm 2012-10-30 12:42:42 -03:00
Brian Fraser fraserb@gmail.com
19f55542a2 Fix for 1059732: pt-table-checksum doesn't test all hash functions 2012-10-30 12:38:31 -03:00
Daniel Nichter
e69f1f24d0 Remove $Sandbox::Percona::Toolkit::VERSION and use $Percona::Toolkit::VERSION instead since it's the authoritative version. 2012-10-24 13:52:10 -06:00
Daniel Nichter
33f75e069d Fix some test plans. 2012-10-24 13:36:32 -06:00
Daniel Nichter
9b920bc5a5 Conditionalize the number of files expected: 14 or 15 depending on if the box has a default my.cnf somewhere. 2012-10-24 13:03:45 -06:00
Daniel Nichter
b6072ab011 Only cat cnf file > mysql-config-file if it exists. 2012-10-24 12:43:26 -06:00
Daniel Nichter
a94605c825 Use sys default cnf file since test machines have different ones. 2012-10-24 12:08:30 -06:00
Daniel Nichter
aacdd9db17 Rewrite find_my_cnf_file() so if a port is given only that port's cnf is returned, else nothing. 2012-10-24 11:17:34 -06:00
Daniel Nichter
af1240b6f6 Test cases. 2012-10-22 12:16:42 -06:00
Daniel Nichter
046c4c7cc0 Make CompareResults.t stable--yet another case of not waiting for replication. 2012-10-20 20:18:55 -06:00