Commit Graph

594 Commits

Author SHA1 Message Date
Daniel Nichter
510efda1b3 Update ExplainAnalyzer.t, QueryReportFormatter.t, and SchemaIterator.t for MySQL 5.6. 2012-12-04 23:47:20 +00:00
Brian Fraser
d2f1742606 Merged fix-917770-pt-config-diff-uninit-value-crash 2012-12-04 13:43:40 -03:00
Daniel Nichter
9bd431e8b7 Use mysql.columns_priv instead of mysql.host as the empty table because mysql.host doesn't exist in 5.6. 2012-12-04 01:50:32 +00:00
Brian Fraser
d98f8e04c9 Fix for 1078887: Don't clobber the sql_mode set by the script with set-vars 2012-12-03 00:43:10 -03:00
Brian Fraser
9522fae2f9 Added an extra test for section_percona_server_features on 5.1 2012-11-30 18:23:59 -03:00
Brian Fraser
a3527f748c Fixed the Smooth Flushing report on 5.1, which was broken by the previous commit, and made it work on 5.5 2012-11-30 18:17:30 -03:00
Brian Fraser
76a010abee Fix for 917770: Use of uninitialized value in substitution (s///) at pt-config-diff line 1996
This turned out to be two bugs mangled into one.

First, _parse_varvals can deal with (var, undef), but not with (undef).
This is a problem because two of the trhee spots that call
_parse_varvals can return undef because of this:

      map  { $_ =~ m/^([^=]+)(?:=(.*))?$/ }
      grep { $_ !~ m/^\s*#/ }  # no # comment lines
      split("\n", $mysqld_section)

The problem is twofold. First, we are not skipping empty or
whitespace-only lines. That means that the map will fail,
and pass an undef to _parse_varvals. So this ended up in
a triple fix: Make _parse_varvals deal with a sole undef,
skip empty/whitespace lines, and change that map to

	map  { $_ =~ m/^([^=]+)(?:=(.*))?$/ ? ($1, $2) : () }

so even if the regex fails in the future, no sole undef
will be passed down the chain.
2012-11-30 16:17:45 -03:00
Daniel Nichter
90a91cd384 Merge pt-osc-pxc-tests. 2012-11-29 17:10:51 -07:00
Brian Fraser
98707e937c pt-mysql-summary: Feedback from Fred & Jay; Display wsrep_slave_threads, and also parse & display pc.ignore_sb, pc.ignore_quorum, gcache.size, gcache.dir, gcache.name, all from wsrep_provider_options 2012-11-29 19:38:50 -03:00
Brian Fraser
713457226a Merged fix-887638-ptqa-negative-at-byte 2012-11-29 17:09:33 -03:00
Daniel Nichter
432b9e42b3 Remove time zone stuff from sakila.sql and update NibbleIterator.t tests. 2012-11-28 15:00:30 -07:00
Brian Fraser fraserb@gmail.com
d47b9f1f95 pt-mysql-summary: Start reporting some PXC info 2012-11-27 19:05:45 -03:00
Brian Fraser fraserb@gmail.com
bb75e6a6b7 pt-mysql-summary: Make the "Instances" section work if the instances were started with --defaults-file 2012-11-27 18:19:47 -03:00
Brian Fraser
b1e0aac38f Fixed various failing tests 2012-11-21 17:04:42 -03:00
Brian Fraser
270a4710fb Removed a useless part of the regex that looked for something function-like, and made the NULL check case-insensitive 2012-11-16 12:04:14 -03:00
Brian Fraser
06115737ee Fix for 887638: pt-query-digest prints negative byte offset 2012-11-15 15:17:03 -03:00
Daniel Nichter
9b105ee2d2 Make GeneralLogParser.pm understand the "as" part of a Connect command. 2012-11-14 11:38:55 -07:00
Brian Fraser
c811d60ae1 Pushed the lib/Percona/Toolkit.pm version, and added extra tests to t/lib/Percona/Toolkit.t 2012-11-13 12:10:25 -03:00
Brian Fraser fraserb@gmail.com
22ec559b38 Fix for 986847: Allow setting which commands (and extra options) pt-stalk uses through env vars 2012-11-12 11:26:01 -03:00
Brian Fraser fraserb@gmail.com
d63fd536f0 Lose dependency on File::Slurp append_file and prepend_file 2012-11-12 10:37:13 -03:00
Brian Fraser fraserb@gmail.com
718e49ffcf Merged test-Percona-Toolkit-VERSION 2012-11-10 16:27:10 -03:00
Brian Fraser
57740c4101 Missing /g in a Quoter regex 2012-11-10 09:54:39 -03:00
Brian Fraser
b3dd48af15 Change the behavior to resume+ignore-databases to mimic resume+ignore-tables; now it starts from the next table. 2012-11-09 22:07:10 -03:00
Brian Fraser
cafb2b3fb5 Merged fix-1062563-1063912-ptc-pxc-bugs 2012-11-09 18:41:32 -03:00
Brian Fraser
511a402911 Merged fix-1047335-crashed-tables 2012-11-09 13:48:17 -03:00
Brian Fraser
d827c7228d Merged OptionParser-remove-optional_value & updated modules 2012-11-09 13:31:13 -03:00
Brian Fraser
ab65692708 Split the Percona::XtraDB::Cluster tests in two files: One that requires a PXC sandbox, and a general tests file 2012-11-09 13:07:08 -03:00
Brian Fraser
7e459f2c24 t/lib/samples/bug_1047335_crashed_table.sql: Use a single INSERT with all the values instead of 1k statements 2012-11-09 12:34:07 -03:00
Brian Fraser
173a5766be Fixes per Daniel's review 2012-11-09 12:07:14 -03:00
Brian Fraser
7beb0b518e Reverted a few unnecessary changes 2012-11-08 17:47:00 -03:00
Brian Fraser
42a9cf4b6e Merged fix-1062563-1063912-ptc-pxc-bugs and resolved conflicts, added the missing Percona::XtraDB::Cluster file 2012-11-08 17:38:04 -03:00
Brian Fraser
426d599566 Fix for 911385: pt-table-checksum v2 fails when --resume + --ignore-database is used 2012-11-08 13:42:29 -03:00
Brian Fraser
c711c57859 Test for 933465: pt-query-advisor false positive on RES.001 2012-11-07 09:51:35 -03:00
Brian Fraser
bb47e4cdcc Removed the L option from the dsn_opts exported by PerconaTest, as it was useless and breaking tests, and added an L=1 to a leftover pt-archiver --bulk-insert call 2012-11-07 08:54:39 -03:00
Brian Fraser
470c4b9d41 Add some extra safety to t/lib/Percona/Toolkit.t in case we are not ebing run under a bzr directory 2012-11-07 04:42:04 -03:00
Brian Fraser
02a21749b0 Added t/lib/Percona/Toolkit.t 2012-11-07 04:35:43 -03:00
Brian Fraser
58b32bb5ef Merged fix-1073532-Mo-Scalar-Util-PP 2012-11-07 04:12:37 -03:00
Brian Fraser
aa79c9df57 Moved the PXC-dealing parts of Cxn.pm into Percona::XtraDB::Cluster 2012-11-07 04:06:50 -03:00
Daniel Nichter
e8cfb37341 Move ptc PXC tests from bugs.t to pxc.t. Remove 2>&1 from Sandbox.pm shell-outs: we should let errors go to stderr so we can trap them. Fix skip count in Cxn.t for PXC tests. 2012-11-06 16:10:01 -07:00
Brian Fraser
d3c7a059e7 Fixes per Daniel's review 2012-11-06 11:35:49 -03:00
Daniel Nichter
a0cd575c95 Merge fix-1009510-1039569-ptc-check-table-on-replicas 2012-11-05 10:54:21 -07:00
Daniel Nichter
0cffac95de Simplify how ptc checks slave tables. Move that code from TableParser to pt_table_checksum::check_slave_tables. Change --[no]check-replicate-table-columns to --[no]check-slave-tables. Move tests to error_handling.t. 2012-11-02 15:22:47 -06:00
Brian Fraser
5fd150de31 Extra tweaks due to feedback from kaiwangchen: ; starts comments if at the start of a line 2012-11-02 01:58:12 -03:00
Brian Fraser
6720831fd1 Merged fix-1059732-ptc-hash-functions 2012-11-02 01:23:59 -03:00
Brian Fraser
1aa154d6c6 Fix for 996069: Incorrect RES.001 when using aggregate functions 2012-11-02 01:18:10 -03:00
Brian Fraser
227dfa6ea7 Fix for 1015590: pt-mysql-summary not Percona Server 5.5-ready 2012-11-02 00:21:48 -03:00
Brian Fraser
78da81fea5 Fixed a typo and added some regression tests 2012-11-01 17:04:00 -03:00
Brian Fraser
4b5c8969f0 Fix for 937234: pt-query-advisor issues wrong RES.001 2012-11-01 05:33:35 -03:00
Brian Fraser fraserb@gmail.com
e6158cd2f8 Fix for 1073532: Mo doesn't work with Scalar::Util::PP
Unlike Scalar::Util, Scalar::Util::PP::looks_like_number shifts @_,
so calling it as &looks_like_number works differently in both
versions; see https://rt.cpan.org/Public/Bug/Display.html?id=80525
2012-10-31 12:04:30 -03:00
Brian Fraser
517ec595e9 Add missing log file 2012-10-31 06:51:49 -03:00