Daniel Nichter
9404ff84ef
Rewrite pt-diskstats.t but all tests need to be fixed. Update modules in pt-diskstats, use PTDEBUG, check regex opts. Remove output_fh from Diskstats. Fix DiskstatsMenu header so update-modules can see it.
2012-01-12 12:06:50 -07:00
Daniel Nichter
8d70a272fe
Simplify parse_diskstats_line() and _calc_delta_for(). Use UPPERCASE for constants. Don't save unused values in dev stats array. Use actual values from an OptionParser/pt-diskstats.
2012-01-12 10:09:40 -07:00
Brian Fraser
3165b3c0f8
Slew of changes from Daniel's review.
2012-01-12 10:37:49 -03:00
Daniel Nichter
a9afea4506
Quote vals in Bash libs. Add tests for log_warn_die.sh and alt_cmds.sh. Make --help test path independent.
2012-01-11 11:31:41 -07:00
Brian Fraser
6d47e958c7
Change ->filter_zeroed_rows into ->zero_rows.
2012-01-10 16:28:32 -03:00
Brian Fraser
13210d1978
Explicit setter for filename.
2012-01-10 14:16:44 -03:00
Brian Fraser
5ad1bc4fbb
Explicit setter for device_regex and column_regex.
2012-01-10 14:14:32 -03:00
Brian Fraser
93279a03da
Explicit setter for out_fh.
2012-01-10 14:05:02 -03:00
Brian Fraser
187d921069
Explicit setter for filter_zeroed_rows
2012-01-10 13:46:05 -03:00
Brian Fraser
25909caa4e
Explicit setters for (curr|prev|first)_ts.
2012-01-10 13:40:51 -03:00
Brian Fraser
9fd8e8d61d
Make a test clean up after itself.
2012-01-10 11:26:11 -03:00
Brian Fraser
b4289010b1
Several fixes. --save-samples and --help should work now.
2012-01-10 10:47:50 -03:00
Daniel Nichter
a85dffd511
Test for bug 821709.
2012-01-09 11:10:35 -07:00
Daniel Nichter
520948c14e
Update sample files.
2012-01-05 11:54:27 -07:00
Daniel Nichter
f4362cb2e7
Test and fix bug 911996.
2012-01-05 11:46:38 -07:00
Brian Fraser
0ca763c81b
pt-mysql-summary: Use mktemp through the tmpdir package.
2012-01-03 14:52:57 -03:00
Daniel Nichter
d1bd7a9f3b
Change MKDEBUG to PTDEBUG. Remove 1.0.2 from release notes.
2011-12-30 09:23:41 -07:00
Daniel Nichter
cf10e3e521
Merge lp:~percona-toolkit-dev/percona-toolkit/pt-table-checksum-2.0.
2011-12-29 17:39:26 -07:00
Daniel Nichter
c58dfca1b5
Use latest Quoter::(de)serialize_list() in pt-table-checksum and pt-table-sync. Add more char_chunking.t tests for pt-table-checksum.
2011-12-29 17:25:38 -07:00
Brian Fraser
1f06ea093a
Modified (de)serialize_list to handle undefs and empty string elements better.
2011-12-29 17:22:17 -03:00
Daniel Nichter
6088ffa43d
Use new Quoter (de)serialize_list() in pt-table-checksum and pt-table-sync.
2011-12-28 17:12:12 -07:00
Brian Fraser
85817a795c
Slight improvement to the deserialize regex and its test output.
2011-12-28 20:08:30 -03:00
Daniel Nichter
4197b09f53
Adjust code spacing, tweak comments, do only (de)serialize tests with database, give tests names.
2011-12-28 15:47:50 -07:00
Brian Fraser
88e82d665d
Include serialize_list() and deserialize_list() to roundtrip through a DB.
2011-12-28 16:44:49 -03:00
Daniel Nichter
8013939057
Merge lp:~percona-toolkit-dev/percona-toolkit/pt-align r257..260 (branch was accidently created from pt-table-checksum-2.0 branch instead of 2.0 branch).
2011-12-28 11:40:59 -07:00
Daniel Nichter
e00dca5e8f
Add pt-ioprofile tests.
2011-12-28 10:21:07 -07:00
Daniel Nichter
ba8e64d81d
Fix typo, add stub test and a little more docu.
2011-12-27 16:39:56 -07:00
Daniel Nichter
09cd535d3a
Merge lp:~daniel-nichter/percona-toolkit/bash-tool-libs.
2011-12-27 15:37:09 -07:00
Daniel Nichter
56375da166
Make replication_filters.t stable.
2011-12-27 15:11:35 -07:00
Daniel Nichter
e299b877ad
Update fnv_64.t and replication_filters.t.
2011-12-27 11:50:33 -07:00
Daniel Nichter
f122861808
Fix --where with one nibble. Update chunk_index.t.
2011-12-27 11:12:40 -07:00
Daniel Nichter
66c0abfe8e
Don't reset @crc or @cnt. Docu output of --replicate-check-only.
2011-12-27 10:24:35 -07:00
Daniel Nichter
70d8f08f7b
Use sandbox 12348 instead of 12347.
2011-12-22 16:11:16 -07:00
Daniel Nichter
c97e8ec563
Update issue_408.t and update issue_560.t.
2011-12-22 15:50:52 -07:00
Daniel Nichter
b63bc4c26b
Convert pt-table-checksum boundaries to SQL WHERE clauses.
2011-12-22 15:43:15 -07:00
Brian Fraser
d3ef9edaaa
Several corrections as per Daniel and Baron's feedback.
...
Still TODO: Attributes still have a single method that doubles
as a getter and setter. The constructor for Diskstats is still
weird -- A tad more stricter than it should be, if anything.
->print_rest is still rest, even though that's hardly
memorable, mostly because of a lack of ideas on what to
rename it. The main loop in the Menu is still a while (1).
As a nice perk, it's nearly twice as fast now! It also adds a
_very_ experimental --memory-for-speed argument, which
turns on memoization for the current biggest bottleneck.
2011-12-22 19:24:56 -03:00
Daniel Nichter
1d8da408fc
Revert to r243 to undo pt-table-sync changes.
2011-12-22 12:06:25 -07:00
Daniel Nichter
2760322c87
Don't bidi cmp equal rows. Commit if not --lock and using txn. Fix pt-table-sync basics.t.
2011-12-22 12:01:03 -07:00
Daniel Nichter
cfc57c71af
Make pt-table-sync --replicate work with pt-table-checksum 2.0.
2011-12-22 10:10:22 -07:00
Daniel Nichter
255b276435
Make pt-table-sync use new NibbleIterator-only TableSyncer, and also use Cxn.
2011-12-21 21:13:19 -07:00
Daniel Nichter
457fa70668
Fix TableSyncer trace msg, implement --explain, fix locking/committing. Add aux dbh, dbh opts, and disconnect() to Cxn.
2011-12-21 21:12:03 -07:00
Daniel Nichter
ec8471ba28
Finish rewriting TableSyncer and updating its test. Add RowSyncerBidirectional.pm. Add GENLOG switch to start-sandbox.
2011-12-21 12:10:57 -07:00
Daniel Nichter
4c8fd5c080
Rewrite TableSyncer to use only NibbleIterator. Add RowSyncer. Return hashref from NibbleIterator.
2011-12-21 01:19:50 -07:00
Brian Fraser
467254aca3
Fixes to the Menu; additionally, changed the accepted format for samples.
...
Also made it hide rows that are all zeroes by default, as per the
blueprint.
2011-12-20 12:53:35 -03:00
Daniel Nichter
6fad44d58c
Change SQL for --resume last chunk to fix bug 898318.
2011-12-19 15:48:52 -07:00
Daniel Nichter
d3b074b14e
Don't ORDER BY in the nibble sql.
2011-12-19 14:25:48 -07:00
Daniel Nichter
5d2e60791c
Don't add ORDER BY to nibble SQL by default.
2011-12-19 14:17:11 -07:00
Daniel Nichter
5fc8ea1f70
Merge Merge lp:~daniel-nichter/percona-toolkit/bash-tool-libs r135.
2011-12-19 12:53:09 -07:00
Daniel Nichter
9baea8b7b6
Convert parse_option to sh, use Perl instead of awk, implement --help.
2011-12-19 12:51:47 -07:00
Daniel Nichter
0a88c57bf9
Merge lp:~daniel-nichter/percona-toolkit/bash-tool-libs r134.
2011-12-19 11:31:00 -07:00
