Daniel Nichter
0ad52d0003
Update DSNParser in pt-table-usage and pt-visual-explain to avoid https://refute.testnoir.com/percona-toolkit/jobs/percona-toolkit-mysql-5.6/2/results/errors#18960 because Sandbox sets {L} but new DSNParser is needed to check for and delete it.
2012-12-04 15:42:14 -07:00
Brian Fraser
2bc72fc139
Fix for 1086259: pt-kill in non-daemon mode logs timestamps incorrectly
2012-12-04 18:05:32 -03:00
Brian Fraser
d2f1742606
Merged fix-917770-pt-config-diff-uninit-value-crash
2012-12-04 13:43:40 -03:00
Brian Fraser
e0c8fac54e
Merged doc-patch-empty-replicate-table-1074179
2012-12-04 13:42:22 -03:00
Brian Fraser
a5d1021367
Rename "Cluster" to "Cluster Name" and "Node" to "Node Name"
2012-12-04 13:26:34 -03:00
Brian Fraser
15855fb076
Change feat_on_renamed() per Daniel's feedback
2012-12-04 13:17:58 -03:00
Brian Fraser
a7a0da3bc9
Refactor _parse_varvals.
...
Now it takes two arguments: A regexp and a string to match against.
_parse_varvals itself was split in three: _preprocess_varvals,
_parse_varvals, and _process_val.
This also modifies the three places that call _parse_varvals; For
two, no real changes were needed, but parse_mysqld() required a fix
to deal with the two final lines of mysqld --help --verbose:
To see what values a running MySQL server is using, type
'mysqladmin variables' instead of 'mysqld --verbose --help'.
2012-12-04 05:02:56 -03:00
Brian Fraser
ee607b1f25
Change the ordering in the PXC section
2012-12-04 00:39:34 -03:00
Daniel Nichter
c094494f1f
Fix CMD_MYSQL and CMD_MYSQLDUMP in pt-mysql-summary so they can be specified on cmd line, then do so in pt-mysql-summary.t so mysqldump 5.6 is used with 5.6 because earlier versions don't work with MySQL 5.6.
2012-12-04 01:31:52 +00:00
Daniel Nichter
e7c3e908bb
Create percona_test.sentinel in start-sandbox so wait_for_slave() works for other sandboxes. skip_all for skip_innodb.t with 5.6 because of http://bugs.mysql.com/67798 .
2012-12-04 00:14:20 +00:00
Brian Fraser
40e5d050a6
Update modules for all tools using DSNParser
2012-12-03 00:48:11 -03:00
Brian Fraser
a3527f748c
Fixed the Smooth Flushing report on 5.1, which was broken by the previous commit, and made it work on 5.5
2012-11-30 18:17:30 -03:00
Daniel Nichter
e69533e492
Test with MyISAM tables. Add PXC section to pt-archiver docs.
2012-11-30 19:25:35 +00:00
Brian Fraser
76a010abee
Fix for 917770: Use of uninitialized value in substitution (s///) at pt-config-diff line 1996
...
This turned out to be two bugs mangled into one.
First, _parse_varvals can deal with (var, undef), but not with (undef).
This is a problem because two of the trhee spots that call
_parse_varvals can return undef because of this:
map { $_ =~ m/^([^=]+)(?:=(.*))?$/ }
grep { $_ !~ m/^\s*#/ } # no # comment lines
split("\n", $mysqld_section)
The problem is twofold. First, we are not skipping empty or
whitespace-only lines. That means that the map will fail,
and pass an undef to _parse_varvals. So this ended up in
a triple fix: Make _parse_varvals deal with a sole undef,
skip empty/whitespace lines, and change that map to
map { $_ =~ m/^([^=]+)(?:=(.*))?$/ ? ($1, $2) : () }
so even if the regex fails in the future, no sole undef
will be passed down the chain.
2012-11-30 16:17:45 -03:00
Brian Fraser
739babd9bf
Remove the B<> and reword the new text
2012-11-29 22:48:13 -03:00
Brian Fraser
ee41d4deb4
Introduce feat_on_renamed, a wrapper around feat_on for renamed variables
2012-11-29 22:32:22 -03:00
Daniel Nichter
90a91cd384
Merge pt-osc-pxc-tests.
2012-11-29 17:10:51 -07:00
Daniel Nichter
8549fe5d99
Test and require wsrep_OSU_method=TOI.
2012-11-29 23:26:53 +00:00
Brian Fraser
98707e937c
pt-mysql-summary: Feedback from Fred & Jay; Display wsrep_slave_threads, and also parse & display pc.ignore_sb, pc.ignore_quorum, gcache.size, gcache.dir, gcache.name, all from wsrep_provider_options
2012-11-29 19:38:50 -03:00
Daniel Nichter
13318a9710
Update modules in ptc.
2012-11-29 22:32:31 +00:00
Daniel Nichter
9e97edebd2
Check PXC version in ptc and pt-osc, die if < 5.5.28.
2012-11-29 22:26:46 +00:00
Daniel Nichter
10c8654a49
Update PXC section in ptc and pt-osc docs to say that 5.5.28-23.7 is required, not 5.5.27-23.6 because of bug 1040108.
2012-11-29 22:09:32 +00:00
Brian Fraser
ff3d496cf0
pt-mysql-summary: Make sure the Status Counters don't use scientific notation
2012-11-29 18:08:59 -03:00
Brian Fraser
e71d3adb96
Merged fix-1079341-pt-osc-skip-myisam-fk-checks
2012-11-29 17:15:56 -03:00
Brian Fraser
2614eabd31
Merged fix-1074179-ptc-replicate-check-only-filters
2012-11-29 17:14:14 -03:00
Brian Fraser
b37c138ec8
Merged fix-1052475-ptc-uninit-crash-slave-errors
2012-11-29 17:12:29 -03:00
Brian Fraser
cddead8a69
Merged fix-831525-pqd-mangled-help
2012-11-29 17:10:54 -03:00
Brian Fraser
713457226a
Merged fix-887638-ptqa-negative-at-byte
2012-11-29 17:09:33 -03:00
Daniel Nichter
e9d064c816
Fix a code comment.
2012-11-28 21:19:52 +00:00
Daniel Nichter
824c34b5d2
Only check --alter if given. Fix some tests, add add_col to make some tests work on PXC or not.
2012-11-28 21:11:29 +00:00
Daniel Nichter
d515e3b382
r472 was a miscommit: it includes new --check-alter check for cluster node+MyISAM node and pxc.t.
2012-11-28 17:58:40 +00:00
Daniel Nichter
61b352a04d
Fix sandbox/load-sakila-db so it exits on error.
2012-11-28 17:55:35 +00:00
Brian Fraser fraserb@gmail.com
d47b9f1f95
pt-mysql-summary: Start reporting some PXC info
2012-11-27 19:05:45 -03:00
Brian Fraser fraserb@gmail.com
f915e54a17
pt-mysql-summary: Make the "Executables" section work
2012-11-27 18:28:07 -03:00
Brian Fraser fraserb@gmail.com
bb75e6a6b7
pt-mysql-summary: Make the "Instances" section work if the instances were started with --defaults-file
2012-11-27 18:19:47 -03:00
Brian Fraser fraserb@gmail.com
84043cee75
parse_options.sh: Make sure that --help works under sh
2012-11-27 18:05:53 -03:00
Daniel Nichter
ea1c6f6ca9
Add lock_in_share_mode option to NibbleIterator. Silence query_table.pl diag messages.
2012-11-27 17:41:05 +00:00
Brian Fraser
9b17aacb04
Fix 1082104: pt-deadlock-logger problem when a username has a dash
2012-11-23 19:11:50 -03:00
Daniel Nichter
9d1004ddbb
Check and update tool versions, release notes, user docs, etc. before build.
2012-11-19 18:47:13 +00:00
Daniel Nichter
92e1242d00
Update Percona::Toolkit::VERSION and Changelog.
2012-11-19 18:41:34 +00:00
Daniel Nichter
2c85a47a45
Alphabetize the opts and fix 2 typos.
2012-11-19 11:19:33 -07:00
Daniel Nichter
38b9230d8c
Finish PXC section of ptc docs.
2012-11-19 11:09:14 -07:00
Daniel Nichter
e0f0ea0cdb
Rewrite and enhance lib/Percona/XtraDB/Cluster.pm and t/pt-table-checksum/pxc.t. Change how ptc handles various cluster issues. Change lib/Sandbox.pm subs like start_sandbox() and start_cluster(). PXC docs in ptc are a work in progress.
2012-11-18 22:05:30 -07:00
Daniel Nichter
07bee85a00
Don't check binlog_format on cluster nodes.
2012-11-17 12:55:18 -07:00
Brian Fraser
270a4710fb
Removed a useless part of the regex that looked for something function-like, and made the NULL check case-insensitive
2012-11-16 12:04:14 -03:00
Brian Fraser
55a17166c6
Merged fix-1041391-rowchecker-wrong-debug-statement
2012-11-16 11:36:59 -03:00
Brian Fraser
b031df3a7e
Doc patch emphasizing how --empty-replicate-table works
2012-11-16 11:21:44 -03:00
Brian Fraser
54e9dc1a46
Fix for 1079341: Skip foreign key checks on MyISAM tables
2012-11-16 10:58:30 -03:00
Brian Fraser
06115737ee
Fix for 887638: pt-query-digest prints negative byte offset
2012-11-15 15:17:03 -03:00
Daniel Nichter
9b105ee2d2
Make GeneralLogParser.pm understand the "as" part of a Connect command.
2012-11-14 11:38:55 -07:00
