Commit Graph

85 Commits

Author SHA1 Message Date
Sveta Smirnova
1bec1fdde8 Remove unused variable force_concat_enums
- Removed variable
- Adjusted utils/update-modules, so it does not process symlinks
2024-12-31 20:14:16 +03:00
Viktor Szépe
2bd40d8c39 Remove trailing spaces (#665)
* Remove trailing spaces

* PR-665 -  Remove trailing spaces

- Updated not stable test t/pt-online-schema-change/preserve_triggers.t
- Updated utilities in bin directory

* PR-665 -  Remove trailing spaces

- Fixed typos

* PR-665 -  Remove trailing spaces

- Fixed typos

---------

Co-authored-by: Sveta Smirnova <sveta.smirnova@percona.com>
2023-09-06 01:15:12 +03:00
Viktor Szépe
c57441be8c War on typos Act 1 (#655)
* Fix typos in lib/ directory

* Update generated bin/ files

* PR 655 -  War on typos Act 1 #655

- Updated modules in tools that were not updated
- Fixed tests to reflect proposed changes

---------

Co-authored-by: Sveta Smirnova <sveta.smirnova@percona.com>
2023-08-22 16:18:38 +03:00
Sveta Smirnova
a7efd8c94e PT-2138 - fix tests for pt table checksum (#568)
* PT-2138 - Fix tests for pt-table-checksum

- Updated t/pt-table-checksum/samples/default-results-8.0.txt and
t/pt-table-checksum/samples/static-chunk-size-results-8.0.txt
to support latest MySQL 8.0 version. Tests are now incompatible with elder 8.0 releases.
- Put fix for PT-136 into package RowChecksum
- Added execution bit for pt-online-schema-change

* PT-2138 - Fix tests for pt-table-checksum

- Fixed percona_test.load_data, so it really tests if LOAD DATA LOCAL INFILE is enabled
- Fixed option --[no]create-replicate-table, broken by commit c9836d5962

* PT-2138 - Fix tests for pt-table-checksum

- Enabled t/pt-table-checksum/error_handling.t for MySQL 8.0
- Fixed test t/pt-table-checksum/fnv_64.t and it's samples file
t/pt-table-checksum/samples/fnv64-sakila-city.txt
to reflect new function name convention and
changes after 62d84e5dba

* PT-2138 - Fix tests for pt-table-checksum

- Fixed t/pt-table-checksum/issue_1485195.t, so it checks only one table and
isn't get broken when we add tables into percona_test database
- Fixed typo in error output of bin/pt-table-checksum
- Skipped issue_47.t in 8.0 until https://jira.percona.com/browse/PT-1805 is fixed

* PT-2138 - Fix tests for pt-table-checksum

- Disabled pt-131.t for 8.0, because it does not have the QUERY_RESPONSE_TIME plugins
- Added SLOW_TESTS check to pt-1616.t
- Updated pt-226.t to include the fix for PT-1766
- For replication_filters.t: excluded false positive expression for tests 10 and 11 and added sys schema to the list of checked databases for 8.0
- Changed get_slaves in lib/MasterSlave.pm, so it returns slave's parent, required for wait_for_slaves in pt-table-checksum to work properly with chained slaves

* PT-2138 - Fix tests for pt-table-checksum

- Modified pt-204.t  to support 8.0 and diffs in system tables due to timestamps
Moved the fix for PT-1616 into the proper place: lib/NibbleIterator.pm

* PT-2138 - Fix tests for pt-table-checksum

- pxc.t -added mysql.proxies_priv into ignore list, because its timestamp is different on node
- pxc.t - removed FORK=pxc from statup options for slave (non-cluster) nodes
- pxc.t - disabled wsrep replication with help of the variable wsrep_on: sql_log_bin doesn't disable wsrep replication anymore. See https://jira.percona.com/browse/PXC-3464 for details
- Removed data.tar.gz from 5.7 sandbox configuration, because it has an outdated definition for Performance Schema
- Disabled pxc.t for version 8.0 until PT-1699 is fixed
- start-sandbox - removed the first line (ALTER USER) from the init file, because it was rewritten by the next echo command, and then repeated later.

* PT-2138 - Fix tests for pt-table-checksum

- Adopted issue_1485195.t and basics.t for MyRocks-enabled setup
- replication_filters.t - added sys schema to the list of expected schemas for 5.7 and 8.0
- issue_1485195.t - added checks for the existence of mysql.plugin, func, and proxies_priv tables
- added samples/pt-131-wipe.sql that uninstalls QRT plugin if it was earlier installed by this test
-adjusted return code in pt-204.t, because expected differences in mysql.proxies_priv

* Update lib/PerconaTest.pm

removed diagnostic code

Co-authored-by: Carlos Salguero <carlos.salguero@percona.com>

Co-authored-by: Carlos Salguero <carlos.salguero@percona.com>
2022-12-28 23:09:13 +03:00
Carlos Salguero
13f7afc49d PT-1757 Fixed NibbleIterator undef 2019-10-14 14:44:57 -03:00
Carlos Salguero
6a302e2b07 PT-1757 Implemented fallback in NibbleIterator
Since now NibbleIterator can fallback to nibble (from one chunk) pt-osc
can nibble tables even if due to unacurate stats, it choses one nible as
the initial nibbling method.
2019-10-13 21:58:56 -03:00
Carlos Salguero
e58b9fbea8 PT-1757 fallback to nibble in NibbleIterator 2019-10-08 21:24:59 -03:00
Carlos Salguero
a6e0b0d324 WIP 2019-10-08 13:10:26 -03:00
Carlos Salguero
424a48518c PT-1114 test fix 2019-01-11 15:43:38 -03:00
Carlos Salguero
8c806df658 PT-1572 Fixed issue with --chunk-index-columns 2018-08-09 13:58:31 -03:00
Carlos Salguero
ea4886ad9d PT-1572 WIP 2018-07-27 22:16:02 -03:00
Carlos Salguero
c91350f2eb Added pause to NibbleIterator 2016-11-01 19:05:49 -03:00
Carlos Salguero
cc8f750f60 Fixed sort order fro ENUM fields 2016-08-21 20:52:25 -03:00
frank-cizmich
a4b9b941d6 Merge branch 'pt-tcs-where-option-using-non-optimal-index-lp1576036' of github.com:percona/percona-toolkit into pt-tcs-where-option-using-non-optimal-index-lp1576036 2016-05-11 18:13:35 -03:00
frank-cizmich
47cc4225d8 corrected index choosing bug in NibbleHandler 2016-05-11 17:54:46 -03:00
frank-cizmich
162d4dcd28 corrected index choosing bug in NibbleHandler 2016-04-29 07:23:42 -03:00
Daniel Nichter
51e476c6a2 Fix bug: a typo in NibbleIterator::_find_best_index(). 2013-07-10 10:23:28 -07:00
Daniel Nichter
5a34a0817e Fix bug 968596: rename NibbleIterator::chunk_size() to limit() and update ptc and pt-osc. 2013-02-28 19:26:04 -07:00
Daniel Nichter
feab2f0925 s/Percona Inc/Percona Ireland Ltd/g 2013-01-02 17:19:16 -07:00
Daniel Nichter
ea1c6f6ca9 Add lock_in_share_mode option to NibbleIterator. Silence query_table.pl diag messages. 2012-11-27 17:41:05 +00:00
Daniel Nichter
2290827eee Stop nibbling if chunking but not first lower boundary because table is empty. Print test debug via diag(). 2012-07-26 16:44:24 -06:00
Daniel Nichter
272f963733 Remove --chunk-index-columns and extend --chunk-index instead to take INDEX:N value. Add n_index_values to TableNibbler. 2012-06-10 10:01:25 -04:00
Daniel Nichter
2a92a0a0ff Check key_len for each chunk to ensure it doesn't decrease. Add --[no]check-plan. 2012-06-09 22:23:00 -04:00
Daniel Nichter
1c23b615b2 Add XXX comments where the Perl oddity is being used. 2012-05-10 10:21:44 -06:00
Daniel Nichter
f4957ba911 Use --chunk-size-limit || 1 for checking if a table can be done in one chunk to avoid chunking empty tables. Checksums for empty tables are now written. 2012-05-10 09:55:42 -06:00
Daniel Nichter
715f0f86e1 Merge fix-undef-arrayref-bug-995274. 2012-05-08 17:02:58 -06:00
Daniel Nichter
884d02bc2a Lowercase index from EXPLAIN (unless it's PRIMARY) to match lowercase ident names from TableParser::parser(). 2012-05-08 16:51:35 -06:00
Daniel Nichter
30b6b88766 Restore original NibbleIterator and implement simpler solution: only use MySQL's chosen index if --where. 2012-05-08 12:43:47 -06:00
Daniel Nichter
e2073065b1 EXPLAIN actual ascending nibble query to get MySQL's chosen index, and use that instead of the tool's chosen index. TODO: fix OobNibbleIterator.t and chunk_index.t. 2012-05-04 17:46:34 -06:00
Daniel Nichter
0089f31a35 Merge pt-osc-2.1. Fix NibbleItertor.pm to work with OobNibbleIterator when resuming at oob boundaries (t/pt-table-checksum/resume.t was failing). 2012-04-03 09:33:10 -06:00
Daniel Nichter
403c93db3b Handle Key_name or key_name in NibbleIterator::_get_index_cardinality(). 2012-04-02 19:24:38 -06:00
Daniel Nichter
34ada21344 Add comment about code that will fail with new Cxn due to NAME_lc. 2012-04-02 19:12:28 -06:00
Daniel Nichter
c04b85a066 Update SchemaIterator, TableParser, and NibbleIterator in tools that use them. All tools' tests still pass. 2012-03-31 09:59:15 -06:00
Daniel Nichter
fcc3a44e23 Update alter_active_table.t and fix NibbleIterator to handle a growing table. 2012-03-29 15:23:38 -06:00
Daniel Nichter
45c1f3bfb6 Make NibbleIter query comments customizable. Update the module in pt-table-checksum and pt-osc. 2012-03-25 10:37:19 -06:00
Daniel Nichter
20d2aa7a08 Make NibbleIterator check for options before using them. 2012-03-22 11:28:58 -06:00
Daniel Nichter
a17bdd65d3 Rewriting pt-online-schema-change 2.1.1. Work in progress (this code doesn't work yet). 2012-03-20 13:34:16 -06:00
Daniel Nichter
df4662ce51 Compare index names lc but save them in their original case. 2012-02-06 13:29:08 -07:00
Daniel Nichter
f517675eb4 Compare lc(index) everywhere. 2012-02-03 11:38:20 -07:00
Daniel Nichter
88304e69fb Replace MKDEBUG with PTDEBUG in modules. 2012-01-19 12:46:56 -07:00
Daniel Nichter
f122861808 Fix --where with one nibble. Update chunk_index.t. 2011-12-27 11:12:40 -07:00
Daniel Nichter
1d8da408fc Revert to r243 to undo pt-table-sync changes. 2011-12-22 12:06:25 -07:00
Daniel Nichter
cfc57c71af Make pt-table-sync --replicate work with pt-table-checksum 2.0. 2011-12-22 10:10:22 -07:00
Daniel Nichter
ec8471ba28 Finish rewriting TableSyncer and updating its test. Add RowSyncerBidirectional.pm. Add GENLOG switch to start-sandbox. 2011-12-21 12:10:57 -07:00
Daniel Nichter
4c8fd5c080 Rewrite TableSyncer to use only NibbleIterator. Add RowSyncer. Return hashref from NibbleIterator. 2011-12-21 01:19:50 -07:00
Daniel Nichter
5d2e60791c Don't add ORDER BY to nibble SQL by default. 2011-12-19 14:17:11 -07:00
Daniel Nichter
06b99e987c Don't checksum 1=1 on master if table on slave is too large. 2011-11-17 13:15:26 -07:00
Daniel Nichter
7b8736c1f5 Use SELECT * instead of SELECT COUNT(*) to avoid 'Select tables optimized away'. Make _get_row_estimate() "public". 2011-11-17 12:15:21 -07:00
Daniel Nichter
ff78656859 Fix various resume issues. 2011-11-17 11:20:00 -07:00
Daniel Nichter
42bd00c4d6 Handle resume in OobNibbleIterator. 2011-11-16 11:10:34 -07:00