Commit Graph

162 Commits

Author SHA1 Message Date
Brian Fraser fraserb@gmail.com
22ec559b38 Fix for 986847: Allow setting which commands (and extra options) pt-stalk uses through env vars 2012-11-12 11:26:01 -03:00
Brian Fraser
227dfa6ea7 Fix for 1015590: pt-mysql-summary not Percona Server 5.5-ready 2012-11-02 00:21:48 -03:00
Daniel Nichter
b6072ab011 Only cat cnf file > mysql-config-file if it exists. 2012-10-24 12:43:26 -06:00
Daniel Nichter
aacdd9db17 Rewrite find_my_cnf_file() so if a port is given only that port's cnf is returned, else nothing. 2012-10-24 11:17:34 -06:00
Daniel Nichter
328b7f1e0e Merge fix-deleting-empty-files-bug-1047701 2012-10-13 14:15:37 -06:00
Daniel Nichter
d04529a64b Wait --run-time more for collector procs to finish, then kill them, then remove empty files. 2012-10-13 12:21:52 -06:00
Brian Fraser fraserb@gmail.com
df2278b95c Merged fix-903229-pt-mysql-summary-case-insensitivity-for-engines 2012-10-12 17:38:12 -03:00
Daniel Nichter
e1bd108aa4 Collect INNODB_TRX, INNODB_LOCKS, and INNODB_LOCK_WAITS. Fix update-module so it works again with Bash tools. 2012-08-30 15:40:09 -06:00
Brian Fraser
289035a303 Merged fix-1038995-bash-options-starting-with-no 2012-08-28 22:05:33 -03:00
Brian Fraser fraserb@gmail.com
acc7c0296b Merged fix-952722-pt-summary-fio-cards 2012-08-27 15:37:43 -03:00
Brian Fraser fraserb@gmail.com
548e01fddd Fix for 903229: pt-mysql-summary incorrectly categorizes databases 2012-08-24 20:18:36 -03:00
Brian Fraser
d53fadff74 Merged quote-tr-arguments 2012-08-24 20:02:48 -03:00
Brian Fraser
ed7b497590 Report Rated PBW for fio cards 2012-08-24 19:39:58 -03:00
Brian Fraser
878528b859 Fixed report_fio_minus_a and fio_status_minus_a to handle ioMemory and report internal temp, also fixed some bugs 2012-08-24 18:23:30 -03:00
Brian Fraser
24ae24a64e Fix for 952722: pt-summary to show information about Fusion-io cards 2012-08-24 17:01:47 -03:00
Brian Fraser fraserb@gmail.com
c2b006eeaf Fix for 1038995: pt-stalk notify-by-email fails 2012-08-20 19:22:31 -03:00
Daniel Nichter
3602bb252f Use non-Bashism indirect reference in parse_options. Change $@ to ${@:-} and update parse_options in all tools. 2012-08-14 11:46:47 -06:00
Daniel Nichter
9ddf90eeca Use ${@:-""} rather than $@, prevents error on ksh when no opts given. Remove set +u to see if it is no longer needed. 2012-08-14 11:07:10 -06:00
Daniel Nichter
b5ba79bb6d Collect df -k instead of df -h. Set log_error with abs path to fix failing t/lib/bash/collect.t test. 2012-08-14 09:11:41 -06:00
Brian Fraser fraserb@gmail.com
7f9f84a6d0 shell tools: Quote the arguments to tr 2012-08-13 12:23:18 -03:00
Brian Fraser fraserb@gmail.com
3b1f3dbbe5 Fix for 977226: pt-summary doesn't detect LSI RAID control. Patch provided by Dave Juntgen (djuntgen) 2012-07-30 12:36:55 -03:00
Daniel Nichter
487d14228b Handle --nofoo like --no-foo in parse_options.sh and update the Bash tools. 2012-07-21 11:57:53 -06:00
Daniel Nichter
e1b39b3d5f Use TRUE/FALSE for typeless option values in --help. Update parse_options.sh lib in Bash tools. 2012-07-21 11:40:39 -06:00
Brian Fraser fraserb@gmail.com
bc8f5a610c Change TMPDIR to PT_TMPDIR 2012-06-11 17:51:43 -03:00
Daniel Nichter
bf2a769536 Export TMPDIR to make tmpdir.t pass. 2012-06-11 13:28:14 -07:00
Brian Fraser fraserb@gmail.com
07081d5761 tmpdir.sh: Use the -t flag for mktemp 2012-06-11 17:07:38 -03:00
Brian Fraser fraserb@gmail.com
865b3e4e9d collect_system_info shouldn't assume that sysctl is available.
It isn't on CentOS 5.5. It didn't really assume that it
was always there, but rather than the produced samples file
would be.
2012-06-04 11:57:44 -03:00
Baron Schwartz
48f642551e fix some problems that happen when there are many mysqld instances 2012-06-03 20:53:57 -04:00
Daniel Nichter
696a3b5e68 Fix mem/file size shortening in pt-summary and pt-mysql-summary. 2012-06-03 14:49:35 -07:00
Daniel Nichter
d46285342a Use 6 X with mktemp to make it work on some platforms and update all tools. 2012-05-16 11:38:48 -06:00
Daniel Nichter
cc80f278d5 Code comment why MiB, GiB, etc. are used in shorten() and update that func in pt-summary and pt-mysql-summary. 2012-05-07 16:38:30 -06:00
Daniel Nichter
fdfd305dc5 Simplify and fix report_formatting::shorten(), and add Petabyte unit (in case it's needed). Update affected test samples. Add T_DIR to util/test-bash-functions. 2012-05-07 12:16:24 -06:00
Daniel Nichter
0286631514 Merge summary-tools-2.1. 2012-04-03 10:14:55 -06:00
Brian Fraser fraserb@gmail.com
a01de98434 Fix for a bug in 32-bit Debian.
Namely, awk's printf("%d") doing what it's supposed to do, cast
it's operand to (int), which screws up large numbers.
The fix is simple, although it mostly just pushes the problem
under the rug; using %.0f instead of %d.
2012-04-03 12:50:12 -03:00
Brian Fraser fraserb@gmail.com
b807088b8e Other instances of the substr(var, 0, n) bug 2012-04-03 11:29:36 -03:00
Brian Fraser fraserb@gmail.com
cfcef354b0 section(): Less printf, more awk 2012-04-03 11:07:30 -03:00
Brian Fraser fraserb@gmail.com
12bd26022a Fix a section() bug.
Turns out that awk's indexes are documented to start from 1;
So what happens if you use 0? Apparently it's undefined behavior, so
substr(var, 0, 5);
and
substr(var, 1, 5);
May or may not actually do the same thing. In Debian 6, the former
doesn't quite work, and actually returns something like substr(var, 1, 4),
which broke section()'s output.
2012-04-03 10:55:51 -03:00
Brian Fraser fraserb@gmail.com
c0dedd19bf - section() revamp
- Redirect STDERR for the collection part in both tools
- rm_tempdir in sigtrap
- A part of pt-mysql-summary still depended on the system being run,
  rather than the samples being read. Now it works properly.
2012-04-02 19:25:17 -03:00
Brian Fraser fraserb@gmail.com
6dbbd6de3b The previous merge went a bit wrong, and left the libraries unsynced with the tools; This commit fixes it. 2012-04-02 13:36:17 -03:00
Brian Fraser fraserb@gmail.com
761f8a5aac Merge more of Baron's changes, also re-implement the MySQL Executables section
Plus other bugfixes.
2012-03-30 23:00:57 -03:00
Brian Fraser fraserb@gmail.com
978b236985 Save the config file itself, not just its path. 2012-03-30 20:18:39 -03:00
baron
06dc18ec46 clean up a couple of things causing tests to fail for me, and remove a feature that's not quite ready yet, and add another feature for innodb compression 2012-03-30 17:07:05 -04:00
baron
d44e8b539b clean up a couple of things causing tests to fail for me, and remove a feature that's not quite ready yet, and add another feature for innodb compression 2012-03-30 17:04:25 -04:00
Brian Fraser fraserb@gmail.com
562a550a39 Fixes 2012-03-30 17:23:55 -03:00
Daniel Nichter
94d9483d03 Make vmstat, iostat, and mpstat run for --run-time not --interval. 2012-03-30 11:35:32 -06:00
Brian Fraser fraserb@gmail.com
33a4096663 Fix CPU_ARCH collection for Linux 2012-03-30 13:44:21 -03:00
Brian Fraser fraserb@gmail.com
f8113b4676 A parse_ethtools() that actually works 2012-03-29 19:44:51 -03:00
Brian Fraser fraserb@gmail.com
996a76a68e pt-summary shouldn't leave empty files; both summary tools should
die if passed a --save-samples directory that has files in it.
2012-03-29 19:21:32 -03:00
Brian Fraser fraserb@gmail.com
3ee8f9ba71 Fixed the Table Cache bugs.
Also makes t/lib/bash/collect_system_info.sh actually call setup_commands.
2012-03-28 15:29:57 -03:00
Brian Fraser fraserb@gmail.com
4bb5968c23 More fixes as per the reviews.
- Took out ${prefix}-
- get_var sanity
- pt-mysql-summary now follows pt-summary's suit and doesn't take
  in files to write to
- pt-summary defers setting the CMD_FOO vars to a function, as
  otherwise it would skip our PATH mungling.
2012-03-28 13:04:14 -03:00