Commit Graph

12 Commits

Author SHA1 Message Date
Brian Fraser
66cad706b3 Add missing test files 2013-03-06 18:13:37 -03:00
Brian Fraser
d005aa1c41 Added two missing config files fort/pt-config-diff/basics.t 2012-12-13 21:47:26 -03:00
Brian Fraser
0681986dee Merged fix-1022622-ptcd-case-sensitivity 2012-12-11 11:45:29 -03:00
Brian Fraser
76a010abee Fix for 917770: Use of uninitialized value in substitution (s///) at pt-config-diff line 1996
This turned out to be two bugs mangled into one.

First, _parse_varvals can deal with (var, undef), but not with (undef).
This is a problem because two of the trhee spots that call
_parse_varvals can return undef because of this:

      map  { $_ =~ m/^([^=]+)(?:=(.*))?$/ }
      grep { $_ !~ m/^\s*#/ }  # no # comment lines
      split("\n", $mysqld_section)

The problem is twofold. First, we are not skipping empty or
whitespace-only lines. That means that the map will fail,
and pass an undef to _parse_varvals. So this ended up in
a triple fix: Make _parse_varvals deal with a sole undef,
skip empty/whitespace lines, and change that map to

	map  { $_ =~ m/^([^=]+)(?:=(.*))?$/ ? ($1, $2) : () }

so even if the regex fails in the future, no sole undef
will be passed down the chain.
2012-11-30 16:17:45 -03:00
Brian Fraser
ac015477af Bug 1022622: pt-config-diff is case-sensitive 2012-07-27 20:12:45 -03:00
Daniel Nichter
a64bf961e8 Fix test counts. 2012-06-03 15:14:30 -04:00
Daniel Nichter
a2810a0ec1 Remove duplicate calls to Sandbox::ok(). 2012-06-03 14:38:21 -04:00
Daniel Nichter
bdbb66d22b Re-add calls to Sandbox::ok(). 2012-06-03 13:54:32 -04:00
Daniel Nichter
7e880b0808 Call Sandbox::box() in all tests that use Sandbox. 2012-06-03 12:59:56 -04:00
Daniel Nichter
eb01431399 Change MaatkitTest to PerconaTest in all tool tests. Add stub tests for pt-align and pt-collect. 2011-07-12 16:56:55 -06:00
Daniel Nichter
8e11cd85b3 Change mk_tool::main() to pt_tool::main() in all tests. 2011-06-29 11:56:49 -06:00
Daniel Nichter
b4b6376be1 Add forked Maatkit tools in bin/ and their tests in t/. 2011-06-24 16:02:05 -06:00